Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix a typo in api/stream.md #11804

Closed
wants to merge 1 commit into from
Closed

doc: fix a typo in api/stream.md #11804

wants to merge 1 commit into from

Conversation

Alex-Sokolov
Copy link
Contributor

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

documentation

Description of changes

Fix comment that listener must be removed before unshifting

@Alex-Sokolov
Update stream.md
8b431b3 
Fix comment about remove listener (not setting)
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Mar 11, 2017
@mscdex
Copy link
Contributor

mscdex commented Mar 11, 2017

LGTM

jasnell pushed a commit that referenced this pull request Mar 15, 2017
@Alex-Sokolov @jasnell
doc: correct comment error in stream.md
8b03221 
Fix comment about remove listener (not setting)

PR-URL: #11804
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Brian White <[email protected]>
@jasnell
Copy link
Member

jasnell commented Mar 15, 2017

Landed in 8b03221. Thank you!

@jasnell jasnell closed this Mar 15, 2017
@Alex-Sokolov Alex-Sokolov deleted the patch-1 branch March 15, 2017 07:33
italoacasas pushed a commit to italoacasas/node that referenced this pull request Mar 20, 2017
@Alex-Sokolov @italoacasas
doc: correct comment error in stream.md
ae52b63 
Fix comment about remove listener (not setting)

PR-URL: nodejs#11804
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Brian White <[email protected]>
@italoacasas italoacasas mentioned this pull request Mar 20, 2017
Merged
jungx098 pushed a commit to jungx098/node that referenced this pull request Mar 21, 2017
@Alex-Sokolov @jungx098
doc: correct comment error in stream.md
83a59e1 
Fix comment about remove listener (not setting)

PR-URL: nodejs#11804
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Brian White <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 18, 2017
@Alex-Sokolov @MylesBorins
doc: correct comment error in stream.md
6d61296 
Fix comment about remove listener (not setting)

PR-URL: #11804
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Brian White <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
@Alex-Sokolov @MylesBorins
doc: correct comment error in stream.md
463f294 
Fix comment about remove listener (not setting)

PR-URL: #11804
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Brian White <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Apr 19, 2017
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@Alex-Sokolov @andrew749
doc: correct comment error in stream.md
c4b3b51 
Fix comment about remove listener (not setting)

PR-URL: nodejs/node#11804
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Brian White <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Alex-Sokolov @mscdex @jasnell @addaleax @lpinca @targos @cjihrig @MylesBorins @nodejs-github-bot