Fatal V8 Compiler Error

[tristanhoy]

• Version: 6.10.2
• Platform: 64-bit Windows (also tested on Linux, not sure which arch)
• Subsystem: V8 Compiler

The third line in the following script causes an error in the v8 compiler:

const sphincs = require('sphincs') // npm install [email protected]
console.log('blah')
const keyPair = sphincs.keyPair()

blah


#
# Fatal error in ..\..\src\compiler.cc, line 786
# Check failed: !info->shared_info()->feedback_vector()->metadata()->SpecDiffersFrom( info->literal()->feedback_vector_spec()).
#

Node 7.8.0 (V8 5.5.372) is not affected.

This module is an emscripten transpile, and the issue specifically affects the optimised emcc -O3 build. The compiled, minified source is 107KB so I've made no attempts to debug any further.

An option suggested to the module author is to create a legacy build with less optimisations - so there's certainly workarounds in this case, but could this be a symptom of a deeper issue?

Are there any plans to upgrade V8 for 6.x?

[mscdex]

/cc @nodejs/v8

[hashseed]

@ripsawridge @bmeurer

[bmeurer]

Looks like one of those bugs that @ripsawridge fixed, where the feedback vector layout differed between parsing and preparsing.

[buu700]

I just had a chance to investigate this (I'm the module author), and it turns out that this actually has nothing to do with the emscripten compiler options.

The problem is triggered by a workaround I'd used to make this module work in both Node and webpack with no additional required configuration: specifically, replacing all instances of require( with eval("require")(. I feel like there must be a more elegant way to accomplish this, but that solution worked well enough and did what I needed at the time.

Also, here's my stack trace from Node 6.10.2 on Debian Jessie x86-64 if it's helpful (error message is the same as @tristanhoy's):

==== C stack trace ===============================

 1: V8_Fatal
 2: 0xb4548b
 3: v8::internal::Compiler::EnsureDeoptimizationSupport(v8::internal::CompilationInfo*)
 4: 0xb4d3a5
 5: 0xb4e9dd
 6: v8::internal::Compiler::CompileOptimized(v8::internal::Handle<v8::internal::JSFunction>, v8::internal::Compiler::ConcurrencyMode)
 7: v8::internal::Runtime_CompileOptimized_Concurrent(int, v8::internal::Object**, v8::internal::Isolate*)
 8: 0x2f37853092a7
Illegal instruction

[bnoordhuis]

I can confirm the issue but I suspect this will be hard to fix due to the size of the changes between v6.x and v7.x.

It looks like @bmeurer was spot on, the info->shared_info()->feedback_vector() type feedback vector has an extra KEYED_LOAD_IC and a LOAD_IC that should have been a KEYED_LOAD_IC.

[bmeurer]

I'm pretty sure @ripsawridge fixed that. He might be able to point you to the proper fix. He'll be back in the office next week. I'll point him to this issue.

[ripsawridge]

Hi y'all. Yeah, if you look at my git log in the dates in question, I'll usually mention "vector" and "parser" in the fix. But indeed, I'll have a look next week, now I'm on slow-net on a mountainside :p. --Michael

…

On Thu, Apr 13, 2017 at 6:05 AM, Benedikt Meurer ***@***.***> wrote: I'm pretty sure @ripsawridge <https://github.com/ripsawridge> fixed that. He might be able to point you to the proper fix. He'll be back in the office next week. I'll point him to this issue. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#12308 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AF1Fo0ApLh7bciCywh7wPs7cQTkofTlGks5rvZ8FgaJpZM4M5BpH> .

[ripsawridge]

I found a few candidates:

https://bugs.chromium.org/p/chromium/issues/detail?id=620119
Fixed in June 2016, Merged to 5.2.361.33

https://bugs.chromium.org/p/chromium/issues/detail?id=608279
Fixed in May 2016, Not merged anywhere.

https://bugs.chromium.org/p/chromium/issues/detail?id=600995
Fixed in April 2016, Merged to 5.1.281.10

[ripsawridge]

Okay, the issue is https://bugs.chromium.org/p/chromium/issues/detail?id=608279.
The fix is an easy merge and the repro disappears.
(here is the CL to port: https://codereview.chromium.org/1950803002/)

[hashseed]

I'll prepare a PR.

[targos]

This was fixed in cd78a2bd07 and released with v6.10.3.