Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: use common malformed instead of misformatted #11518

Closed
wants to merge 1 commit into from

Conversation

jsumners
Copy link
Contributor

@jsumners jsumners commented Feb 23, 2017

This PR updates documentation included in the new well-known CAs feature to change the word "misformatted" to "malformed" since the word "misformatted" is less common.

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. labels Feb 23, 2017
@TimothyGu
Copy link
Member

LGTM, but I prefer the commit message to be a tad mellower, since some dictionaries do consider "misformatted" a word.

@jsumners jsumners changed the title doc: replace non-existent word with real one doc: use common malformed instead of misformatted Feb 23, 2017
@jsumners
Copy link
Contributor Author

@TimothyGu I have updated the commit message.

@Trott
Copy link
Member

Trott commented Feb 24, 2017

If everyone feels good about malformed being better than misformatted, then it might make sense to consider also updating cli.md and/or dns.md. Just noting that. It doesn't have to happen in this PR. (Might even slightly prefer that it doesn't so that it can be a good-first-contribution for someone else.)

@jsumners
Copy link
Contributor Author

I had not seen that documentation in dns.md. I am willing to push the change into this PR if so desired, but I'm also willing to let it be handled by someone else.

@jasnell
Copy link
Member

jasnell commented Mar 1, 2017

Going to land this, we can make further changes in a separate PR

jasnell pushed a commit that referenced this pull request Mar 1, 2017
PR-URL: #11518
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@jasnell
Copy link
Member

jasnell commented Mar 1, 2017

Landed in a520508

@jasnell jasnell closed this Mar 1, 2017
addaleax pushed a commit that referenced this pull request Mar 5, 2017
PR-URL: #11518
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@evanlucas evanlucas mentioned this pull request Mar 8, 2017
MylesBorins pushed a commit that referenced this pull request Apr 17, 2017
PR-URL: #11518
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
PR-URL: #11518
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Apr 19, 2017
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
PR-URL: nodejs/node#11518
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants