Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v6.4.0 Release Proposal #8020

Closed
cjihrig opened this issue Aug 8, 2016 · 22 comments
Closed

v6.4.0 Release Proposal #8020

cjihrig opened this issue Aug 8, 2016 · 22 comments
Labels
meta Issues and PRs related to the general management of the project.

Comments

@cjihrig
Copy link
Contributor

cjihrig commented Aug 8, 2016

Here are the commits, as determined by branch-diff v6.x master --exclude-label=semver-major,dont-land-on-v6.x --filter-release:

  • [e925b62771] - doc: fix cluster message event docs (Zach Bjornson) #8017
  • [4c62892a4b] - test: console constructor missing new keyword (Rich Trott) #8003
  • [8726a1c318] - tools: enable linting for chained properties (Rich Trott) #7999
  • [e313c0286b] - tools: update to ESLint 3.2.2 (Rich Trott) #7999
  • [49e473a45f] - test: fix failing inspector cctest (Eugene Ostroukhov) #8019
  • [c628982a06] - doc: add added: information for cluster (Anna Henningsen) #7640
  • [ae25ed3ccd] - benchmark: favor === over == (Rich Trott) #8000
  • [1b99093df7] - timers: remove unused repeat param in timer_wrap (Jan Schär) #7994
  • [dabac8a2fb] - doc: remove spurious new line in CHANGELOG_V6.md (Luigi Pinca) #8009
  • [1a6a69a8e0] - (SEMVER-MINOR) util: add inspect.defaultOptions (Roman Reiss) #8013
  • [a8438a0438] - test,assert: add deepEqual/deepStrictEqual tests for typed arrays (Feross Aboukhadijeh) #8002
  • [387ab62939] - assert: fix deepEqual/deepStrictEqual on equivalent typed arrays (Feross Aboukhadijeh) #8002
  • [bb3b4d7d49] - doc: fix typo in vm.runInNewContext() description (Luigi Pinca) #8005
  • [a7222052d4] - build: add correct shared library naming on OS X (Stewart Addison) #7687
  • [e03a7b2a2b] - build: turn on thin static archives (Ben Noordhuis) #7957
  • [55852e1421] - module: fix node_modules search path in edge case (hefangshi) #6670
  • [5111e789e6] - deps: float gyp patch for long filenames (Anna Henningsen) #7963
  • [eb172feebf] - doc: Clean up roff source in manpage (Alhadis) #7819
  • [4a87abb8e8] - (SEMVER-MINOR) fs: add bytesRead to ReadStream (Linus Unnebäck) #7942
  • [f59b8888f1] - repl: disable Ctrl+C support on win32 for now (Anna Henningsen) #7977
  • [43ef58005e] - src: remove unused using decls (Haojian Wu) #7990
  • [827eed1ce3] - doc: add CTC meeting minutes 2016-08-03 (Josh Gavant) #7980
  • [35109ddaf2] - lib: remove double check of string type (Franziska Hinkelmann) #7985
  • [accaa34377] - doc: clarify collaborators & ctc members relationships (yorkie) #7996
  • [2d4a521d58] - repl: don't override all internal repl defaults (cjihrig) #7826
  • [f18b1c91b8] - test: allow globals to be whitelisted (cjihrig) #7826
  • [99f45b2476] - (SEMVER-MINOR) child_process: control argv0 for spawned processes (Pat Pannuto) #7696
  • [a804db1af7] - (SEMVER-MINOR) process: save original argv[0] (Pat Pannuto) #7696
  • [beea23af65] - doc: clarify fd closing by fs.readFile etc. (kibertoad) #7561
  • [359352c9e9] - (SEMVER-MINOR) build: export zlib symbols on Windows (Alex Hultman) #7983
  • [be73480eec] - test: fix flaky test-vm-sigint-existing-handler (Anna Henningsen) #7982
  • [b635f7b0e7] - zlib: remove unneeded property (Jan Schär) #7987
  • [4c86fa30d8] - doc: fix a markdown error in CTC meeting minutes (Сковорода Никита Андреевич) #7729
  • [d997448ea6] - tools: add remark-lint configuration in .remarkrc (Сковорода Никита Андреевич) #7729
  • [b779eb423d] - (SEMVER-MINOR) repl: Add editor mode support (Prince J Wesley) #7275
  • [769f63ccd8] - doc: add added: information for events (Luigi Pinca) #7822
  • [66af6a9028] - doc: improve server.listen() random port (Phillip Johnsen) #7976
  • [5d6d3ee5fb] - doc: clarify "Reviewed-By" iff "LGTM" (Bryan English) #7183
  • [9a0d26fa43] - test: remove internal headers from addons (Gibson Fahnestock) #7947
  • [1e1bbe5af7] - tools: add .vscode folder to .gitignore (Josh Gavant) #7967
  • [b866fdc516] - doc: add CTC meeting minutes 2016-07-13 (Josh Gavant) #7968
  • [2458bdb1f0] - doc: add CTC meeting minutes 2016-07-20 (Josh Gavant) #7970
  • [ff7a841f4d] - src: make EnvDelete behave like the delete operator (Franziska Hinkelmann) #7975
  • [cc3a9e7947] - doc: use consistent markdown in README (Rich Trott) #7971
  • [99296eedbe] - http: specify _implicitHeader in OutgoingMessage (yorkie) #7949
  • [0f3f76cada] - doc: use git-secure-tag for release tags (Fedor Indutny) #7603
  • [e3e3588e0e] - meta: clarify process for breaking changes (Rich Trott) #7955
  • [c809b88345] - doc: use blockquotes for Stability: markers (Anna Henningsen) #7757
  • [561958e565] - doc: fix default encoding mention in crypto.md (hugnosis) #7805
  • [588ee2296a] - src: do not copy on failing setProperty() (Franziska Hinkelmann) #7908
  • [a52b1c0580] - doctool: improve the title of pages in doc (yorkie) #7939
    (deps: cherry-pick 6f68f30 from v8 upstream #7802)
  • [c5a18e748d] - _Revert_ "fs: validate args of truncate functions in js" (Myles Borins) #7950
  • [320f433dcd] - util: support classes in util.deprecate() (vladimir) #7690
  • [e1643ccc5a] - doc: fix minor formatting issue in 0.10 changelog (Сковорода Никита Андреевич) #7727
  • [f3f5a89a10] - doc: *.md formatting fixes in the benchmark dir (Сковорода Никита Андреевич) #7727
  • [fc11fe8e5d] - doc: remove extra indentation in iojs changelog (Сковорода Никита Андреевич) #7727
  • [4aa8120aea] - doc: *.md formatting fixes in the top-level dir (Сковорода Никита Андреевич) #7727
  • [9ddc915a9c] - doc: convert tabs to spaces (Сковорода Никита Андреевич) #7727
  • [7400a4a3bd] - doc: piscisaureus has stepped-down from the CTC (James M Snell) #7969
  • [0c73685273] - doc: add @addaleax to the CTC (Anna Henningsen) #7966
  • [c9e670ea2a] - win,msi: fix inclusion of translations (João Reis) #7798
  • [05c15a057f] - build: fix dependency on missing header file (Ben Noordhuis) #7945
  • [c0676f3f0f] - build: fix typo in non-essential source file name (Ben Noordhuis) #7945
  • [b4258bba11] - test: improve chained property readability (Rich Trott) #7920
  • [93ac2ea36e] - test: fix test-vm-sigint flakiness (Santiago Gimeno) #7854
  • [1b24b37299] - util: fix formatting of objects with SIMD enabled (Anna Henningsen) #7864
  • [80b10b4fe2] - src: fix use-after-free in inspector agent (Ben Noordhuis) #7907
  • [75c6d9dd95] - (SEMVER-MINOR) cluster: support stdio option for workers (cjihrig) #7838
  • [6d9a500064] - doc: add CTC meeting minutes 2016-06-22 (Josh Gavant) #7390
  • [681736183c] - doc: add CTC meeting minutes 2016-07-06 (Josh Gavant) #7570
  • [59fd48e5b3] - doc: add CTC meeting minutes 2016-06-29 (Josh Gavant) #7571
  • [1495053046] - meta: include a minimal CTC removal policy (Rich Trott) #7720
  • [eeaff74af2] - build: adding config.gypi dep to addons/.buildstamp (Daniel Bevenius) #7893
  • [8ae227c971] - doc: add CTC meeting minutes 2016-07-27 (William Kapke) #7900
  • [c52a9730b8] - test: don't hard code deprecation count (Prince J Wesley) #7927
  • [65a42ab892] - doc: fix path markdown formatting (Joey Cozza) #7817
  • [6945aa7085] - build: don't link against liblog on host system (Ben Noordhuis) #7762
  • [c8c1f96abe] - src: avoid manual memory management in inspector (Ben Noordhuis) #7906
  • [0190db44ac] - test: fix memory leaks in inspector tests (Ben Noordhuis) #7906
  • [1658297f47] - doc: add missing semicolon (Ravindra barthwal) #7915
  • [0de55d864d] - test: decrease inconsistency in the common.js (Vse Mozhet Byt) #7758
  • [df4ef63aa5] - tools,test: show signal code when test crashes (Santiago Gimeno) #7859
  • [bc464a8a3b] - test: fix flaky test-tls-wrap-timeout (Rich Trott) #7857
  • [f789eb3106] - inspector: Do not crash if the port is n/a (Eugene Ostroukhov) #7874
  • [7d75338c0e] - timers: fix cleanup of nested same-timeout timers (Erin Spiceland) #7827
  • [1896ca9e8e] - doc: fill in missing V8 version (Timothy Gu) #7878
  • [6ea8c669df] - doc: remove extra spaces and concats in examples (Joe Esposito) #7885
  • [8fbdfb9c4e] - test: speed up test-net-reconnect-error (Rich Trott) #7886
  • [99e2d43801] - meta: provide example activities (Rich Trott) #7744
  • [96611d097a] - doc: add information about CTC quorum rules (Rich Trott) #7813
  • [b896057109] - src: unifying PipeConnectWrap and TCPConnectWrap (Daniel Bevenius) #7501
  • [c948877688] - doc: align breakEvalOnSigint - repl option (Prince J Wesley) #7849
  • [868638b903] - doc: remove platform assumption from CONTRIBUTING (Bethany N Griggs) #7783
  • [68ac0d0d7d] - (SEMVER-MINOR) repl: Use displayErrors for SyntaxError (Prince J Wesley) #7589
  • [2554549ab5] - deps: v8_inspector: remove jinja2 tests (Ali Ijaz Sheikh) #7796
  • [7db495ab6d] - doc: update licenses (Ali Ijaz Sheikh) #7796
  • [3534600185] - tools: update license-builder.sh for v8_inspector (Ali Ijaz Sheikh) #7796
  • [4be6271c43] - deps: remove jinja.el from deps/v8_inspector (Ali Ijaz Sheikh) #7796
  • [b9445bfecd] - deps: update v8_inspector (Ali Ijaz Sheikh) #7796
  • [ea725eda42] - test: ensure stream preprocessing order (Vse Mozhet Byt) #7741
  • [1d83013d19] - doc: minor typo fixes in stream docs (Alex Perkins) #7763
  • [34d58ce334] - src: Only use TR1 type_traits on OSX<10.9 (Ehsan Akhgari) #7778
  • [dee0e3a333] - test: use common platform helpers everywhere (Santiago Gimeno) #7845
  • [e22ffefff2] - deps: cherry-pick a76d133 from v8 upstream (Matt Loring) #7689
  • [a3d62bdbaa] - deps: cherry-pick b93c80a from v8 upstream (Matt Loring) #7689
  • [809aabcc13] - src: fix build on CentOS (Rich Trott) #7873
  • [46633934fe] - src: pull OnConnection from pipe_wrap and tcp_wrap (Daniel Bevenius) #7547
  • [b3127df59a] - doc: add/fix version metadata for Buffer methods (Brian White) #7784
  • [ac57089960] - doc: improve function parameter descriptions (Brian White) #7784
  • [3f208c70da] - doc: add missing properties in Buffer docs (Brian White) #7784
  • [87a097da51] - doc: improve wording and style of Buffer docs (Brian White) #7784
  • [cc1318b5ed] - doc: improve links in Buffer docs (Brian White) #7784
  • [344cac112b] - doc: reorganize Buffer link references (Brian White) #7784
  • [fe89848dc6] - doc: improve Buffer code examples (Brian White) #7784
  • [ff3ce11894] - (SEMVER-MINOR) child_process: support stdio option in fork() (cjihrig) #7811
  • [814b8c3cf7] - test: handle IPv6 localhost issues within tests (Rich Trott) #7766
  • [a58b48bc3b] - doc: various documentation formatting fixes (Сковорода Никита Андреевич) #7637
  • [a2a711a373] - (SEMVER-MINOR) dgram: generalized send queue to handle close (Matteo Collina) #7066
  • [c01d61af59] - win,msi: Added Italian translation (Matteo Collina) #4647
  • [b8b8c36b6a] - (SEMVER-MINOR) build: export more openssl symbols on Windows (Alex Hultman) #7576
  • [2d77cba7e7] - test: fix flaky test-*-connect-address-family (Rich Trott) #7605
  • [c9f6776d2b] - (SEMVER-MINOR) crypto: fix undefined behavior in ParseExtension (Fedor Indutny) #7494
  • [46f40cfb4c] - (SEMVER-MINOR) buffer: fix unintended unsigned overflow (Fedor Indutny) #7494
  • [9fbe456db1] - (SEMVER-MINOR) repl: add support for custom completions (Diosney Sarmiento) #7527
  • [18ae74cf98] - src: suppress coverity message (cjihrig) #7587
  • [630096bc80] - src: guard against overflow in ParseArrayIndex() (Ben Noordhuis) #7497
  • [6ae20433c9] - src: move ParseArrayIndex() to src/node_buffer.cc (Ben Noordhuis) #7497
  • [781713d5ef] - src: remove unused isolate member (Ben Noordhuis) #7334
@addaleax
Copy link
Member

addaleax commented Aug 8, 2016

Any chance we can talk about landing #7111 + #7284 as a semver-minor pair in here? I still think it would be great to have these in v6.x. /cc @nodejs/buffer

@jasnell
Copy link
Member

jasnell commented Aug 8, 2016

#7111 is, unfortunately a semver-major because of the ABI change. Given that, we technically can't land it here.

@ChALkeR
Copy link
Member

ChALkeR commented Aug 8, 2016

Do the Revert "fs: commits have the correct formatting?

@addaleax
Copy link
Member

addaleax commented Aug 8, 2016

@jasnell #7284 undoes the part of the change that’s responsible for ABI incompatibility, which is why I’m asking (see also the last few comments at #7111)

@jasnell
Copy link
Member

jasnell commented Aug 8, 2016

hmm.. ok, perhaps then just opening a new backport PR with those combined that can be reviewed separately as a semver-minor against v6.x?

@addaleax
Copy link
Member

addaleax commented Aug 8, 2016

SGTM, I’ll do that. (edit: #8022)

@mscdex mscdex added the meta Issues and PRs related to the general management of the project. label Aug 8, 2016
@Fishrock123
Copy link
Contributor

win,msi: add zh-CN translations for the installer (Minqi Pan) #2569

Wait, haven't we already gotten that? Are you sure this is correct?

@evanlucas
Copy link
Contributor

I pulled it back from v6.3.1 iirc. Something about it breaking the installer

@Fishrock123
Copy link
Contributor

Also, running with --group can be more useful for these places were people look over the list. :D

@cjihrig
Copy link
Contributor Author

cjihrig commented Aug 8, 2016

@evanlucas is it good to go, as of #7798?

Are you sure this is correct?

I would never be sure of such a thing :-) That's why I included the command I ran, in case anyone wanted to double check.

@evanlucas
Copy link
Contributor

@cjihrig tbh, I'm not sure. It looks like the translations require a nightly version of Wix? If so, not sure if we should just hold off until it actually supports the translations or not?

@cjihrig
Copy link
Contributor Author

cjihrig commented Aug 8, 2016

OK, thanks. I'm going to hold it out unless someone confirms otherwise.

@cjihrig
Copy link
Contributor Author

cjihrig commented Aug 10, 2016

I'm going to start the release soon. @addaleax if #8022 is going to get into this release, it would have to land soon.

@addaleax
Copy link
Member

I guess Trevor’s signoff on it is the best I can get right now anyway, so yeah, I’m landing it.

@cjihrig
Copy link
Contributor Author

cjihrig commented Aug 10, 2016

There are currently three outstanding items:

@ofrobots
Copy link
Contributor

I think we should include #7796 as it updates the license. We have a fix in-flight upstream https://codereview.chromium.org/2235753003/ that fixes the issue w/ landing on v6.x. This can be cherry-picked once it lands upstream.

@bnoordhuis
Copy link
Member

#7334

Leaving it out is fine. It's not important, just some refactoring.

@cjihrig
Copy link
Contributor Author

cjihrig commented Aug 10, 2016

It looks like the fix in https://codereview.chromium.org/2235753003/ may have landed already.

@ofrobots
Copy link
Contributor

@cjihrig I have updated #8014 to include the fix, could we include that here? Alternatively I can open a new PR targeting v6.x with just the cherry-pick, but I think the former would be faster.

@cjihrig
Copy link
Contributor Author

cjihrig commented Aug 10, 2016

Yea, I'm fine with cherry-picking the broken update and the new update both back to v6.x.

@mhdawson
Copy link
Member

mhdawson commented Aug 11, 2016

In respect to #7796 we absolutely need to the license update as its prevented us from shipping/consuming (within IBM) 6.x in the last few releases. I believe we should wait until we get the license issue resolved.

cjihrig added a commit that referenced this issue Aug 11, 2016
Notable changes:

* build: zlib symbols and additional OpenSSL symbols are now exposed on Windows platforms. (Alex Hultman) #7983 and #7576
* child_process, cluster: Forked child processes and cluster workers now support stdio configuration. (Colin Ihrig) #7811 and #7838
* fs: fs.ReadStream now exposes the number of bytes it has read so far. (Linus Unnebäck) #7942
* repl: The REPL now supports editor mode. (Prince J Wesley) #7275
* util: inspect() can now be configured globally using util.inspect.defaultOptions. (Roman Reiss) #8013

Refs: #8020
PR-URL: #8070
@cjihrig
Copy link
Contributor Author

cjihrig commented Aug 11, 2016

Moving this to the actual PR (#8070).

@cjihrig cjihrig closed this as completed Aug 11, 2016
cjihrig added a commit that referenced this issue Aug 11, 2016
Notable changes:

* build: zlib symbols and additional OpenSSL symbols are now exposed on Windows platforms. (Alex Hultman) #7983 and #7576
* child_process, cluster: Forked child processes and cluster workers now support stdio configuration. (Colin Ihrig) #7811 and #7838
* child_process: argv[0] can now be set to arbitrary values in spawned processes. (Pat Pannuto) #7696
* fs: fs.ReadStream now exposes the number of bytes it has read so far. (Linus Unnebäck) #7942
* repl: The REPL now supports editor mode. (Prince J Wesley) #7275
* util: inspect() can now be configured globally using util.inspect.defaultOptions. (Roman Reiss) #8013

Refs: #8020
PR-URL: #8070
cjihrig added a commit that referenced this issue Aug 15, 2016
Notable changes:

* build: zlib symbols and additional OpenSSL symbols are now exposed on Windows platforms. (Alex Hultman) #7983 and #7576
* child_process, cluster: Forked child processes and cluster workers now support stdio configuration. (Colin Ihrig) #7811 and #7838
* child_process: argv[0] can now be set to arbitrary values in spawned processes. (Pat Pannuto) #7696
* fs: fs.ReadStream now exposes the number of bytes it has read so far. (Linus Unnebäck) #7942
* repl: The REPL now supports editor mode. (Prince J Wesley) #7275
* util: inspect() can now be configured globally using util.inspect.defaultOptions. (Roman Reiss) #8013

Refs: #8020
PR-URL: #8070
cjihrig added a commit to cjihrig/node that referenced this issue Aug 16, 2016
Notable changes:

* build: zlib symbols and additional OpenSSL symbols are now exposed on Windows platforms. (Alex Hultman) nodejs#7983 and nodejs#7576
* child_process, cluster: Forked child processes and cluster workers now support stdio configuration. (Colin Ihrig) nodejs#7811 and nodejs#7838
* child_process: argv[0] can now be set to arbitrary values in spawned processes. (Pat Pannuto) nodejs#7696
* fs: fs.ReadStream now exposes the number of bytes it has read so far. (Linus Unnebäck) nodejs#7942
* repl: The REPL now supports editor mode. (Prince J Wesley) nodejs#7275
* util: inspect() can now be configured globally using util.inspect.defaultOptions. (Roman Reiss) nodejs#8013

Refs: nodejs#8020
PR-URL: nodejs#8070
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

No branches or pull requests

10 participants