Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove internal headers from addons #7947

Closed
wants to merge 1 commit into from

Conversation

gibfahn
Copy link
Member

@gibfahn gibfahn commented Aug 2, 2016

Checklist
  • make -j4 test-addons (UNIX), or vcbuild test-addons nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test, addons

Description of change

Continuation of 3c85f4e (in #6734). Make the addons more like userland ones.

@bnoordhuis not sure whether util.h and util-inl.h were being used in openssl-binding/binding.cc. The asserts in test.js still seem to pass.

EDIT: CI is green

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 2, 2016
@mscdex
Copy link
Contributor

mscdex commented Aug 2, 2016

@mscdex mscdex added the addons Issues and PRs related to native addons. label Aug 2, 2016
@gibfahn
Copy link
Member Author

gibfahn commented Aug 2, 2016

@mscdex Whoops, looks like I removed one line too many. If you could rerun the CI that'd be great.

@mscdex
Copy link
Contributor

mscdex commented Aug 2, 2016

CI again: https://ci.nodejs.org/job/node-test-pull-request/3502/

@cjihrig
Copy link
Contributor

cjihrig commented Aug 2, 2016

The last CI run was green everywhere but FreeBSD. Trying again: https://ci.nodejs.org/job/node-test-pull-request/3505/

LGTM if it comes back green. I guess util.h and util-inl.h weren't being used.

@gibfahn
Copy link
Member Author

gibfahn commented Aug 2, 2016

FreeBSD failure was this (probaby unrelated):

not ok 229 parallel/test-dgram-send-empty-array
# /usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/parallel/test-dgram-send-empty-array.js:15
#   throw new Error('Timeout');
#   ^
# 
# Error: Timeout
#     at Timeout._onTimeout (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/parallel/test-dgram-send-empty-array.js:15:9)
#     at tryOnTimeout (timers.js:232:11)
#     at Timer.listOnTimeout (timers.js:202:5)
  ---
  duration_ms: 0.484
  ...

@gibfahn
Copy link
Member Author

gibfahn commented Aug 3, 2016

3rd CI came back green, thanks @cjihrig

@gibfahn
Copy link
Member Author

gibfahn commented Aug 3, 2016

@bnoordhuis I'd appreciate a review from you as I'm changing your code.

@bnoordhuis
Copy link
Member

LGTM

1 similar comment
@jasnell
Copy link
Member

jasnell commented Aug 3, 2016

LGTM

jasnell pushed a commit that referenced this pull request Aug 5, 2016
PR-URL: #7947
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Aug 5, 2016

Landed in 9a0d26f! Thank you!

@jasnell
Copy link
Member

jasnell commented Aug 8, 2016

Whoops, forgot to close when landing...

@jasnell jasnell closed this Aug 8, 2016
@cjihrig cjihrig mentioned this pull request Aug 8, 2016
cjihrig pushed a commit that referenced this pull request Aug 10, 2016
PR-URL: #7947
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@cjihrig cjihrig mentioned this pull request Aug 11, 2016
@MylesBorins
Copy link
Contributor

neither of these files live in v4.x, adding dont land

@gibfahn gibfahn deleted the pr-openssl-addon branch December 16, 2016 11:15
MylesBorins pushed a commit that referenced this pull request Nov 2, 2017
Backport-PR-URL: #16550
PR-URL: #7947
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2017
@refack refack mentioned this pull request Oct 18, 2018
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addons Issues and PRs related to native addons. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants