Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add added: information for cluster #7640

Closed
wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Jul 9, 2016

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Ref: #6578

@addaleax addaleax added cluster Issues and PRs related to the cluster subsystem. doc Issues and PRs related to the documentations. labels Jul 9, 2016
@addaleax
Copy link
Member Author

/cc @nodejs/documentation

@jasnell
Copy link
Member

jasnell commented Aug 8, 2016

LGTM.
ping @cjihrig @trevnorris

@cjihrig
Copy link
Contributor

cjihrig commented Aug 8, 2016

A lot of these are before my time working on core. I'll offer a rubber stamp LGTM, and we can fix any of these that may be wrong at a later time.

jasnell pushed a commit that referenced this pull request Aug 9, 2016
Ref: #6578
PR-URL: #7640
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@jasnell
Copy link
Member

jasnell commented Aug 9, 2016

Landed in c628982

@jasnell jasnell closed this Aug 9, 2016
@cjihrig cjihrig mentioned this pull request Aug 10, 2016
cjihrig pushed a commit that referenced this pull request Aug 10, 2016
Ref: #6578
PR-URL: #7640
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@cjihrig cjihrig mentioned this pull request Aug 11, 2016
@MylesBorins
Copy link
Contributor

not landing cleanly @addaleax manual backport?

@addaleax addaleax deleted the add-added-cluster branch September 30, 2016 20:13
addaleax added a commit to addaleax/node that referenced this pull request Sep 30, 2016
Ref: nodejs#6578
PR-URL: nodejs#7640
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
Ref: #6578
PR-URL: #7640
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
Ref: #6578
PR-URL: #7640
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
Ref: #6578
PR-URL: #7640
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
Ref: #6578
PR-URL: #7640
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
Ref: #6578
PR-URL: #7640
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cluster Issues and PRs related to the cluster subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants