v6.x backport of 'latin1' encoding #8022
Conversation
When node began using the OneByte API (f150d56) it also switched to officially supporting ISO-8859-1. Though at the time no new encoding string was introduced. Introduce the new encoding string 'latin1' to be more explicit. The previous 'binary' and documented as an alias to 'latin1'. While many tests have switched to use 'latin1', there are still plenty that do both 'binary' and 'latin1' checks side-by-side to ensure there is no regression. PR-URL: nodejs#7111 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
A message stuck around in the native API warning users to not use 'raw' encoding. Followed by an abort(). This is no longer necessary since all other signs of 'raw' encoding have been removed. PR-URL: nodejs#7111 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
A missing 'break' statement unintentionally allowed "linary" and "luffer" as alternatives for "binary" and "buffer". Regression introduced in commit 54cc721 ("buffer: introduce latin1 encoding term".) PR-URL: nodejs#7262 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trevor Norris <[email protected]>
Make BINARY an alias for LATIN1 rather than a distinct enum value. PR-URL: nodejs#7284 Refs: nodejs#7262 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
addaleax
added
buffer
nodejs-github-bot
added
c++
|
Looks like there were some Windows build issues. @addaleax are you particularly anxious to get this into v6.4.0? |
|
@cjihrig It wouldn’t be the end of the world if it doesn’t make it. 😉 Though, I think I can speak for me and at least @trevnorris in that we both would really like to see it landed in v6 at some point, because we see quite the value in moving away from |
|
I think I have seen these Windows errors before in an unrelated context, so running CI again: https://ci.nodejs.org/job/node-test-commit/4477/ |
|
|
||
| * `'hex'` - Encode each byte as two hexadecimal characters. | ||
|
|
||
| _Note_: Today's browsers follow the [WHATWG | ||
| spec](https://encoding.spec.whatwg.org/) that aliases both `latin1` and | ||
| `iso-8859-1` to `win-1252`. Meaning, while doing something like `http.get()`, |
There was a problem hiding this comment.
quick note, cc1318b contains documentation changes for these entries. not sure if it's worth while to also back port those.
There was a problem hiding this comment.
i'm not worried about adding them in this PR. i don't even feel particularly strong about landing the doc changes. just thought it be useful to bring it up.
|
One comment/question. LGTM. |
|
These commits should have been The old one probably should have been |
|
@Fishrock123 Thanks for the comments, I wasn’t aware of that :/ |
Backport of #7111, half of #7262 (the other half already landed) and #7284.
/cc @nodejs/buffer
CI: https://ci.nodejs.org/job/node-test-commit/4461/