assert: fix deepEqual/deepStrictEqual on equivalent typed arrays

The typed array's underlying ArrayBuffer is used in `Buffer.from`. Let's respect it's .byteOffset or .byteLength (i.e. position within the parent ArrayBuffer). Fixes: #8001 PR-URL: #8002 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
nodejs · Aug 9, 2016 · 387ab62 · 387ab62
1 parent bb3b4d7
commit 387ab62
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/lib/assert.js b/lib/assert.js
@@ -180,8 +180,12 @@ function _deepEqual(actual, expected, strict, memos) {
              pToString(actual) === pToString(expected) &&
              !(actual instanceof Float32Array ||
                actual instanceof Float64Array)) {
-    return compare(Buffer.from(actual.buffer),
-                   Buffer.from(expected.buffer)) === 0;
+    return compare(Buffer.from(actual.buffer,
+                               actual.byteOffset,
+                               actual.byteLength),
+                   Buffer.from(expected.buffer,
+                               expected.byteOffset,
+                               expected.byteLength)) === 0;
 
   // 7.5 For all other Object pairs, including Array objects, equivalence is
   // determined by having the same number of owned properties (as verified