doc: remove platform assumption from CONTRIBUTING #7783
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we maybe include the windows commands here as well? |
|
Yes it would be useful to directly say the windows command here. You should be able to find it at https://github.com/nodejs/node/blob/master/BUILDING.md#windows |
|
@BethGriggs Also, it looks like GitHub doesn't know your email (for linking to your profile), just FYI if that is not intentional. |
| ```text | ||
| $ ./configure && make -j8 test | ||
| ``` | ||
| (See the [BUILDING.md](./BUILDING.md) for other platforms.) |
There was a problem hiding this comment.
Maybe See BUILDING.md for more details would be better?
BethGriggs
force-pushed
the
issue-7646-contributing-branch
branch
from
cb9f471
to
66a6c2d
Compare
|
Updated PTAL |
|
LGTM |
|
Could you wrap the lines at 80 characters, and maybe use the full URL to the issue in the LGTM with that, and thanks for the PR. |
- Specify that the ‘make test’ commands are Unix/OS X specific. - Link to BUILDING.md for other platform commands. Fixes: nodejs#7646
BethGriggs
force-pushed
the
issue-7646-contributing-branch
branch
from
66a6c2d
to
3e59970
Compare
|
updated, still LGTY? |
|
Thanks and yes, I’m going to land this later today if there are no objections/nobody beats me to it. |
|
Landed in 868638b, thanks for the contribution! :) |
addaleax
pushed a commit
that referenced
this pull request
Jul 27, 2016
- Specify that the ‘make test’ commands are Unix/OS X specific. - Link to BUILDING.md for other platform commands. Fixes: #7646 PR-URL: #7783 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
cjihrig
pushed a commit
that referenced
this pull request
Aug 10, 2016
- Specify that the ‘make test’ commands are Unix/OS X specific. - Link to BUILDING.md for other platform commands. Fixes: #7646 PR-URL: #7783 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Sep 9, 2016
- Specify that the ‘make test’ commands are Unix/OS X specific. - Link to BUILDING.md for other platform commands. Fixes: #7646 PR-URL: #7783 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 28, 2016
- Specify that the ‘make test’ commands are Unix/OS X specific. - Link to BUILDING.md for other platform commands. Fixes: #7646 PR-URL: #7783 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Oct 18, 2016
- Specify that the ‘make test’ commands are Unix/OS X specific. - Link to BUILDING.md for other platform commands. Fixes: #7646 PR-URL: #7783 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 26, 2016
- Specify that the ‘make test’ commands are Unix/OS X specific. - Link to BUILDING.md for other platform commands. Fixes: #7646 PR-URL: #7783 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
Fixes: #7646