repl: Use displayErrors for SyntaxError #7589
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
seems good to me, although I'm wondering if there was a good reason we don't do this already |
|
Is the stack-trace ever going to be useful here? |
|
@Fishrock123 May be needed for |
|
@Fishrock123 Without stack trace node 🙈 ₹ git:(upstream ⚡ display-error-repl) ./node
> var 4;
var 4;
^
SyntaxError: Unexpected number
> require('/Users/princejohnwesley/Downloads/test.js')
/Users/princejohnwesley/Downloads/test.js:3
var 4;
^
SyntaxError: Unexpected number
> .load /Users/princejohnwesley/Downloads/test.js
> var 4;
var 4;
^
SyntaxError: Unexpected number
> |
```js
node 🙈 ₹ git:(upstream ⚡ display-error-repl) ./node
> var 4;
var 4;
^
SyntaxError: Unexpected number
at Object.exports.createScript (vm.js:47:10)
at REPLServer.defaultEval (repl.js:255:25)
at bound (domain.js:280:14)
at REPLServer.runBound [as eval] (domain.js:293:12)
at REPLServer.<anonymous> (repl.js:495:10)
at emitOne (events.js:101:20)
at REPLServer.emit (events.js:188:7)
at REPLServer.Interface._onLine (readline.js:231:10)
at REPLServer.Interface._line (readline.js:573:8)
at REPLServer.Interface._ttyWrite (readline.js:850:14)
>
```
Trott
added
the
semver-minor
princejwesley
force-pushed
the
display-error-repl
branch
from
dd6f718
to
1ae1c38
Compare
|
LGTM if CI is green |
|
Landed in 68ac0d0d |
princejwesley
added a commit
that referenced
this pull request
Jul 27, 2016
```js
node 🙈 ₹ git:(upstream ⚡ display-error-repl) ./node
> var 4;
var 4;
^
SyntaxError: Unexpected number
>
```
PR-URL: #7589
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
cjihrig
pushed a commit
that referenced
this pull request
Aug 10, 2016
```js
node 🙈 ₹ git:(upstream ⚡ display-error-repl) ./node
> var 4;
var 4;
^
SyntaxError: Unexpected number
>
```
PR-URL: #7589
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
Conflicts:
test/parallel/test-repl.js
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
repl
Description of change
Enabling
vm'sdisplayErrorsoption to display code error with caret(^) sign