Backporting to v6.x-staging #216
Comments
|
@MylesBorins there were a couple of commits that I wasn't sure about, please review:
|
|
This is done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Comment if you start or stop backporting.
Working from this gist
List generated from this command:
branch-diff v6.x-staging upstream/v7.x --exclude-label semver-major,semver-minor,dont-land-on-v6.x,backport-requested-v6.x,backported-to-v6.x,baking-for-lts --reverse --filter-release RawLabels information in nodejs/node#12431
Commits to backport:
Ticked means looked at
f5a702e763] - stream: Fixes missing 'unpipe' event (Christopher Luke) #11876 => v7.x backport cherry-picks cleanly, PR depends on test: add common.mustNotCall() node#11152592db37e2f] - test: move test to sequential for reliability (Rich Trott) #12704 => should landc2c62874d4] - doc: fix formatting of TOC (Refael Ackermann) #12731 => should land7af2e7940c] - test: fix permanent deoptimizations (Brian White) #12456 => asked on PR1ac331b29f] - readline: fix permanent deoptimizations (Brian White) #124564a082889bd] - net: fix permanent deoptimizations (Brian White) #12456b573f77b28] - process: fix permanent deoptimizations (Brian White) #12456933b6b57d6] - cluster: fix permanent deoptimizations (Brian White) #1245684484b7063] - fs: fix permanent deoptimizations (Brian White) #124567d0adc6d26] - stream: fix permanent deoptimizations (Brian White) #12456caf6506f9f] - build: add target for checking for perm deopts (Brian White) #124569da719ab32] - test: fix test filenames (Brian White) #12456cd54208463] - process: cast promise rejection reason to string (Cameron Little) #11640 => asked on PRd78adccc08] - test: support multiple warnings in checkWarning (Cameron Little) #11640f60a2e9527] - doc: fixup the collaborators list (Alexey Orlenko) #12750 => landed819c131f58] - test: improve test-tcp-wrap-listen (alohaglenn) #12599 => conflicts, could be backported90bba9fd3e] - test,doc: documentcrashOnUnhandledRejection()(Anna Henningsen) #12699 => dont land, docs a non-existent function224fd3af97] - benchmark: terminate child process on Windows (Rich Trott) #12658360efe48bc] - doc: fix examples in repl.md (Vse Mozhet Byt) #12684395380a136] - doc: add Added-in metadata for WHATWG URL (Timothy Gu) #12683fc96d1a573] - doc: document url.domainTo* methods separately (Timothy Gu) #1268379dff99428] - test: remove eslint comments from test-util.js (cjihrig) #12669dd1dced4c1] - test: remove eslint comments (cjihrig) #126693e9e6afd8a] - test: use common.mustCall in test-https-strict (weewey) #1266875e053be39] - test: cleanup test-util-inherits.js (RobotMermaid) #12602212475b451] - build: use do_not_edit variable where possible (Ruslan Bekenev) #12610745dea994e] - test: use common.js to check platform (Ruslan Bekenev) #12629d154aafe18] - deps: remove **/node_modules/form-data/README.md (Jeremiah Senkpiel) #126438e6d4402a0] - test: improve test-process-kill-pid (alohaglenn) #12588660e58c7eb] - test: improved type checking with regex (coreybeaumont) #12591e36a256c6b] - test: cleanup test-fs-watch.js (RobotMermaid) #12595d15b1c4446] - test: add mustCall in test-timers-clearImmediate (Zahidul Islam) #1259846a7c297d3] - tools: use no-useless-concat ESLint rule (Vse Mozhet Byt) #1261345facc8822] - doc: fix an unclear wording in readline.md (Vse Mozhet Byt) #12605da01ff7507] - src: remove invalid comment (cjihrig) #126451316c77b79] - doc: improve randomfill and fix broken link (Sakthipriyan Vairamani (thefourtheye)) #12541744ed9477b] - src: expose V8's IsNativeError() in util bindings (cjihrig) #1254651eafe8f3c] - meta: update authors list (Aashil Patel) #11533258eeaa519] - tools: enable no-useless-return eslint rule (cjihrig) #12577313b205834] - doc: prepare js code for eslint-plugin-markdown (Vse Mozhet Byt) #12563cbdf9a90d1] - lib: fix typo in comments in module.js (WORMSS) #12528989d344ba9] - test: use block scoped variable names (Neehar Venugopal) #12544b82e0769fe] - test: dynamic port in cluster eaddrinuse (Sebastian Plesciuc) #125478ae5afe2d2] - test: dynamic port in cluster ipc throw (Sebastian Plesciuc) #12571539ffaef83] - url: improve descriptiveness of identifier (Rich Trott) #1257980ceb04644] - test: replace assertion error check with regex (thelady) #126032021ea1c12] - test: refactored context type err message to regex (Muhsin Abdul-Musawwir) #125961a4bf431fc] - test: improve test-process-chdir (vperezma) #1258914e93f6369] - test: dynamic port in parallel cluster tests (Sebastian Plesciuc) #12584d10eb83325] - test: remove flaky designation for test on AIX (Rich Trott) #12564200e899cc4] - tools: addroot: truein main .eslintrc.yaml (Vse Mozhet Byt) #12570b52f77df43] - doc: fix typo in doc/api/process.md (morrme) #1261208951a1307] - src: replace IsConstructCalls with lambda (Daniel Bevenius) #12533f0b5afe721] - test: dynamic port in cluster worker dgram (Sebastian Plesciuc) #1248747b39928d5] - doc: make commit guidelines easier to reference (Benjamin Fleischer) #11732661ff6dae3] - test: move test-debugger-repeat-last to sequential (kumarrishav) #12470184941ef0b] - src: remove TODO about uv errno removal (Daniel Bevenius) #125364276c213f2] - doc: add suggestion to use --3way (Michael Dawson) #125100fb69de277] - test: use duplex streams in duplex stream test (cjihrig) #1251478ac637fe2] - build: fix case in lib names (Refael Ackermann) #12522f84a5e19b7] - test: use JSON.stringify to trigger stack overflow (Yang Guo) #12481e77f1e2177] - v8: fix stack overflow in recursive method (Ben Noordhuis) #1246096b2faa79b] - test: fix parallel/test-setproctitle.js on alpine (David Cai) #12413e3ccc3109c] - test: set benchmark-child-process flaky on windows (Rich Trott) #125613703fc6bbe] - doc: update link to Code of Conduct (Alex Autem) #12552434873d24b] - doc: fix typo in fs.watch() description (Ivo von Putzer Reibegg) #12550eb78722922] - doc: add lucamaraschi to collaborators (Luca Maraschi) #12538b09bf51cdf] - repl: support hidden history file on Windows (Bartosz Sosnowski) #122077d87edc1ba] - benchmark: add benchmark for string concatenations (Vse Mozhet Byt) #1245508ba9d437c] - benchmark: fix CLI arguments check in common.js (Vse Mozhet Byt) #1242937261319d6] - test: minimize time for child_process benchmark (Rich Trott) #12518eac0d70429] - test: console.log removed from test-net-localport (Faiz Halde) #12483a213320745] - test: dynamic port in cluster worker disconnect (Sebastian Plesciuc) #12457ddc35282c0] - test: remove uses of common.PORT in test-tls-client tests (Ahmed Taj elsir) #1246113441eb1e1] - tools: add table parsing capability to the doctool (Roman Reiss) #95329250f02d12] - doc: clarify the callback arguments of dns.resolve (Roman Reiss) #9532f48d06c042] - test: dynamic port in cluster worker send (Sebastian Plesciuc) #12472a75fbe024a] - test: increase coverage for buffer.js (Rich Trott) #1247638278db9c7] - doc: unify spaces in a querystring.md code example (Vse Mozhet Byt) #12465e919941a21] - test: add test for child_process benchmark (Joyee Cheung) #123268e3d54aca5] - test: complete coverage of lib/child_process.js (cjihrig) #12367922c457365] - test: buffer should always be stringified (Luca Maraschi) #12355db585c9b4d] - crypto: update root certificates (Ben Noordhuis) #124023c8e366c2a] - tools: update certdata.txt (Ben Noordhuis) #124026003958872] - tools: add compile_commands.json gyp generator (Ben Noordhuis) #1245083a28eeff8] - tools: update gyp to eb296f6 (Refael Ackermann) #124503fc25dce82] - doc: run tests before landing changes (Rich Trott) #12416af0067cc5e] - doc: avoid colloquialism (Rich Trott) #12417611c23cca6] - test: use dynamic port in test-cluster-bind-twice (Rich Trott) #12418a7e13e012d] - test: remove common.PORT from test-cluster*.js (Tarun Batra) #12441d0ba631efa] - doc: fix encoding string in buffer example (MapleUncle) #12482a34cccceaa] - test: use dynamic port in 3 test-cluster-worker tests (Sebastian Plesciuc) #124433d8878c592] - doc: correct git fix whitespace command (Mateusz Konieczny) #12445320b80b792] - test: add --use-bundled-ca to tls-cnnic-whitelist (Daniel Bevenius) #123948ac387be3e] - net: refactor onSlaveClose in Server.close (Claudio Rodriguez) #12334440f4d4eef] - Revert "benchmark: fix CLI arguments check in common.js" (James M Snell) #12474b7aeed7a7e] - benchmark: improve cli error message (Brian White) #12421e6be4b951a] - build: make linter targets silent (Sakthipriyan Vairamani (thefourtheye)) #12423917534d541] - benchmark: fix CLI arguments check in common.js (Vse Mozhet Byt) #12429077187e9a8] - doc: s/origin/upstream/ collaborator guide (Anna Henningsen) #124363c59d87164] - test: add crypto check to crypto-lazy-transform (Daniel Bevenius) #124245a2d358f2e] - doc: remove inspector experimental warning (cjihrig) #124082e3813f730] - meta: move the Code of Conduct to TSC repository (James M Snell) #12147320e72b32d] - doc: add missing ) in CONTRIBUTING.md (Mateusz Konieczny) #124440f290f2414] - test: enable setuid/setgid test (Rich Trott) #124034570d9853c] - doc: add guide for backporting prs (Evan Lucas) #11099d7d1e923ad] - doc: update link for landing PRs (Rich Trott) #124154a19062294] - test: replace [].join() with ''.repeat() (Jackson Tian) #123054ce58bd56a] - doc: add DavidCai1993 to collaborators (David Cai) #12435984232cc2a] - doc: fix typo in streams.md (John Paul Bamberg) #12428060b63e91f] - doc: add jkrems to collaborators (Jan Krems) #124275ed9ed3317] - test: remove common.PORT from test-cluster-basic (Rich Trott) #12377e4b2f61fb5] - buffer: use slightly faster NaN check (Brian White) #122866a45be2fa6] - doc: path functions ignore trailing slashes (Tobias Nießen) #121810661fdf781] - test: add test-benchmark-crypto (Rich Trott) #123476998e8026b] - os,vm: fix segfaults and CHECK failure (Tobias Nießen) #1237192e239d001] - doc: add info about serializable types (Shubheksha Jalan) #123135c57feaa27] - doc: fix formatting in onboarding-extras (Rich Trott) #12350092c7239ee] - test: add hasCrypto check to test-debug-usage (Daniel Bevenius) #12357ebeb6c0a26] - buffer: optimize write() (Brian White) #123614d9e6718f8] - build: run cpplint even if jslint failed (Ruslan Bekenev) #12276e2d66ab809] - doc: response.write ignores body in some cases (Ruslan Bekenev) #12314d1e1832398] - doc: add AnnaMag to collaborators (AnnaMag) #124148ac8e50a58] - crypto: make LazyTransform compabile with Streams1 (Matteo Collina) #12380d58fa7873f] - benchmark,windows: TCP.readStart() meaningful only after completion (Refael Ackermann) #12258f3db9a6437] - doc: limit lines to 80 cols in internal README (Evan Lucas) #12358aff0cfc2d7] - test: improve punycode coverage to check surrogate pair (Nao YONASHIRO) #12354ed130168ed] - doc: add single arg scenario for util.format (Tarun Batra) #12374The text was updated successfully, but these errors were encountered: