Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: remove common.PORT from cluster worker disconnect, exit and kill #12443

Closed
wants to merge 1 commit into from
Closed

tests: remove common.PORT from cluster worker disconnect, exit and kill #12443

wants to merge 1 commit into from

Conversation

sebastianplesciuc
Copy link

Migrate the following test files away from common.PORT:

  • test-cluster-worker-disconnect.js
  • test-cluster-worker-exit.js
  • test-cluster-worker-kill.js

Ref: #12376

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 16, 2017
@sebastianplesciuc sebastianplesciuc changed the title Common port cluster worker Migrate cluster worker tests from common.PORT Apr 16, 2017
@sebastianplesciuc
Copy link
Author

First contribution. Baby steps, I guess.

@mscdex mscdex added the cluster Issues and PRs related to the cluster subsystem. label Apr 16, 2017
@mscdex
Copy link
Contributor

mscdex commented Apr 16, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/7428/

@Trott Trott mentioned this pull request Apr 16, 2017
Closed
64 tasks
@benjamingr
Copy link
Member

CI Green

gibfahn
gibfahn approved these changes Apr 16, 2017
View reviewed changes
Copy link
Member

@gibfahn gibfahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could just be one commit, as it's one change made to three files.

LGTM anyway

santigimeno
santigimeno approved these changes Apr 16, 2017
View reviewed changes
Copy link
Member

@santigimeno santigimeno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. +1 to squash the commits

@sebastianplesciuc
Copy link
Author

Let me know if I should squash them or not. It might need another CI build.

@santigimeno
Copy link
Member

Let me know if I should squash them or not. It might need another CI build.

That would be great. I can run the CI afterwards. Thanks!

test: use dynamic port in 3 test-cluster-worker tests
35480ae 
Remove common.PORT from test-cluster-worker-disconnect,
test-cluster-worker-exit and test-cluster-worker-kill to
eliminate the possibility that a dynamic port used in
another test will collide with common.PORT.

Refs: #12376
@sebastianplesciuc
Copy link
Author

Squashed. Thanks!

@santigimeno
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/7437/

@sebastianplesciuc sebastianplesciuc changed the title Migrate cluster worker tests from common.PORT tests: remove common.PORT from cluster worker disconnect, exit and kill Apr 17, 2017
jasnell pushed a commit that referenced this pull request Apr 18, 2017
@jasnell
test: use dynamic port in 3 test-cluster-worker tests
2519757 
Remove common.PORT from test-cluster-worker-disconnect,
test-cluster-worker-exit and test-cluster-worker-kill to
eliminate the possibility that a dynamic port used in
another test will collide with common.PORT.

PR-URL: #12443
Ref: #12376
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Apr 18, 2017

Landed in 2519757

@jasnell jasnell closed this Apr 18, 2017
evanlucas pushed a commit that referenced this pull request Apr 25, 2017
@evanlucas
test: use dynamic port in 3 test-cluster-worker tests
38a5c1b 
Remove common.PORT from test-cluster-worker-disconnect,
test-cluster-worker-exit and test-cluster-worker-kill to
eliminate the possibility that a dynamic port used in
another test will collide with common.PORT.

PR-URL: #12443
Ref: #12376
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@evanlucas evanlucas mentioned this pull request May 1, 2017
Merged
evanlucas pushed a commit that referenced this pull request May 1, 2017
@evanlucas
test: use dynamic port in 3 test-cluster-worker tests
f0f7c1c 
Remove common.PORT from test-cluster-worker-disconnect,
test-cluster-worker-exit and test-cluster-worker-kill to
eliminate the possibility that a dynamic port used in
another test will collide with common.PORT.

PR-URL: #12443
Ref: #12376
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
evanlucas pushed a commit that referenced this pull request May 2, 2017
@evanlucas
test: use dynamic port in 3 test-cluster-worker tests
a34cccc 
Remove common.PORT from test-cluster-worker-disconnect,
test-cluster-worker-exit and test-cluster-worker-kill to
eliminate the possibility that a dynamic port used in
another test will collide with common.PORT.

PR-URL: #12443
Ref: #12376
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
gibfahn pushed a commit that referenced this pull request May 16, 2017
@gibfahn
test: use dynamic port in 3 test-cluster-worker tests
a62033c 
Remove common.PORT from test-cluster-worker-disconnect,
test-cluster-worker-exit and test-cluster-worker-kill to
eliminate the possibility that a dynamic port used in
another test will collide with common.PORT.

PR-URL: #12443
Ref: #12376
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 18, 2017
@MylesBorins
test: use dynamic port in 3 test-cluster-worker tests
384fa17 
Remove common.PORT from test-cluster-worker-disconnect,
test-cluster-worker-exit and test-cluster-worker-kill to
eliminate the possibility that a dynamic port used in
another test will collide with common.PORT.

PR-URL: #12443
Ref: #12376
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request May 23, 2017
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@andrew749
test: use dynamic port in 3 test-cluster-worker tests
7a87db6 
Remove common.PORT from test-cluster-worker-disconnect,
test-cluster-worker-exit and test-cluster-worker-kill to
eliminate the possibility that a dynamic port used in
another test will collide with common.PORT.

PR-URL: nodejs/node#12443
Ref: nodejs/node#12376
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@leonardoadame leonardoadame mentioned this pull request Nov 30, 2023
Open
@aliscco aliscco mentioned this pull request Dec 1, 2023
Open
This was referenced Dec 1, 2023
Open
Open
Open
Open
@aliscco aliscco mentioned this pull request Dec 2, 2023
Open
@leonardoadame leonardoadame mentioned this pull request Dec 3, 2023
Open
This was referenced May 14, 2024
Open
Open
@aliscco aliscco mentioned this pull request May 15, 2024
Open
This was referenced May 16, 2024
Open
Open
@aliscco aliscco mentioned this pull request May 17, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Oct 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@cjihrig cjihrig cjihrig approved these changes

@benjamingr benjamingr benjamingr approved these changes

@santigimeno santigimeno santigimeno approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
cluster Issues and PRs related to the cluster subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@sebastianplesciuc @mscdex @benjamingr @santigimeno @jasnell @cjihrig @gibfahn @nodejs-github-bot