test: use duplex streams in duplex stream test #12514
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test-stream-duplex.js uses transform streams instead of the duplex stream base class. This leads to some code not being covered in the Duplex constructor.
jasnell
approved these changes
Apr 19, 2017
hiroppy
approved these changes
Apr 19, 2017
lpinca
approved these changes
Apr 20, 2017
DavidCai1111
approved these changes
Apr 20, 2017
danbev
approved these changes
Apr 20, 2017
|
Landed in c083a20 |
DavidCai1111
pushed a commit
that referenced
this pull request
Apr 21, 2017
test-stream-duplex.js uses transform streams instead of the duplex stream base class. This leads to some code not being covered in the Duplex constructor. PR-URL: #12514 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: David Cai <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
evanlucas
pushed a commit
that referenced
this pull request
Apr 25, 2017
test-stream-duplex.js uses transform streams instead of the duplex stream base class. This leads to some code not being covered in the Duplex constructor. PR-URL: #12514 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: David Cai <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Merged
evanlucas
pushed a commit
that referenced
this pull request
May 1, 2017
test-stream-duplex.js uses transform streams instead of the duplex stream base class. This leads to some code not being covered in the Duplex constructor. PR-URL: #12514 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: David Cai <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
evanlucas
pushed a commit
that referenced
this pull request
May 2, 2017
test-stream-duplex.js uses transform streams instead of the duplex stream base class. This leads to some code not being covered in the Duplex constructor. PR-URL: #12514 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: David Cai <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
|
Landed on v6.x, LMK if it shouldn't have. |
gibfahn
pushed a commit
that referenced
this pull request
May 16, 2017
test-stream-duplex.js uses transform streams instead of the duplex stream base class. This leads to some code not being covered in the Duplex constructor. PR-URL: #12514 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: David Cai <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
May 18, 2017
test-stream-duplex.js uses transform streams instead of the duplex stream base class. This leads to some code not being covered in the Duplex constructor. PR-URL: #12514 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: David Cai <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Merged
andrew749
pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
test-stream-duplex.js uses transform streams instead of the duplex stream base class. This leads to some code not being covered in the Duplex constructor. PR-URL: nodejs/node#12514 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: David Cai <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-stream-duplex.jsuses transform streams instead of the duplex stream base class. This leads to some code not being covered in theDuplexconstructor.This may lead to the equivalent code in the
Transformconstructor losing coverage. If that's the case, I'd prefer to fix that in a follow up PR.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test