doc: add single arg scenario for util.format #12374
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
|
Thank you for your contribution! Some nits:
|
Trott
approved these changes
Apr 12, 2017
refack
approved these changes
Apr 12, 2017
|
@vsemozhetbyt @Trott thanx for pointing that out. I'll make the changes right away. |
|
Done. |
evanlucas
suggested changes
Apr 12, 2017
doc/api/util.md
Outdated
| without any formatting. | ||
|
|
||
| ```js | ||
| util.format('%% %s') // '%% %s' |
There was a problem hiding this comment.
Can you include a semicolon here please? We try to follow the same coding style as the actual codebase.
There was a problem hiding this comment.
Makes sense. Changed that.
Set the expected outcome of `util.format('%%')` to be `%%`
instead of `%`.
Fixes: #12362
vsemozhetbyt
approved these changes
Apr 12, 2017
lpinca
approved these changes
Apr 13, 2017
cjihrig
approved these changes
Apr 13, 2017
|
We include the pull request URL under I've landed this in 78af0df - thanks for your contribution to Node :) |
benjamingr
pushed a commit
that referenced
this pull request
Apr 13, 2017
Set the expected outcome of `util.format('%%')` to be `%%`
instead of `%`.
PR-URL: #12374
Fixes: #12362
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
evanlucas
pushed a commit
that referenced
this pull request
Apr 25, 2017
Set the expected outcome of `util.format('%%')` to be `%%`
instead of `%`.
PR-URL: #12374
Fixes: #12362
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Merged
evanlucas
pushed a commit
that referenced
this pull request
May 1, 2017
Set the expected outcome of `util.format('%%')` to be `%%`
instead of `%`.
PR-URL: #12374
Fixes: #12362
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
evanlucas
pushed a commit
that referenced
this pull request
May 2, 2017
Set the expected outcome of `util.format('%%')` to be `%%`
instead of `%`.
PR-URL: #12374
Fixes: #12362
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
May 15, 2017
Set the expected outcome of `util.format('%%')` to be `%%`
instead of `%`.
PR-URL: #12374
Fixes: #12362
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
May 18, 2017
Set the expected outcome of `util.format('%%')` to be `%%`
instead of `%`.
PR-URL: #12374
Fixes: #12362
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Merged
andrew749
pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
Set the expected outcome of `util.format('%%')` to be `%%`
instead of `%`.
PR-URL: nodejs/node#12374
Fixes: nodejs/node#12362
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the expected outcome of
util.format('%%')to be%%instead of
%.Fixes: #12362
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc