Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve punycode coverage to check surrogate pair #12354

Closed
wants to merge 1 commit into from
Closed

test: improve punycode coverage to check surrogate pair #12354

wants to merge 1 commit into from

Conversation

orisano
Copy link
Contributor

@orisano orisano commented Apr 12, 2017 •
edited
Loading

This PR improves punycode coverage

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 12, 2017
@hiroppy hiroppy added the punycode Issues and PRs related to the punycode module bundled in Node.js. label Apr 12, 2017
@yosuke-furukawa
Copy link
Member

cc @nodejs/testing

@vsemozhetbyt
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/7344/

Trott
Trott approved these changes Apr 12, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jasnell pushed a commit that referenced this pull request Apr 13, 2017
@orisano @jasnell
test: improve punycode coverage to check surrogate pair
05a00a0 
PR-URL: #12354
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@jasnell
Copy link
Member

jasnell commented Apr 13, 2017

Landed in 05a00a0

@jasnell jasnell closed this Apr 13, 2017
evanlucas pushed a commit that referenced this pull request Apr 25, 2017
@orisano @evanlucas
test: improve punycode coverage to check surrogate pair
0d8f280 
PR-URL: #12354
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@evanlucas evanlucas mentioned this pull request May 1, 2017
Merged
evanlucas pushed a commit that referenced this pull request May 1, 2017
@orisano @evanlucas
test: improve punycode coverage to check surrogate pair
2597da1 
PR-URL: #12354
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
evanlucas pushed a commit that referenced this pull request May 2, 2017
@orisano @evanlucas
test: improve punycode coverage to check surrogate pair
aff0cfc 
PR-URL: #12354
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 15, 2017
@orisano @MylesBorins
test: improve punycode coverage to check surrogate pair
9baaff7 
PR-URL: #12354
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 18, 2017
@orisano @MylesBorins
test: improve punycode coverage to check surrogate pair
afac316 
PR-URL: #12354
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@MylesBorins MylesBorins mentioned this pull request May 23, 2017
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@orisano @andrew749
test: improve punycode coverage to check surrogate pair
1ff4134 
PR-URL: nodejs/node#12354
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
punycode Issues and PRs related to the punycode module bundled in Node.js. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@orisano @yosuke-furukawa @vsemozhetbyt @jasnell @Trott @cjihrig @MylesBorins @hiroppy @nodejs-github-bot