Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build, icu: fix case in lib names #12522

Closed
wants to merge 1 commit into from

Conversation

refack
Copy link
Contributor

@refack refack commented Apr 19, 2017

ninja on Windows chokes if libs are named .Lib (Capital L)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build,intl

ninja on Windows chokes if libs are named .Lib (Capital L)
@nodejs-github-bot nodejs-github-bot added i18n-api Issues and PRs related to the i18n implementation. tools Issues and PRs related to the tools directory. labels Apr 19, 2017
@refack refack requested a review from srl295 April 19, 2017 20:26
@refack refack self-assigned this Apr 19, 2017
@mscdex mscdex added build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. and removed tools Issues and PRs related to the tools directory. labels Apr 19, 2017
@jasnell
Copy link
Member

jasnell commented Apr 20, 2017

ping @srl295

refack added a commit that referenced this pull request Apr 21, 2017
ninja on Windows chokes if libs are named .Lib (Capital L)

PR-URL: #12522
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
@refack
Copy link
Contributor Author

refack commented Apr 21, 2017

@srl295 I assume you forgive me not waiting for your feedback on this tiny change..

Landed in: 14c6ae8

@refack refack closed this Apr 21, 2017
@refack refack removed the request for review from srl295 April 21, 2017 13:28
@refack
Copy link
Contributor Author

refack commented Apr 21, 2017

Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
And another +1 for ninja

evanlucas pushed a commit that referenced this pull request Apr 25, 2017
ninja on Windows chokes if libs are named .Lib (Capital L)

PR-URL: #12522
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
@evanlucas evanlucas mentioned this pull request May 1, 2017
evanlucas pushed a commit that referenced this pull request May 1, 2017
ninja on Windows chokes if libs are named .Lib (Capital L)

PR-URL: #12522
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
evanlucas pushed a commit that referenced this pull request May 2, 2017
ninja on Windows chokes if libs are named .Lib (Capital L)

PR-URL: #12522
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
@gibfahn
Copy link
Member

gibfahn commented May 16, 2017

Landed in v6.x, LMK if it shouldn't have.

gibfahn pushed a commit that referenced this pull request May 16, 2017
ninja on Windows chokes if libs are named .Lib (Capital L)

PR-URL: #12522
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 18, 2017
ninja on Windows chokes if libs are named .Lib (Capital L)

PR-URL: #12522
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
@MylesBorins MylesBorins mentioned this pull request May 23, 2017
@refack refack removed their assignment Jun 12, 2017
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
ninja on Windows chokes if libs are named .Lib (Capital L)

PR-URL: nodejs/node#12522
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. i18n-api Issues and PRs related to the i18n implementation. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants