NRG: Don't delete RAFT state if stream/consumer creation failed during shutdown#6061
Merged
derekcollison merged 1 commit intomainfrom Oct 31, 2024
Merged
Conversation
MauriceVanVeen
force-pushed
the
maurice/dont-delete-raft-state-during-shutdown
branch
from
a888677 to
5d5a329
Compare
MauriceVanVeen
changed the title
…g shutdown Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
MauriceVanVeen
force-pushed
the
maurice/dont-delete-raft-state-during-shutdown
branch
from
5d5a329 to
6d1ae91
Compare
derekcollison
deleted the
maurice/dont-delete-raft-state-during-shutdown
branch
neilalexander
added a commit
that referenced
this pull request
Nov 12, 2024
Includes the following: * Some tweaks to the NRG test helpers * #6055 * #6061 * #6065 * #6041 (but with `math/rand` instead of `math/rand/v2` due to an older Go version in CI for 2.10.x) * #6066 * #6067 * #6069 * #6075 * #6082 * #6087 * #6086 * #6088 * #6089 * #6092 * #6096 * #6098 * #6097 * #6105 * #6104 * #6106 * #6109 * #6111 * #6112 Signed-off-by: Neil Twigg <neil@nats.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Antithesis found a case where if a server was hard killed and would replay RAFT append entries during startup, if it would then be SIGTERM-ed while the RAFT recovery is running, the
acc.lookupStreamthat happens injs.processClusterCreateStreamresulted in aJetStream not enabled for accounterror. Which would then delete the RAFT state.There are also other errors that could pop up, so either way; if we're shutting down, don't delete the RAFT state.
Signed-off-by: Maurice van Veen github@mauricevanveen.com