Introduce a NumPendingMulti that uses a sublist for efficient selection.#6089
Merged
derekcollison merged 3 commits intomainfrom Nov 8, 2024
Merged
Introduce a NumPendingMulti that uses a sublist for efficient selection.#6089derekcollison merged 3 commits intomainfrom
derekcollison merged 3 commits intomainfrom
Conversation
Similar to the LoadNextMsgMulti for consumers with large number of filtered subjects. Also fixed a bug in normal NumPending for memstore. Signed-off-by: Derek Collison <derek@nats.io>
bruth
reviewed
Nov 8, 2024
Signed-off-by: Derek Collison <derek@nats.io>
bruth
approved these changes
Nov 8, 2024
Signed-off-by: Derek Collison <derek@nats.io>
neilalexander
added a commit
that referenced
this pull request
Nov 12, 2024
This optimises #6089 by ensuring that we don't over-walk either the sublist or the subject tree, instead only matching the subject tree on subjects for which the sublist expresses interest. Signed-off-by: Neil Twigg <neil@nats.io>
This was referenced Nov 12, 2024
neilalexander
pushed a commit
that referenced
this pull request
Nov 12, 2024
…on. (#6089) Consumers with many filtered subjects and large streams could suffer from slow creation times due to NumPending() being called for all filtered subjects. This improvement is similar to the LoadNextMsgMulti for consumers with large number of filtered subjects. Also fixed a bug in normal NumPending for memstore. Signed-off-by: Derek Collison <derek@nats.io> --------- Signed-off-by: Derek Collison <derek@nats.io>
neilalexander
added a commit
that referenced
this pull request
Nov 12, 2024
This optimises #6089 by ensuring that we don't over-walk either the sublist or the subject tree, instead only matching the subject tree on subjects for which the sublist expresses interest. Signed-off-by: Neil Twigg <neil@nats.io>
derekcollison
added a commit
that referenced
this pull request
Nov 12, 2024
This optimises #6089 by ensuring that we don't over-walk either the sublist or the subject tree, instead only matching the subject tree on subjects for which the sublist expresses interest. On my machine, in the `JetStreamConsumeWithFilters` benchmark with `-benchtime 1000x`, this reduces the CPU time taken by `NumPendingMulti` by 19.41 seconds, reducing it to only 0.06 seconds. Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander
added a commit
that referenced
this pull request
Nov 12, 2024
This optimises #6089 by ensuring that we don't over-walk either the sublist or the subject tree, instead only matching the subject tree on subjects for which the sublist expresses interest. Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander
added a commit
that referenced
this pull request
Nov 12, 2024
Includes the following: * Some tweaks to the NRG test helpers * #6055 * #6061 * #6065 * #6041 (but with `math/rand` instead of `math/rand/v2` due to an older Go version in CI for 2.10.x) * #6066 * #6067 * #6069 * #6075 * #6082 * #6087 * #6086 * #6088 * #6089 * #6092 * #6096 * #6098 * #6097 * #6105 * #6104 * #6106 * #6109 * #6111 * #6112 Signed-off-by: Neil Twigg <neil@nats.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consumers with many filtered subjects and large streams could suffer from slow creation times due to NumPending() being called for all filtered subjects.
This improvement is similar to the LoadNextMsgMulti for consumers with large number of filtered subjects.
Also fixed a bug in normal NumPending for memstore.
Signed-off-by: Derek Collison derek@nats.io