[FIXED] Ghost consumers after failed meta proposal#6088
Merged
derekcollison merged 1 commit intomainfrom Nov 7, 2024
Merged
Conversation
Member
derekcollison
left a comment
derekcollison
left a comment
There was a problem hiding this comment.
Should there be a test here that shows the change in behavior?
Member
|
This test seems to fail now on this PR - |
Member
Author
There was already |
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
MauriceVanVeen
force-pushed
the
maurice/fix-ghost-consumers
branch
from
51e0ff5 to
3c0afd2
Compare
Member
Author
At least in CI it seems, locally it passes consistently for me. |
neilalexander
added a commit
that referenced
this pull request
Nov 12, 2024
Includes the following: * Some tweaks to the NRG test helpers * #6055 * #6061 * #6065 * #6041 (but with `math/rand` instead of `math/rand/v2` due to an older Go version in CI for 2.10.x) * #6066 * #6067 * #6069 * #6075 * #6082 * #6087 * #6086 * #6088 * #6089 * #6092 * #6096 * #6098 * #6097 * #6105 * #6104 * #6106 * #6109 * #6111 * #6112 Signed-off-by: Neil Twigg <neil@nats.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the
cc.meta.Proposefails, for example due to restarts, thesa.consumers[ca.Name] = cawould have staged a consumer that will never be successfully added. That consumer would then become part of the next snapshot (for example during shutdown), which meant that that server had a ghost consumer it was unable to clean up.This does not fully solve the ghost consumers issue, but this should contribute to the final solution.
Signed-off-by: Maurice van Veen github@mauricevanveen.com