Merged
Conversation
derekcollison
approved these changes
Nov 4, 2024
Member
derekcollison
left a comment
derekcollison
left a comment
There was a problem hiding this comment.
LGTM
Ping me when off draft and I will merge.
Member
|
This test is flapping all of the sudden. @MauriceVanVeen can you take a look?
|
Member
Author
|
That test was already a flapper before, there are also other flappers, like We need to take a look at them either way, but just wanted to say it's not because of this PR/change. |
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
MauriceVanVeen
force-pushed
the
maurice/panic-on-nil-sysAcc
branch
from
f03a58d to
799a2a8
Compare
neilalexander
added a commit
that referenced
this pull request
Nov 12, 2024
Includes the following: * Some tweaks to the NRG test helpers * #6055 * #6061 * #6065 * #6041 (but with `math/rand` instead of `math/rand/v2` due to an older Go version in CI for 2.10.x) * #6066 * #6067 * #6069 * #6075 * #6082 * #6087 * #6086 * #6088 * #6089 * #6092 * #6096 * #6098 * #6097 * #6105 * #6104 * #6106 * #6109 * #6111 * #6112 Signed-off-by: Neil Twigg <neil@nats.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Maurice van Veen github@mauricevanveen.com