NRG (2.11): Do not revert term on truncate WAL#5975
Merged
derekcollison merged 1 commit intomainfrom Oct 8, 2024
Merged
Conversation
neilalexander
force-pushed
the
neil/nrgtruncateterm
branch
from
649bb5d to
b3cd4f5
Compare
Member
Author
|
Force push was to add unit test BTW. |
Member
|
ok will wait on green and them merge. |
Signed-off-by: Neil Twigg <neil@nats.io> Co-authored-by: Maurice van Veen <github@mauricevanveen.com>
neilalexander
force-pushed
the
neil/nrgtruncateterm
branch
from
b3cd4f5 to
25561f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is never safe for the term number to go backwards for any reason, even in a truncate scenario, as this breaks the consistency guarantees and could cause us to vote again in what should be past elections if more than one node has to truncate back at the same time.
All calls to
truncateWAL(...)are after the AE has bumped the term number up if needed, so this is safe for making forward progress.Signed-off-by: Neil Twigg neil@nats.io