NRG (2.11): Don't revert term to pterm on AE mismatch#5684
Merged
derekcollison merged 1 commit intomainfrom Jul 23, 2024
Merged
NRG (2.11): Don't revert term to pterm on AE mismatch#5684derekcollison merged 1 commit intomainfrom
term to pterm on AE mismatch#5684derekcollison merged 1 commit intomainfrom
Conversation
Beforehand when we were trying to run a catchup, we were reverting the `term` back to `pterm`. We can't ever move the term backwards safely and the catchup itself does not rely on this behaviour in order to work (as the catchup entries are matched only on `pindex`), so don't revert it. Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander
force-pushed
the
neil/nrgaemismatch
branch
from
1ee9a96 to
a549c43
Compare
Member
Author
|
Would like @ReubenMathew's approval before we proceed. |
Contributor
|
Example log of this happening: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Beforehand when we were trying to run a catchup, we were reverting the
termback topterm. We can't ever move the term backwards safely and the catchup itself does not rely on this behaviour in order to work (as the catchup entries are matched only onpterm/pindex), so don't revert it.We saw this behaviour in Antithesis where a catchup could take us back a term.
Signed-off-by: Neil Twigg neil@nats.io