[FIXED] Handle recreating file-based stream to be memory on meta recovery#6069
Merged
derekcollison merged 1 commit intomainfrom Nov 1, 2024
Merged
Conversation
…very Signed-off-by: Maurice van Veen <github@mauricevanveen.com> Co-authored-by: Neil Twigg <neil@nats.io>
MauriceVanVeen
force-pushed
the
maurice/js-meta-replay-file-to-memory-stream
branch
from
afa2acf to
a4884a1
Compare
derekcollison
deleted the
maurice/js-meta-replay-file-to-memory-stream
branch
neilalexander
added a commit
that referenced
this pull request
Nov 12, 2024
Includes the following: * Some tweaks to the NRG test helpers * #6055 * #6061 * #6065 * #6041 (but with `math/rand` instead of `math/rand/v2` due to an older Go version in CI for 2.10.x) * #6066 * #6067 * #6069 * #6075 * #6082 * #6087 * #6086 * #6088 * #6089 * #6092 * #6096 * #6098 * #6097 * #6105 * #6104 * #6106 * #6109 * #6111 * #6112 Signed-off-by: Neil Twigg <neil@nats.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the following scenario:
The call to
js.processStreamAssignment(sa)even while we're recovering would mean that on meta recovery we'd first create the file-based stream, then create the memory-based stream and fail to do so since we can't change storage types. Which then leaves us stranded with 2 nodes having a memory-based stream, and that one node with a file-based stream.This change proposes to have the stream additions be consistent with the other collecting of state into
ru *recoveryUpdatesbefore applying, and waiting until recovery is finished to do so.Signed-off-by: Maurice van Veen github@mauricevanveen.com
Co-authored-by: Neil Twigg neil@nats.io