Patch Tuesday for November 2023#35116
Closed
BillyONeal wants to merge 18 commits intomicrosoft:masterfrom
Closed
Conversation
BillyONeal
added
info:internal
category:infrastructure
Included is a workaround for https://developercommunity.visualstudio.com/t/Missing-threadsh-in-MSVC-178/10514752 implemented as upstream's commit ebdf9d724cfd0a04f194ecfcb678b702ad062be2
Workaround for facebook/folly#2100 by using plain resize.
BillyONeal
commented
Nov 22, 2023
This was referenced Nov 23, 2023
Merged
This was referenced Nov 24, 2023
Merged
cdacamar
reviewed
Nov 27, 2023
| @@ -567,7 +567,6 @@ function(vcpkg_configure_make) | |||
| string(REPLACE "${_replacement}" "" VCPKG_DETECTED_CMAKE_CXX_FLAGS_RELEASE "${VCPKG_DETECTED_CMAKE_CXX_FLAGS_RELEASE}") | |||
| string(REPLACE "${_replacement}" "" VCPKG_DETECTED_CMAKE_C_FLAGS_RELEASE "${VCPKG_DETECTED_CMAKE_C_FLAGS_RELEASE}") | |||
| # Can somebody please check if CMake's compiler flags for UWP are correct? | |||
Member
Author
There was a problem hiding this comment.
Maybe, but I don't think it's changed by this change if that makes sense
vicroms
pushed a commit
that referenced
this pull request
Nov 29, 2023
Probably broken by #34994 Detected in #35116 where this REGEX is expected to be output from the python script ``` CMake Error at build/cmake/LoadVersion.cmake:9 (string): string sub-command REGEX, mode MATCHALL needs at least 5 arguments total to command. Call Stack (most recent call first): CMakeLists.txt:20 (LoadVersion) ```
Member
Author
|
The compiler is broken so I'm going to cancel this one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/FUto the C compiler when targeting UWPstd::basic_string<T, A, Traits>::_EosDepends on: