Change samples to use DefaultAzureCredential#5183
Merged
antkmsft merged 6 commits intoAzure:mainfrom Nov 29, 2023
Merged
Conversation
antkmsft
requested review from
EmmaZhu,
Jinming-Hu,
LarryOsterman,
RickWinter,
ahmadmsft,
ahsonkhan,
anilba06,
gearama,
gkostal,
microzchang,
vhvb1989 and
vinjiang
as code owners
RickWinter
approved these changes
Nov 27, 2023
LarryOsterman
approved these changes
Nov 27, 2023
...tion/azure-security-attestation/samples/attestation/attest_openenclave_with_draft_policy.cpp
Show resolved
Hide resolved
ahsonkhan
reviewed
Nov 30, 2023
|
|
||
| The simplest way of providing a bearer token is to use the `ClientSecretCredential` authentication method by providing client secret credentials is being used in this | ||
| getting started section, but you can find more ways to authenticate with [azure-identity][azure_identity]. | ||
| The simplest way of providing a bearer token is to use the `DefaultAzureCredential` authentication method is being used in this getting started section, but you can find more ways to authenticate with [azure-identity][azure_identity]. |
Contributor
There was a problem hiding this comment.
This sentence is awkward to read, probably because of a typo.
use the
DefaultAzureCredentialauthentication method is being used in this getting started section
Did you mean this?
Suggested change
| The simplest way of providing a bearer token is to use the `DefaultAzureCredential` authentication method is being used in this getting started section, but you can find more ways to authenticate with [azure-identity][azure_identity]. | |
| The simplest way of providing a bearer token is to use the `DefaultAzureCredential` authentication method which is being used in this getting started section, but you can find more ways to authenticate with [azure-identity][azure_identity]. |
ahsonkhan
reviewed
Nov 30, 2023
| Key Vault Settings client for C++ currently supports the `ClientSecretCredential` for authenticating. | ||
|
|
||
| In the sample below, you can create a credential by setting the Tenant ID, Client ID and Client Secret as environment variables. | ||
| Key Vault Settings client for C++ currently supports any `TokenCredential` for authenticating. |
Contributor
There was a problem hiding this comment.
Suggested change
| Key Vault Settings client for C++ currently supports any `TokenCredential` for authenticating. | |
| Key Vault Settings client for C++ supports any `TokenCredential` for authenticating. |
ahsonkhan
reviewed
Nov 30, 2023
| Key Vault Certificate client for C++ currently supports the `ClientSecretCredential` for authenticating. | ||
|
|
||
| In the sample below, you can create a credential by setting the Tenant ID, Client ID and Client Secret as environment variables. | ||
| Key Vault Certificate client for C++ currently supports any `TokenCredential` for authenticating. |
Contributor
There was a problem hiding this comment.
Suggested change
| Key Vault Certificate client for C++ currently supports any `TokenCredential` for authenticating. | |
| Key Vault Certificate client for C++ supports any `TokenCredential` for authenticating. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5133.
I will make subsequent PRs to put the wording about using the
DefaultAzureCredential. This PR only switches the technical part - it switchesClientSecretCredentialandEnvironmentCredentialtoDefaultAzureCredential.In a subsequent PR, we will forge the best possible wording to accompany the usages of
DefaultAzureCredential, all the instances at once, and we will be able to discuss that wording in that separate PR.--
UWP CI is currently blocked until microsoft/vcpkg#35279 is fixed / microsoft/vcpkg#35116 is merged (#5181 would unblock)