AzureCliCredential to treat datetime without TZ info as local time.#5179
Merged
antkmsft merged 12 commits intoAzure:mainfrom Dec 16, 2023
Merged
AzureCliCredential to treat datetime without TZ info as local time.#5179antkmsft merged 12 commits intoAzure:mainfrom
antkmsft merged 12 commits intoAzure:mainfrom
Conversation
14 tasks
antkmsft
requested review from
a team,
LarryOsterman,
RickWinter,
ahsonkhan,
gearama,
schaabs and
vhvb1989
as code owners
antkmsft
requested review from
KarishmaGhiya,
chlowell,
mpodwysocki,
pvaneck and
xiangyan99
RickWinter
reviewed
Nov 27, 2023
ahsonkhan
reviewed
Nov 29, 2023
ahsonkhan
reviewed
Nov 29, 2023
antkmsft
commented
Dec 1, 2023
ahsonkhan
reviewed
Dec 14, 2023
ahsonkhan
reviewed
Dec 14, 2023
ahsonkhan
reviewed
Dec 14, 2023
ahsonkhan
reviewed
Dec 14, 2023
ahsonkhan
reviewed
Dec 14, 2023
ahsonkhan
reviewed
Dec 14, 2023
ahsonkhan
approved these changes
Dec 16, 2023
Contributor
ahsonkhan
left a comment
ahsonkhan
left a comment
There was a problem hiding this comment.
This is a much cleaner and isolated fix (without requiring extra parsing logic in DateTime within Azure::Core). Appreciate it!
This was referenced Jan 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5075.
This is not a replacement for #5180, because that one will work only if the user has the new version of Azure CLI installed.
Obsoletes #5076.