Remove some usages of internal APIs in samples#5186
Merged
antkmsft merged 5 commits intoAzure:mainfrom Nov 28, 2023
Merged
Conversation
antkmsft
requested review from
LarryOsterman,
RickWinter,
ahmadmsft,
ahsonkhan,
anilba06,
gearama,
gkostal and
vhvb1989
as code owners
RickWinter
approved these changes
Nov 27, 2023
sdk/eventhubs/azure-messaging-eventhubs/samples/consume-events/consume_events.cpp
Outdated
Show resolved
Hide resolved
ahsonkhan
reviewed
Nov 27, 2023
sdk/eventhubs/azure-messaging-eventhubs/samples/consume-events/consume_events.cpp
Outdated
Show resolved
Hide resolved
ahsonkhan
approved these changes
Nov 27, 2023
LarryOsterman
approved these changes
Nov 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the easy to remove.
We have about 4 more instances of using
_internalin samples that are not as straightforward to remove:Azure::Storage::_internal::ParseConnectionString()(blob_sas.cpp) - Storage Blobs sample is using the_internalfunctionality #5192Azure::Core::Cryptography::_internal::Sha256Hash(set_policy.cpp,set_sealed_policy.cpp) - Attestation samples are exposing the_internal::Sha256Hashtype to the customers #5193Azure::Core::_internal::StringExtensions::ToUpper()(cryptohelpers.hpp) - Attestation samples are exposing_internal::StringExtensions::ToUpper()to customers #5194Azure::Core::_internal::Base64Url::Base64UrlDecode()(attestation_collateral.cpp) - Attestation samples are exposing_internal::Base64Url::Base64UrlDecode()to customers #5195In either case I would address them in separate PRs, but maybe I'll just create the issues for them and let the service owners to fix them.
--
UWP CI is currently blocked until microsoft/vcpkg#35279 is fixed / microsoft/vcpkg#35116 is merged (#5181 would unblock)