Skip to content

[libbson] Fix libbson when Python3 isn't on the PATH#35276

Merged
vicroms merged 1 commit intomicrosoft:masterfrom
BillyONeal:libbson-no-python
Nov 29, 2023
Merged

[libbson] Fix libbson when Python3 isn't on the PATH#35276
vicroms merged 1 commit intomicrosoft:masterfrom
BillyONeal:libbson-no-python

Conversation

@BillyONeal
Copy link
Member

Probably broken by #34994

Detected in #35116

where this REGEX is expected to be output from the python script

CMake Error at build/cmake/LoadVersion.cmake:9 (string):
  string sub-command REGEX, mode MATCHALL needs at least 5 arguments total to
  command.
Call Stack (most recent call first):
  CMakeLists.txt:20 (LoadVersion)

Probably broken by microsoft#34994

Detected in microsoft#35116

where this REGEX is expected to be output from the python script

```
CMake Error at build/cmake/LoadVersion.cmake:9 (string):
  string sub-command REGEX, mode MATCHALL needs at least 5 arguments total to
  command.
Call Stack (most recent call first):
  CMakeLists.txt:20 (LoadVersion)
```
@BillyONeal BillyONeal added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Nov 22, 2023
@LilyWangLL
Copy link
Contributor

Thanks for Billy's fix. This port also failed on automation run Pipelines - Run 20231121.2 (azure.com).

@MonicaLiu0311 MonicaLiu0311 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Nov 23, 2023
@vicroms vicroms merged commit ca595d3 into microsoft:master Nov 29, 2023
@BillyONeal BillyONeal deleted the libbson-no-python branch February 2, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants