Merged
Conversation
This was referenced Nov 23, 2023
antkmsft
requested review from
benbp,
danieljurek and
weshaggard
as code owners
This was referenced Nov 24, 2023
Merged
ahsonkhan
reviewed
Nov 27, 2023
Comment on lines
-121
to
-126
| "UWP_debug": { | ||
| "CMAKE_SYSTEM_NAME": "WindowsStore", | ||
| "CMAKE_SYSTEM_VERSION": "10.0", | ||
| "CmakeArgs": " -DBUILD_TRANSPORT_WINHTTP=ON -DDISABLE_AZURE_CORE_OPENTELEMETRY=ON ", | ||
| "BuildArgs": "--parallel 8 --config Debug" | ||
| }, |
Contributor
There was a problem hiding this comment.
I wish there was a field/flag to disable a leg, rather than having to remove the node fully.
cc @benbp - is there a way to do that?
Member
There was a problem hiding this comment.
@ahsonkhan if you want to do it globally via the config, you can use exclude.
ahsonkhan
approved these changes
Nov 27, 2023
Contributor
ahsonkhan
left a comment
ahsonkhan
left a comment
There was a problem hiding this comment.
Approving to unblock CI, let's get an issue to track bringing this back.
Closed
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our UWP CI legs are currently blocked until microsoft/vcpkg#35279 is fixed / microsoft/vcpkg#35116 is merged, so if your PR is blocked, you can merge this PR to unblock. We will revert it once it is fixed in vcpkg.