Update Windows Fleet for December 2023 Patch Tuesday

[BillyONeal]

Follow on from #35116 now that the compiler bug that blocked that appears fixed.

• Update PowerShell to 7.4.0
• Add instructions to roll keys of storage accounts
• Add folly workaround for new STL where they changed the declaration of std::basic_string<T, A, Traits>::_Eos ( See also Add address sanitizer annotations to UninitializedMemoryHacks.h when building with msvc 2022 facebook/folly#1935 )
• Make the buildtrees path shorter to try to make qtwebengine logs retrievable
• Avoid clobbering the downloads directory

Full Windows rebuild: https://dev.azure.com/vcpkg/public/_build/results?buildId=97631
Full UWP rebuild: https://dev.azure.com/vcpkg/public/_build/results?buildId=97657

[BillyONeal]

The qtwebengine failure is #35260 which should be fixed by #35639

[BillyONeal]

The qtwebengine failure is #35260 which should be fixed by #35639

I merged these and submitted https://dev.azure.com/vcpkg/public/_build/results?buildId=97668&view=results only retesting x64-windows since the other triplets were clean without it

[Neumann-A]

Strange since my logs show:

[14265/39164] CXX obj/third_party/perfetto/src/tracing/core/service/trace_buffer.obj
[14266/39164] CXX obj/third_party/webrtc/api/audio_options_api/audio_options.obj
[14267/39164] CXX obj/third_party/perfetto/src/tracing/core/core/shared_memory_abi.obj

with configure log:

-- The C compiler identification is MSVC 19.38.33133.0
-- The CXX compiler identification is MSVC 19.38.33133.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.38.33130/bin/Hostx64/x64/cl.exe - skipped

vs

-- The C compiler identification is MSVC 19.38.33133.0
-- The CXX compiler identification is MSVC 19.38.33133.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Tools/MSVC/14.38.33130/bin/Hostx64/x64/cl.exe - skipped

but I only tested with Release builds. One other difference I see is:
Geolocation ............................ no but that is probably unrelated.

Maybe I diffed the wrong trees. Let me check that didn't diff the wrong tree

[Neumann-A]

Fun fact: It only fails for Debug builds o.O. I mean I can start comparing compiler flags/preprocessed sources but somehow I would say that indicates the compiler is broken? (considering that clang-cl just compiles the code fine) I mean libtorch is also broken by the release with an ICE.
Who failed to test the compiler release against vcpkg? I can only hope you have internally something like bugpoint which could simplify preprocessed sources to generate a reduced test case.

[Neumann-A]

Difference in compiler flags according to the ninja file:

[Neumann-A]

@BillyONeal: Try cleaning up the patch and removing std::remove_cvref_t

[Neumann-A]

Fun fact I already had a case where I had to do this ;)

[Neumann-A]

Link to vs dev issue for libtorch: https://developercommunity.visualstudio.com/t/Internal-compiler-error-when-compiling-l/10539393?space=62&sort=newest

[BillyONeal]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[BillyONeal]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).