Skip to content

[pcl/soil2] Disable optimizations for individual function#23252

Merged
BillyONeal merged 2 commits intomicrosoft:masterfrom
Cheney-W:Dev/Cheney/workaround-ICE
Mar 1, 2022
Merged

[pcl/soil2] Disable optimizations for individual function#23252
BillyONeal merged 2 commits intomicrosoft:masterfrom
Cheney-W:Dev/Cheney/workaround-ICE

Conversation

@Cheney-W
Copy link
Contributor

@Cheney-W Cheney-W commented Feb 24, 2022

Describe the pull request
pcl and soil2 install failed with an internal compile error in release mode, these are known bugs in Visual Studio 2022,
At present, these two bugs have not been fixed. In order not to affect the testing of pcl and soil2 on CI, adding patch to prohibit the optimization of the two functions which cause ICE.

As a workaround of #19561

@Cheney-W Cheney-W added the category:port-bug The issue is with a library, which is something the port should already support label Feb 24, 2022
@Cheney-W Cheney-W marked this pull request as ready for review February 24, 2022 09:57
@LilyWangLL LilyWangLL added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Feb 28, 2022
@BillyONeal BillyONeal merged commit 1e72492 into microsoft:master Mar 1, 2022
ekilmer added a commit to ekilmer/vcpkg that referenced this pull request Mar 2, 2022
* master: (108 commits)
  [calceph] update to version 3.5.1 (microsoft#23325)
  [SpeexDSP] Missing windows definitions (microsoft#23296)
  [triton] Fix usage (microsoft#23250)
  [vcpkg_configure_make] Report warning when unresolved arguments are passed in (microsoft#22567)
  [openmvg] no absolute paths (microsoft#22342)
  [python2] no absolute paths (microsoft#22329)
  [libcpplocate] New port (microsoft#23173)
  [Intelrdfpmathlib] Fix post build error (microsoft#23286)
  [docs] Update maintainer guide to include CMAKE_REQUIRE_FIND_PACKAGE. (microsoft#23321)
  [new-port-template] Remove deprecated cmake (microsoft#23283)
  [xtensor] Update to 0.24.0 (microsoft#23238)
  [pcl/soil2] Disable optimizations for individual function (microsoft#23252)
  [cnats] Add new port (C client for the NATS messaging system). (microsoft#23258)
  [nanobench] Update to 4.3.6 (microsoft#23262)
  [elfio] Update elfio to 3.10 (microsoft#23263)
  [tomlplusplus] Update to 3.0.1 (microsoft#23268)
  [shaderc] Fix CMake export target files (microsoft#23269)
  [PCL] Fix namespace and  VS2022 error C3052 (microsoft#23273)
  [libressl] update to 3.4.2 (microsoft#23276)
  [asio-grpc] Update to 1.4.0 (microsoft#23277)
  ...
@Cheney-W Cheney-W deleted the Dev/Cheney/workaround-ICE branch August 30, 2022 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants