Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
LilyWangLL
added
the
category:port-feature
LilyWangLL
approved these changes
Jan 5, 2022
LilyWangLL
added
the
info:needs-maintainer-attention
strega-nil-ms
added
the
requires:vcpkg-team-review
strega-nil-ms
suggested changes
Jan 7, 2022
Contributor
strega-nil-ms
left a comment
strega-nil-ms
left a comment
There was a problem hiding this comment.
removing -targets.cmake looks really wrong...
strega-nil-ms
added
requires:author-response
and removed
requires:vcpkg-team-review
Contributor
|
poke @autoantwort for response |
strega-nil-ms
removed
the
info:needs-maintainer-attention
Contributor
|
@autoantwort Could you please resolve the conflicts? |
autoantwort
force-pushed
the
openmvg-no-absolute
branch
from
3306ea1 to
3d850b5
Compare
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where a "license" field is missing.
Details
If you feel able to do so, please consider adding a "license" field to the following files:
ports/openmvg/vcpkg.json
Valid values for the license field can be found in the documentation
autoantwort
force-pushed
the
openmvg-no-absolute
branch
2 times, most recently
from
3306ea1 to
77a4479
Compare
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where a "license" field is missing.
Details
If you feel able to do so, please consider adding a "license" field to the following files:
ports/openmvg/vcpkg.json
Valid values for the license field can be found in the documentation
LilyWangLL
added
info:needs-maintainer-attention
autoantwort
force-pushed
the
openmvg-no-absolute
branch
from
77a4479 to
f84c48d
Compare
ekilmer
added a commit
to ekilmer/vcpkg
that referenced
this pull request
Mar 2, 2022
* master: (108 commits) [calceph] update to version 3.5.1 (microsoft#23325) [SpeexDSP] Missing windows definitions (microsoft#23296) [triton] Fix usage (microsoft#23250) [vcpkg_configure_make] Report warning when unresolved arguments are passed in (microsoft#22567) [openmvg] no absolute paths (microsoft#22342) [python2] no absolute paths (microsoft#22329) [libcpplocate] New port (microsoft#23173) [Intelrdfpmathlib] Fix post build error (microsoft#23286) [docs] Update maintainer guide to include CMAKE_REQUIRE_FIND_PACKAGE. (microsoft#23321) [new-port-template] Remove deprecated cmake (microsoft#23283) [xtensor] Update to 0.24.0 (microsoft#23238) [pcl/soil2] Disable optimizations for individual function (microsoft#23252) [cnats] Add new port (C client for the NATS messaging system). (microsoft#23258) [nanobench] Update to 4.3.6 (microsoft#23262) [elfio] Update elfio to 3.10 (microsoft#23263) [tomlplusplus] Update to 3.0.1 (microsoft#23268) [shaderc] Fix CMake export target files (microsoft#23269) [PCL] Fix namespace and VS2022 error C3052 (microsoft#23273) [libressl] update to 3.4.2 (microsoft#23276) [asio-grpc] Update to 1.4.0 (microsoft#23277) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #20469