Skip to content

[SpeexDSP] Missing windows definitions#23296

Merged
vicroms merged 10 commits intomicrosoft:masterfrom
pierr3:master
Mar 2, 2022
Merged

[SpeexDSP] Missing windows definitions#23296
vicroms merged 10 commits intomicrosoft:masterfrom
pierr3:master

Conversation

@pierr3
Copy link
Contributor

@pierr3 pierr3 commented Feb 26, 2022

Describe the pull request

  • What does your PR fix?

Adds missing definitions for building speexdsp on Windows, specifically for jitter_buffer_ctl and jitter_buffer_remaining_span

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    x64-windows & x64-windows-static, No

  • Does your PR follow the maintainer guide?

Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@pierr3 pierr3 changed the title [SpeexDSP] [SpeexDSP] Missing windows definitions Feb 26, 2022
@JackBoosY JackBoosY added the category:port-bug The issue is with a library, which is something the port should already support label Feb 28, 2022
@JackBoosY
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY
Copy link
Contributor

Close and reopen this PR to make PR suggestion bot happy.

@JackBoosY JackBoosY closed this Feb 28, 2022
@JackBoosY JackBoosY reopened this Feb 28, 2022
@JackBoosY
Copy link
Contributor

Can you push an empty commit to re-trigger the suggestion check?

Thanks.

@pierr3
Copy link
Contributor Author

pierr3 commented Feb 28, 2022

Not too sure why the suggestion check fails on formatting, despite returning "Succeeded in formatting the manifest files.", should I re-submit the PR entirely?

@JackBoosY
Copy link
Contributor

Not too sure why the suggestion check fails on formatting, despite returning "Succeeded in formatting the manifest files.", should I re-submit the PR entirely?

Yes please, sorry for that.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/speexdsp/portfile.cmake

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/speexdsp/vcpkg.json

Valid values for the license field can be found in the documentation

@JackBoosY JackBoosY added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels Mar 2, 2022
@vicroms vicroms merged commit d2ca8c8 into microsoft:master Mar 2, 2022
ekilmer added a commit to ekilmer/vcpkg that referenced this pull request Mar 2, 2022
* master: (108 commits)
  [calceph] update to version 3.5.1 (microsoft#23325)
  [SpeexDSP] Missing windows definitions (microsoft#23296)
  [triton] Fix usage (microsoft#23250)
  [vcpkg_configure_make] Report warning when unresolved arguments are passed in (microsoft#22567)
  [openmvg] no absolute paths (microsoft#22342)
  [python2] no absolute paths (microsoft#22329)
  [libcpplocate] New port (microsoft#23173)
  [Intelrdfpmathlib] Fix post build error (microsoft#23286)
  [docs] Update maintainer guide to include CMAKE_REQUIRE_FIND_PACKAGE. (microsoft#23321)
  [new-port-template] Remove deprecated cmake (microsoft#23283)
  [xtensor] Update to 0.24.0 (microsoft#23238)
  [pcl/soil2] Disable optimizations for individual function (microsoft#23252)
  [cnats] Add new port (C client for the NATS messaging system). (microsoft#23258)
  [nanobench] Update to 4.3.6 (microsoft#23262)
  [elfio] Update elfio to 3.10 (microsoft#23263)
  [tomlplusplus] Update to 3.0.1 (microsoft#23268)
  [shaderc] Fix CMake export target files (microsoft#23269)
  [PCL] Fix namespace and  VS2022 error C3052 (microsoft#23273)
  [libressl] update to 3.4.2 (microsoft#23276)
  [asio-grpc] Update to 1.4.0 (microsoft#23277)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants