Skip to content

[pcl] Backport MSVC optimizer workaround of openNURBS#41606

Merged
vicroms merged 1 commit intomicrosoft:masterfrom
WangWeiLin-MV:ports/pcl/backport-msvc-optimizer-workaround
Oct 29, 2024
Merged

[pcl] Backport MSVC optimizer workaround of openNURBS#41606
vicroms merged 1 commit intomicrosoft:masterfrom
WangWeiLin-MV:ports/pcl/backport-msvc-optimizer-workaround

Conversation

@WangWeiLin-MV
Copy link
Contributor

@WangWeiLin-MV WangWeiLin-MV commented Oct 17, 2024

Fix #41592

Backport

Related

Checklist

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Test

The port feature surface-on-nurbs installation tests pass with the following triplets:

  • x64-windows

@WangWeiLin-MV WangWeiLin-MV added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Oct 17, 2024
BillyONeal
BillyONeal previously approved these changes Oct 18, 2024
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Cheney-W Cheney-W marked this pull request as ready for review October 21, 2024 09:10
@Cheney-W Cheney-W added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Oct 21, 2024
@data-queue data-queue added the depends:upstream-changes Waiting on a change to the upstream project label Oct 22, 2024
@WangWeiLin-MV WangWeiLin-MV changed the title [pcl] Backport MSVC optimizer wordaround of openNURBS [pcl] Backport MSVC optimizer workaround of openNURBS Oct 24, 2024
@vicroms vicroms merged commit 1b63f25 into microsoft:master Oct 29, 2024
@WangWeiLin-MV WangWeiLin-MV deleted the ports/pcl/backport-msvc-optimizer-workaround branch October 29, 2024 10:02
@WangWeiLin-MV WangWeiLin-MV removed the depends:upstream-changes Waiting on a change to the upstream project label Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[pcl] pcl[surface-on-nurbs] build failure

5 participants