[vcpkg_configure_make] Report warning when unresolved arguments are passed in by JackBoosY · Pull Request #22567 · microsoft/vcpkg

JackBoosY · 2022-01-17T00:43:31Z

In #22321, I wrote a typo keyword OPTIOS and it was not recoginzed or report warnign message, that's not good.

Fix that.

Fixes #22535.

…assed in

JackBoosY · 2022-01-18T05:56:11Z

Depends on #22534

JackBoosY · 2022-01-19T03:25:43Z

scripts/cmake/vcpkg_configure_make.cmake

    # parse parameters such that semicolons in options arguments to COMMAND don't get erased
    cmake_parse_arguments(PARSE_ARGV 0 arg
-        "AUTOCONFIG;SKIP_CONFIGURE;COPY_SOURCE;DISABLE_VERBOSE_FLAGS;NO_ADDITIONAL_PATHS;ADD_BIN_TO_PATH;USE_WRAPPERS;DETERMINE_BUILD_TRIPLET"
+        "AUTOCONFIG;SKIP_CONFIGURE;COPY_SOURCE;DISABLE_VERBOSE_FLAGS;NO_ADDITIONAL_PATHS;ADD_BIN_TO_PATH;NO_DEBUG;USE_WRAPPERS;DETERMINE_BUILD_TRIPLET"


NO_DEBUG is used below but is not declare here.

And it is not documented.

is NO_DEBUG used anywhere ? Couldn't the same be achieved by setting VCPKG_BUILD_TYPE before the command?

@Neumann-A See

vcpkg/ports/liburing/portfile.cmake

Lines 13 to 17 in f54a7b0

vcpkg_configure_make(

SOURCE_PATH ${SOURCE_PATH}

COPY_SOURCE

NO_DEBUG

)

Yeah I suddenly realized that this option has no effect now unless the makefile doesn't support debug mode.

JackBoosY · 2022-01-28T18:11:54Z

CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:85 (file):
  file failed to open for reading (No such file or directory):

    /mnt/vcpkg-ci/buildtrees/liburing/build-x64-linux-dbg-out.log
Call Stack (most recent call first):
  scripts/cmake/vcpkg_build_make.cmake:187 (vcpkg_execute_build_process)
  scripts/cmake/vcpkg_install_make.cmake:26 (vcpkg_build_make)
  ports/liburing/portfile.cmake:20 (vcpkg_install_make)
  scripts/ports.cmake:142 (include)

No idea why it happened.

JackBoosY · 2022-02-17T08:38:37Z

vcpkg_configure_make does not match vcpkg_build_make when NO_DEBUG is enabled.

…jack/22535

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for liburing but no changes to version or port version.
-- Version: 2.0#1
-- Old SHA: e193d537e05887e8efeae8ab1328dc7e33499e01
-- New SHA: c55a2eac95d3a562676486733be22dbac100f5a5
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout f54a7b00130e54a398e9c852d200616b670e991c -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/l-/liburing.json b/versions/l-/liburing.json
index 495253e..3ebb4cd 100644
--- a/versions/l-/liburing.json
+++ b/versions/l-/liburing.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "c55a2eac95d3a562676486733be22dbac100f5a5",
+      "git-tree": "e193d537e05887e8efeae8ab1328dc7e33499e01",
       "version": "2.0",
       "port-version": 1
     },

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/apr-util/vcpkg.json
ports/apr/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/apr-util/vcpkg.json
ports/apr/vcpkg.json
ports/liburing/vcpkg.json

Valid values for the license field can be found in the documentation

* master: (108 commits) [calceph] update to version 3.5.1 (microsoft#23325) [SpeexDSP] Missing windows definitions (microsoft#23296) [triton] Fix usage (microsoft#23250) [vcpkg_configure_make] Report warning when unresolved arguments are passed in (microsoft#22567) [openmvg] no absolute paths (microsoft#22342) [python2] no absolute paths (microsoft#22329) [libcpplocate] New port (microsoft#23173) [Intelrdfpmathlib] Fix post build error (microsoft#23286) [docs] Update maintainer guide to include CMAKE_REQUIRE_FIND_PACKAGE. (microsoft#23321) [new-port-template] Remove deprecated cmake (microsoft#23283) [xtensor] Update to 0.24.0 (microsoft#23238) [pcl/soil2] Disable optimizations for individual function (microsoft#23252) [cnats] Add new port (C client for the NATS messaging system). (microsoft#23258) [nanobench] Update to 4.3.6 (microsoft#23262) [elfio] Update elfio to 3.10 (microsoft#23263) [tomlplusplus] Update to 3.0.1 (microsoft#23268) [shaderc] Fix CMake export target files (microsoft#23269) [PCL] Fix namespace and VS2022 error C3052 (microsoft#23273) [libressl] update to 3.4.2 (microsoft#23276) [asio-grpc] Update to 1.4.0 (microsoft#23277) ...

[vcpkg_configure_make] Report warning when unresolved arguments are p…

e214da9

…assed in

JackBoosY added the category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed label Jan 17, 2022

JackBoosY assigned LilyWangLL Jan 17, 2022

github-actions bot approved these changes Jan 17, 2022

View reviewed changes

JackBoosY added the info:internal label Jan 17, 2022

JackBoosY added depends:different-pr This PR or Issue depends on a PR which has been filed and removed depends:different-pr This PR or Issue depends on a PR which has been filed labels Jan 18, 2022

JackBoosY requested a review from LilyWangLL January 19, 2022 03:18

Add missing option NO_DEBUG

58a8e23

github-actions bot approved these changes Jan 19, 2022

View reviewed changes

JackBoosY commented Jan 19, 2022

View reviewed changes

LilyWangLL approved these changes Jan 19, 2022

View reviewed changes

LilyWangLL added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jan 19, 2022

JackBoosY removed the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jan 19, 2022

JackBoosY added 2 commits February 17, 2022 00:40

Merge branch 'master' of https://github.com/microsoft/vcpkg into dev/…

07d69c5

…jack/22535

Add _VCPKG_MAKE_NO_DEBUG for vcpkg_configure_make

1bfa065

JackBoosY added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Feb 17, 2022

github-actions bot approved these changes Feb 17, 2022

View reviewed changes

Add more condition

2a2d6d2

github-actions bot approved these changes Feb 17, 2022

View reviewed changes

JackBoosY added 4 commits February 17, 2022 23:07

[apr] Remove NO_DEBUG

ec1f65a

[liburing] Remove NO_DEBUG

e5c0cb9

[apr-util] Remove NO_DEBUG

417473b

version

849acc7

github-actions bot requested changes Feb 18, 2022

View reviewed changes

JackBoosY added 2 commits February 17, 2022 23:40

Mssing port-version ++

eedd2d3

version

54137b4

github-actions bot approved these changes Feb 18, 2022

View reviewed changes

JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Feb 25, 2022

vicroms merged commit e86ed50 into microsoft:master Mar 2, 2022

JackBoosY deleted the dev/jack/22535 branch March 3, 2022 02:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[vcpkg_configure_make] Report warning when unresolved arguments are passed in#22567

[vcpkg_configure_make] Report warning when unresolved arguments are passed in#22567
vicroms merged 11 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/22535

JackBoosY commented Jan 17, 2022

Uh oh!

JackBoosY commented Jan 18, 2022

Uh oh!

JackBoosY Jan 19, 2022

Uh oh!

dg0yt Jan 19, 2022

Uh oh!

Neumann-A Feb 17, 2022

Uh oh!

JackBoosY Feb 17, 2022

Uh oh!

JackBoosY Feb 18, 2022

Uh oh!

JackBoosY commented Jan 28, 2022

Uh oh!

JackBoosY commented Feb 17, 2022

Uh oh!

github-actions bot left a comment

Uh oh!

github-actions bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	vcpkg_configure_make(
	SOURCE_PATH ${SOURCE_PATH}
	COPY_SOURCE
	NO_DEBUG
	)

Conversation

JackBoosY commented Jan 17, 2022

Uh oh!

JackBoosY commented Jan 18, 2022

Uh oh!

JackBoosY Jan 19, 2022

Choose a reason for hiding this comment

Uh oh!

dg0yt Jan 19, 2022

Choose a reason for hiding this comment

Uh oh!

Neumann-A Feb 17, 2022

Choose a reason for hiding this comment

Uh oh!

JackBoosY Feb 17, 2022

Choose a reason for hiding this comment

Uh oh!

JackBoosY Feb 18, 2022

Choose a reason for hiding this comment

Uh oh!

JackBoosY commented Jan 28, 2022

Uh oh!

JackBoosY commented Feb 17, 2022

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants