Skip to content

[python2] no absolute paths#22329

Merged
vicroms merged 2 commits intomicrosoft:masterfrom
autoantwort:python2-no-absolute
Mar 2, 2022
Merged

[python2] no absolute paths#22329
vicroms merged 2 commits intomicrosoft:masterfrom
autoantwort:python2-no-absolute

Conversation

@autoantwort
Copy link
Contributor

For #20469

Like #21144

@JackBoosY JackBoosY self-assigned this Jan 4, 2022
@JackBoosY JackBoosY added the category:port-bug The issue is with a library, which is something the port should already support label Jan 4, 2022
@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jan 4, 2022
Copy link
Contributor

@strega-nil-ms strega-nil-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made the changes in a local branch, so I'll push.

@JackBoosY JackBoosY added requires:author-response and removed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Jan 5, 2022
@strega-nil-ms
Copy link
Contributor

@autoantwort what do you think of my changes?

Copy link
Contributor Author

@autoantwort autoantwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM!

@JackBoosY
Copy link
Contributor

I will ping Nicole internal.

@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Feb 25, 2022
@vicroms vicroms merged commit a46f923 into microsoft:master Mar 2, 2022
ekilmer added a commit to ekilmer/vcpkg that referenced this pull request Mar 2, 2022
* master: (108 commits)
  [calceph] update to version 3.5.1 (microsoft#23325)
  [SpeexDSP] Missing windows definitions (microsoft#23296)
  [triton] Fix usage (microsoft#23250)
  [vcpkg_configure_make] Report warning when unresolved arguments are passed in (microsoft#22567)
  [openmvg] no absolute paths (microsoft#22342)
  [python2] no absolute paths (microsoft#22329)
  [libcpplocate] New port (microsoft#23173)
  [Intelrdfpmathlib] Fix post build error (microsoft#23286)
  [docs] Update maintainer guide to include CMAKE_REQUIRE_FIND_PACKAGE. (microsoft#23321)
  [new-port-template] Remove deprecated cmake (microsoft#23283)
  [xtensor] Update to 0.24.0 (microsoft#23238)
  [pcl/soil2] Disable optimizations for individual function (microsoft#23252)
  [cnats] Add new port (C client for the NATS messaging system). (microsoft#23258)
  [nanobench] Update to 4.3.6 (microsoft#23262)
  [elfio] Update elfio to 3.10 (microsoft#23263)
  [tomlplusplus] Update to 3.0.1 (microsoft#23268)
  [shaderc] Fix CMake export target files (microsoft#23269)
  [PCL] Fix namespace and  VS2022 error C3052 (microsoft#23273)
  [libressl] update to 3.4.2 (microsoft#23276)
  [asio-grpc] Update to 1.4.0 (microsoft#23277)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants