Fix/preview html #209
Merged
Fix/preview html #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sorry, prve dva commity su v druhom pull requeste, ked som testil tak som chcel mat vsetko a neuvazene merzol sem. |
adammockor
reviewed
Mar 3, 2020
| @@ -36,7 +36,10 @@ export const MDXComponents = { | |||
| a: props => <Link {...props} />, | |||
| inlineCode: props => <Code {...props} />, | |||
| code: props => ( | |||
| <CodeBlock language={props.className.replace(/language-/, '')} {...props} /> | |||
| <CodeBlock | |||
| language={props.className && props.className.replace(/language-/, '')} | |||
There was a problem hiding this comment.
Vyborny priestor na vyskusanie optional chaining :)
props.className?.replace(/language-/, '') by malo spravit job.
There was a problem hiding this comment.
pushol som do spravnej branche #210
| @@ -214,6 +211,7 @@ export default class CodeExample extends React.Component { | |||
| <Code | |||
| inline={false} | |||
| ref={this.codeBlockRef} | |||
| data-testid={this.state.codePreviewType} | |||
There was a problem hiding this comment.
data-testid= sa ti naozaj zobrazi aj v produkcii, co nie je bohvieco. Napisem nizsie, ako z toho idealne vykluckovat.
|
|
||
| fireEvent.click(getByText('HTML')); | ||
|
|
||
| expect(getByTestId('html')).toBeInTheDocument(); |
There was a problem hiding this comment.
Ked mam test, ktory checkuje ze ci sa zrenderuje viac ako 1 child, tak by som pocital kolko sa ich zrenderovalo. Napr aj tak, ze si das test-id do renderu tu.
<Preview>
<p data-testid="p1">Paragraph 1</p>
<p data-testid="p1">Paragraph 2</p>
</Preview>
There was a problem hiding this comment.
no lenze toto nebude fungovat kedze ten vystup je nieco taketo:
<span class="token tag"><span class="token tag"><span class="token punctuation"><</span>svg</span> <span class="token attr-name">class</span><span class="token attr-value"><span class="token punctuation">=</span><span class="token punctuation">"</span>icon icon--heart<span class="token punctuation">"</span></span> <span class="token attr-name">role</span><span class="token attr-value"><span class="token punctuation">=</span><span class="token punctuation">"</span>presentation<span class="token punctuation">"</span></span> <span class="token attr-name">aria-hidden</span><span class="token attr-value"><span class="token punctuation">=</span><span class="token punctuation">"</span>true<span class="token punctuation">"</span></span><span class="token punctuation">></span></span>There was a problem hiding this comment.
No ale to data-testid tam niekde bude.
There was a problem hiding this comment.
Aha rozumiem, zrejme nebude.
Stale vies selectovat cez text content cize vies hladat napr. Paragraph 1 a Paragraph 2
|
|
||
| fireEvent.click(getByText('SHOW CODE')); | ||
|
|
||
| fireEvent.click(getByText('HTML')); |
There was a problem hiding this comment.
Ak by si chcel specificky testovat, ci funguje zobrazenie HTML, testoval by som taketo nieco:
const Paragraph = () => <p data-testid="paragraph">Paragraph</p>
<Preview>
<Paragraph />
</Preview>
There was a problem hiding this comment.
vid koment vyssie. ja testujem, ci mi nespadne html code example ked su tam 2 childs, preto sa aj test vola HTML preview renders more than 1 child
Merged
jurajk
added a commit
that referenced
this pull request
Mar 22, 2020
commit 6d7c56e Author: Adam Močkoř <[email protected]> Date: Thu Mar 19 21:31:31 2020 +0100 Release/3.5.2 (#215) * update version * update changelog commit ec31f78 Author: Adam Močkoř <[email protected]> Date: Thu Mar 19 21:22:17 2020 +0100 Fix/typescript support (#214) * fix extensions in paths (and cleanup) * fix paths to allow ts and tsx extensions * get rid of webpack multicompiler mulicompiler was not compatible with TS error handling in CRA commit d0bef65 Author: Adam Močkoř <[email protected]> Date: Wed Mar 11 18:04:26 2020 +0100 Release/3.5.1 (#213) * update changelog * update version commit 73e2144 Author: Milan Lajtoš <[email protected]> Date: Wed Mar 11 17:29:35 2020 +0100 Add postcss-inline-svg (#212) Lighter 2.x had `postcss-inline-svg`, but in 3.0 it was missing. It broke DDS. It provides `svg-load` function that inlines SVG into data-uri. commit 7870f5c Merge: 0e9a282 cb4f9ac Author: jurajk <[email protected]> Date: Wed Mar 4 11:20:13 2020 +0100 Merge pull request #211 from lightingbeetle/release/3.5.3 Release/3.5.3 commit cb4f9ac Author: jurajk <[email protected]> Date: Wed Mar 4 11:17:00 2020 +0100 bump version commit 6abe577 Author: jurajk <[email protected]> Date: Wed Mar 4 11:16:45 2020 +0100 write changelog commit 0e9a282 Merge: bd632ae bc5e23d Author: jurajk <[email protected]> Date: Wed Mar 4 10:47:28 2020 +0100 Merge pull request #210 from lightingbeetle/fix/mdx-language prevent error when no mdx language is defined commit bd632ae Merge: 1f19f89 d177dde Author: jurajk <[email protected]> Date: Wed Mar 4 10:47:17 2020 +0100 Merge pull request #209 from lightingbeetle/fix/preview-html Fix/preview html commit bc5e23d Author: jurajk <[email protected]> Date: Wed Mar 4 10:39:20 2020 +0100 use optional chaining to assign language commit d177dde Author: jurajk <[email protected]> Date: Tue Mar 3 16:54:03 2020 +0100 add test commit 2050bf8 Author: jurajk <[email protected]> Date: Tue Mar 3 16:53:39 2020 +0100 prevent html code example from crashing when children is array commit 0c9bb29 Merge: 1f19f89 15758b3 Author: jurajk <[email protected]> Date: Tue Mar 3 16:45:57 2020 +0100 Merge branch 'fix/mdx-language' into fix/preview-html commit 15758b3 Author: jurajk <[email protected]> Date: Tue Mar 3 10:55:53 2020 +0100 prevent error when no mdx language is defined commit 1f19f89 Merge: d373778 bfb53ec Author: jurajk <[email protected]> Date: Tue Mar 3 10:46:37 2020 +0100 Merge pull request #208 from lightingbeetle/release/3.5.2 Release/3.5.2 commit bfb53ec Author: jurajk <[email protected]> Date: Tue Mar 3 10:42:53 2020 +0100 bump versions commit d712b74 Author: jurajk <[email protected]> Date: Tue Mar 3 10:42:37 2020 +0100 write changelog commit d373778 Merge: 690e686 5b62bf8 Author: jurajk <[email protected]> Date: Tue Mar 3 10:14:55 2020 +0100 Merge pull request #207 from lightingbeetle/release/3.5.1 Release/3.5.1 commit 5b62bf8 Author: jurajk <[email protected]> Date: Tue Mar 3 10:11:28 2020 +0100 fix typo commit 7ebb8a2 Author: jurajk <[email protected]> Date: Tue Mar 3 10:08:54 2020 +0100 write changelog commit 1b62102 Author: jurajk <[email protected]> Date: Tue Mar 3 10:08:46 2020 +0100 bump versions commit 690e686 Author: jurajk <[email protected]> Date: Tue Mar 3 09:50:52 2020 +0100 Fix/syntax highlighting (#206) * fix theme * pass language from MDX to CodeBlock * update mdx-js * update styleguide react-scripts * add package-lock * fix overflowing container * update theme colors * prevent theme from falling to first html element in preview commit d0704de Author: Adam Močkoř <[email protected]> Date: Wed Feb 19 18:42:33 2020 +0100 Release/3.5.0 (#205) * update changelog * update versions commit 102411c Author: Adam Močkoř <[email protected]> Date: Wed Feb 19 18:30:28 2020 +0100 Feat/cra update (#204) * Publish - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] * Update runtime chunk name separator in docs (facebook#7705) * Remove 'shortcut' link type before 'icon' (facebook#7707) * Guard polyfills against window possibly being undefined (facebook#7205) * Enable .eslintignore with extend flag (facebook#7562) * Add "entrypoints" key to asset manifest (facebook#7721) * Update adding flow documentation (facebook#7731) * set output.globalObject to 'this' (facebook#7742) Closes facebook#7741 * Update logic and log errors for EXTEND_ESLINT (facebook#7530) * update list of supported jest config overrides (facebook#7601) * Upgrade Webpack version (facebook#7740) * Close br tags in template README files (facebook#7668) * Fix variable name casing in fileTransform (facebook#7752) * Documentation typo fix (facebook#7757) * Fix linting error when using rest props (facebook#7754) * Add TSC_COMPILE_ON_ERROR setting (facebook#6931) * Remove switch case (facebook#7729) * docs: note that v2 to v3 migration may require deletion of node_modules (facebook#7302) * Stop hiding the column number of ESLint errors (facebook#6980) * Support setting baseUrl to root directory (facebook#7755) * Use installing package manager in README (facebook#7687) * Support production profiling with React Developer Tools (facebook#7737) * Added the alias for profiling and output change to keep the classNames and functionNames for human readbility * defined isEnvProductionProfile with other isEnv checks * moved the keep_classnames and keep_fnames to terserOptions scope * resolve merge conflict for yarn.lock.cache * revert yarn.lock.cache to master yarn.lock.cache - git checkout origin/master -- packages/create-react-app/yarn.lock.cached * Comment and Boolean Check - I clarified the comment and specified the use case - Changed the environment check to check for the specific true rather than the assumed primitive value as before. * Replaced env with flag - Per suggestion --profile flag used instead of env variable PROFILE_APP * documentation in available scripts section with suggested information * resolved a local git issue. Fixed documentation error. * moved documentation to suggested file - Added a brief summary of profiling in available scripts section. The summary references the production-build document. Which is the file I moved the new documentation into under a new Header for production support. * Update production-build.md Co-authored-by: Ian Sutherland <[email protected]> * Prepare 3.2.0 release * Publish - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] * Temporarily disable Windows in CI (facebook#7773) * Add babel runtime version to transform-runtime plugin to reduce… (facebook#7726) * Add Babel sourcemap to resolve VSCode debugging issues (facebook#7022) * Fix process type in TypeScript template (facebook#7796) * Account for browserslist environment variables (facebook#7764) * Clarify dynamic import stage in docs (facebook#7813) * Update adding-typescript.md (facebook#7815) * Document how to use the .env file to enforce HTTPS (facebook#7821) * Fix absolute paths issue in Jest (facebook#7822) * Document correct default behavior for HOST var (facebook#7823) * Fix grammar error in troubleshooting.md (facebook#7824) * Upgrade to docusaurus 2 (facebook#7785) * chore: upgrade to docusaurus 2 * address review * Update doc publishing instructions * Revert logo in templates (facebook#7830) * feat: add additional Jest keys to whitelist (facebook#7832) * Link to React documentation for code splitting (facebook#7686) The official documentation offers a simpler way of achieving route based code splitting. * Add a note about .eslingignore files being respected (facebook#7809) * added check for typescript template and unsupported node version (facebook#7839) * added check for typescript template and unsupported node version * addressed code review feedback regarding syntax and spelling mistakes * Update getting-started.md (facebook#7841) Update the initial project structure generated by create-react-app. * Link to ASP.NET Core docs (facebook#7840) * Update readme gif links (facebook#7849) * Update adding-bootstrap.md (facebook#7853) typo fix * Move unused eslint webpack import into @remove-on-eject block (facebook#7856) * 📖 DOC: Improvement (facebook#7819) * Upgrade terser & enable parallel minification in wsl (facebook#7857) * Add a GitHub Action that runs the build script (facebook#7861) * Edit InterpolateHtmlPlugin hook (facebook#6448) (facebook#6449) * Fix notations of loopback addresses (facebook#7474) * Add Service-Worker header to checkValidServiceWorker (facebook#6753) * Add header to checkValidServiceWorker (ts) * Add header to checkValidServiceWorker * Add additional information for postcss errors (facebook#6282) (facebook#6352) * Add additional information for postcss errors * Add additional information for postcss errors (simplify) * Remove chunkname from postCSS compile error * Remove line number from postCSS compile error * Fix eslint complaints in build.js (facebook#7870) * Add Alex to lint documentation (facebook#7852) * Add Alex to lint documentation * Attempt to trigger GitHub Action * Configure Alex and update docs * More docs updates * Bump docusaurus 🦖 (facebook#7874) * Dark scheme overlay (facebook#7052) * Bump react (facebook#7875) * Bump styling related loaders (facebook#7876) * Remove alex precommit check (facebook#7878) * Add template support (facebook#7716) * Add template support * Update templates version check * Update TypeScript template README * Prepare 3.3.0 beta * If template name already starts with cra-template leave it alone (facebook#7880) * Update prerelease publishing instructions * Upgrade packages and tweak config to adapt to new config format (facebook#7814) Rebased again now with smaller changes in this one which will make it easier to revert in case of eventual regressions. * refactor: remove double coerce (facebook#7882) * Add yarn.lock to .gitignore (facebook#7789) * chore: Fix broken link for CRA deployment (facebook#7897) * chore: Fix broken link for e2e README (facebook#7896) * Add @testing-library to the default templates (facebook#7881) * Add numeric separator support (facebook#7817) * Update open (facebook#7910) * Mark TypeScript as an optional peer dependency (facebook#7860) * Add restoreMocks to supported jest config keys (facebook#7921) * fix seperators typo (facebook#7932) Its the little things that makes the big difference! 😁 Thanks * No spinning React logo if `prefers-reduced-motion` (facebook#7931) * Made PRs welcome badge point to contributors guide (facebook#7792) * Make JavaScript and TypeScript templates consistent (facebook#7944) * Fix CI (facebook#7951) * Add optional chaining and nullish coalescing operators support (facebook#7438) * Add tests for optional chaining and null coalescing (facebook#7952) * Upgrade jest-watch-typeahead (facebook#7956) * Fix light background in docusaurus night mode (facebook#7936) * Fix light background in docusaurus night mode Closes facebook#7930 * Rename lightBackground to gettingStartedSection * Add placeholders where old template READMEs used to be (facebook#7972) * Temporarily disable GitHub Actions (facebook#7978) * Prepare 3.3.0 beta * Bump dependencies (facebook#7986) * Support scoped templates (facebook#7991) * Add contributors section to readme (facebook#7995) * added e2e test for checking typescript template with unsupported node (facebook#7844) * Unpin dependencies in react-app-polyfill (facebook#7999) * Add scripts support to templates (facebook#7989) * Override no-unused-expressions with the typescript-eslint version (facebook#8003) Fixes issues with optional chaining * Prefix apple-touch-icon links with PUBLIC_URL. (facebook#8005) * Bump webpack-dev-server (facebook#7988) * Bump dependencies (facebook#8024) * Re-enable GitHub Actions (facebook#8029) * Update CHANGELOG * Update CODEOWNERS * Remove no-unexpected-multiline rule (facebook#8039) * Add TypeScript peer dependency to react-scripts (facebook#8038) * Update template docs (facebook#8050) * Update template docs * Update custom-templates.md * Update custom-templates.md Co-authored-by: Ian Sutherland <[email protected]> * Prepare 3.3.0 release * Update CHANGELOG * Publish - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] * webpackHotDev now uses wss when https is used (facebook#8079) * Add custom-templates to docs sidebar (facebook#8077) * Fix typo in CHANGELOG.md (facebook#8080) * Remove error for @typescript-eslint/no-namespace (facebook#7803) Declare namespaces are supported by babel now, and babel will throw with a nice error message for non-declare namespaces, so this rule is unnecessary. Closes facebook#7651. * Fix CI build (facebook#8122) * Fix CSS font-face minification (facebook#8106) * Add slashes to WebSocket protocol URL (facebook#8116) * Fix typo in comment: `?.` is right, not `.?` (facebook#8124) This is just a comment fix. Actual optional chaining operator syntax is `?.`, not `.?`. * chore: update docusaurus & tweak site (facebook#8111) * [Security] Update terser webpack plugin (facebook#8102) * security: update terser webpack plugin * Add current version and bin location to --info output (facebook#8168) Make the --info subcommand outuput the current version information and the location of the file being run. Our issue template tells users to provide the output of --info, so having the current version is incredibly helpful, especially since it doesn't necessarily match the globally installed version that envinfo outputs. Knowing the location helps us determine whether the running bin is globally installed or in the local node_modules. * Bump pkgUp (facebook#8163) * Bump chalk (facebook#8164) * Add link to Netlify in README * Bump internal dependencies (facebook#8176) * Bump dependencies in react-dev-utils * Bump dependencies in react-app-polyfill * Bump dependencies in create-react-app * Bump dependencies in react-error-overlay * Bump dependencies in react-scripts * Bump react * Add package-runner note to readme (facebook#8132) * Add package-runner note to readme * Add link to `yarn create` * Update PWA docs links to point to template package (facebook#8147) * Minor refactors in create-react-app (facebook#8178) - Remove templates version minimum stopgap. - Replace indexOf with more idiomatic alternatives. - Inline errorLogFilePatterns. - Alphabetize validFiles. - Simplify log file removal code. - Move unconditional console.log() call outside of isSafe. - Differentiate conflicting directories from files. - Document yarn version special case. - Inline printValidationResults. - Standardize checkAppName output on failure. - Add link for checkThatNpmCanReadCwd. Functionally the code should be exactly the same. * fix: proactively append to .gitignore during init (facebook#8028) * Bump babel-plugin-tester and fix breaking changes (facebook#8171) * Little typo (facebook#8212) * Replace favicon in templates (facebook#8194) The old favicon was the same as the official react documentation, which is a minor annoyance during development when trying to find the tab you want. The new favicon is just the old with inverted colors. Closes facebook#7957 * Support shorthand scoped templates (facebook#8298) * Allow additional package keys and add blacklist (facebook#8082) (facebook#8219) * Minor grammatical edit (facebook#8293) * Update Dependencies (facebook#8324) * Remove React.FC from Typescript template (facebook#8177) This removes `React.FC` from the base template for a Typescript project. Long explanation for a small change: `React.FC` is unnecessary: it provides next to no benefits and has a few downsides. (See below.) I see a lot of beginners to TS+React using it, however, and I think that it's usage in this template is a contributing factor to that, as the prominence of this template makes it a de facto source of "best practice". ### Downsides to React.FC/React.FunctionComponent ##### Provides an implicit definition of `children` Defining a component with `React.FC` causes it to implicitly take `children` (of type `ReactNode`). It means that all components accept children, even if they're not supposed to, allowing code like: ```ts const App: React.FC = () => { /*... */ }; const Example = () => { <App><div>Unwanted children</div></App> } ``` This isn't a run-time error, but it is a mistake and one that would be caught by Typescript if not for `React.FC`. ##### Doesn't support generics. I can define a generic component like: ```ts type GenericComponentProps<T> = { prop: T callback: (t: T) => void } const GenericComponent = <T>(props: GenericComponentProps<T>) => {/*...*/} ``` But it's not possible when using `React.FC` - there's no way to preserve the unresolved generic `T` in the type returned by `React.FC`. ```ts const GenericComponent: React.FC</* ??? */> = <T>(props: GenericComponentProps<T>) => {/*...*/} ``` ##### Makes "component as namespace pattern" more awkward. It's a somewhat popular pattern to use a component as a namespace for related components (usually children): ```jsx <Select> <Select.Item /> </Select> ``` This is possible, but awkward, with `React.FC`: ```tsx const Select: React.FC<SelectProps> & { Item: React.FC<ItemProps> } = (props) => {/* ... */ } Select.Item = (props) => { /*...*/ } ``` but "just works" without `React.FC`: ```tsx const Select = (props: SelectProps) => {/* ... */} Select.Item = (props) => { /*...*/ } ``` ##### Doesn't work correctly with defaultProps This is a fairly moot point as in both cases it's probably better to use ES6 default arguments, but... ```tsx type ComponentProps = { name: string; } const Component = ({ name }: ComponentProps) => (<div> {name.toUpperCase()} /* Safe since name is required */ </div>); Component.defaultProps = { name: "John" }; const Example = () => (<Component />) /* Safe to omit since name has a default value */ ``` This compiles correctly. Any approach with `React.FC` will be slightly wrong: either `React.FC<{name: string}>` will make the prop required by consumers, when it should be optional, or `React.FC<{name?: string}>` will cause `name.toUpperCase()` to be a type error. There's no way to replicate the "internally required, externally optional" behavior which is desired. ##### It's as long, or longer than the alternative: (especially longer if you use `FunctionalComponent`): Not a huge point, but it isn't even shorter to use `React.FC` ```ts const C1: React.FC<CProps> = (props) => { } const C2 = (props: CProps) => {}; ``` ### Benefits of React.FC ##### Provides an explicit return type The only benefit I really see to `React.FC` (unless you think that implicit `children` is a good thing) is that it specifies the return type, which catches mistakes like: ```ts const Component = () => { return undefined; // components aren't allowed to return undefined, just `null` } ``` In practice, I think this is fine, as it'll be caught as soon as you try to use it: ```ts const Example = () => <Component />; // Error here, due to Component returning the wrong thing ``` But even with explicit type annotations, `React.FC` still isn't saving very much boilerplate: ```ts const Component1 = (props: ComponentProps): ReactNode => { /*...*/ } const Component2: FC<ComponentProps> = (props) => { /*...*/ } ``` * Downgrade open from 7.0.0 to 6.4.0 (facebook#8364) * Remove outdated babel plugins (facebook#8353) Updates dependencies and removes babel plugins that are now covered by `@babel/preset-env`. Co-authored-by: hdineen <[email protected]> * Add titleProp to SVGR ReactComponent type definition (facebook#8099) * Sync dependencies babel config (facebook#8120) * Update custom template docs with instructions for testing custom template locally (facebook#8092) Co-authored-by: Ian Schmitz <[email protected]> * Update setting-up-your-editor.md (facebook#8247) `Auto Fix is enabled by default. Use the single string form.` warning is shown in `.vscode/settings.json` due to changes in vscode-eslint. As autoFix is set to default, object format in `eslint.validate` is deprecated. * Remove outdated docs regarding vscode eslint extension and type… (facebook#8307) Co-authored-by: Ian Schmitz <[email protected]> * Fix sass importLoaders (facebook#8281) * Add "Disallow:" to robots.txt (facebook#8255) * Add helpful message to the footer (facebook#6548) * Update docs according to lint-staged v10 (facebook#8394) * docs: Add troubleshooting documentation on ENOSPC (facebook#8380) Co-authored-by: Ian Schmitz <[email protected]> * Prepare 3.3.1 release * Publish - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] * Make the PWA link point to the right place (facebook#8379) * Update commit message to use imperative mood (facebook#8377) Why: * As per best practice: https://git.kernel.org/pub/scm/git/git.git/tree/Documentation/SubmittingPatches#n135 See also: https://chris.beams.io/posts/git-commit/#imperative * Wider Chromium support for openBrowser (facebook#8367) * Expands scope of openBrowser tab control Adjust openChrome.applescript to allow manipulation of other Chromium-based browsers (defaulting to Chrome). Requires list of compatible browsers to try in openBrowser.js * Fix typo * Remove Safari * fix(test): force install npm in e2e-behaviour (facebook#8402) This will fix e2e-behaviour on macos Related: npm/cli#611 (comment) * setupTestFrameworkScriptFile is deprecated (facebook#8390) * setupTestFrameworkScriptFile is deprecated __Note:_ `_setupTestFrameworkScriptFile_` _is deprecated in favor of_ `_setupFilesAfterEnv_`_.__ ref: https://jestjs.io/docs/en/configuration#setupfilesafterenv-array * Update docusaurus/docs/running-tests.md Co-Authored-By: Simen Bekkhus <[email protected]> Co-authored-by: Simen Bekkhus <[email protected]> * Fix robots.txt for TS (facebook#8403) * Update public folder usage docs to clarify globals (facebook#8299) Added the relevant topic linked directly, instead of saying it's just in the next section. Adjusted the text so it sounds more like a recommendation rather than a requirement. The topic linked is basically explainer to how you'd reference it using the global window object and ways to avoid linter errors. Thus I used 'reference' to give users a hint of what it the linked page would be for. * Run git init before template dependencies are installed (facebook#8282) * Support JetBrains Rider IDE as an editor (facebook#7948) Rider is JetBrains .NET IDE, which supports the React plugin identically to other JetBrains IDEs such as Idea and WebStorm. * Enable custom sockjs pathname for hot reloading server. (facebook#7750) * Enable custom sockjs pathname for hot reloading server. * Update docusaurus/docs/advanced-configuration.md Co-Authored-By: Brody McKee <[email protected]> * let WDS_SOCKET_PATH be undefined * adding env variables for sockHost and sockPort options Co-authored-by: Brody McKee <[email protected]> * Add option to provide custom ssl certificates during development (facebook#5845) * Add option to provide custom SSL certificates when using HTTPS * Update documentation with custom HTTPS certs * Improve certificate validation and move to its own file * Update https in development docs Co-Authored-By: Brody McKee <[email protected]> * Add custom cert example to docs * Rename https file and update error message * Include original error message when custom ssl cert is invalid * Add chalk to react-scripts dependencies * Bump docs version to say that the new config will be available in 3.2.0 * Remove chalk dependency * Update custom ssl version to 3.4.0 in docs * Remove version from custom ssl certificate docs Co-authored-by: Brody McKee <[email protected]> * Handle service worker error in Firefox (facebook#8272) * Handle service worker error in Firefox See https://bugzilla.mozilla.org/show_bug.cgi?id=1429714 for more details. * Update serviceWorker.js * feat(react-scripts): allow PUBLIC_URL in develoment mode (facebook#7259) Co-authored-by: Eric Clemmons <[email protected]> Co-authored-by: Alex Guerra <[email protected]> Co-authored-by: Kelly <[email protected]> Co-authored-by: Eric Clemmons <[email protected]> Co-authored-by: Alex Guerra <[email protected]> Co-authored-by: Kelly <[email protected]> * Change arrow functions to function declarations (facebook#8412) - The JavaScript template uses a function declaration to define the component, the TypeScript template and a page of the documentation used arrow functions. Changed it to use function declarations for consistency and readability. * Fix navbar line break in header (facebook#8437) * Fixes unchecked access to 'deploy' script on build (facebook#8292) * Downgrade chalk for ie 11 support (facebook#8439) * Downgrade chalk for ie 11 support * Update lockfile * fix(react-scripts): do not redirect served path if request may proxy (facebook#8442) Moved redirect middleware and noopSW middleware in WDS after hook So proxy, and before proxy will take precedence before redirect Closes facebook#8417 * fix(typescriptFormatter): use chalk@2 constructor (facebook#8450) Related facebook#8164 Related facebook#8439 * update open to v7.0.2 (facebook#8459) * Correct webpack name casing (facebook#8475) webpack should always be written in lower-case, according to webpack's branding guidelines https://webpack.js.org/branding * Downgrade style-loader to v0.23.1 due to CSS modules hot reload… (facebook#8378) * Prepare 3.4.0 release * Publish - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] * fix missing packages in react-scripts Co-authored-by: Ian Sutherland <[email protected]> Co-authored-by: Samuel Meuli <[email protected]> Co-authored-by: Lewis Llobera <[email protected]> Co-authored-by: Jake Moxey <[email protected]> Co-authored-by: Iguchi Tomokatsu <[email protected]> Co-authored-by: Federico Zivolo <[email protected]> Co-authored-by: Kent C. Dodds <[email protected]> Co-authored-by: Laurin Quast <[email protected]> Co-authored-by: neilbryson <[email protected]> Co-authored-by: Reece Dunham <[email protected]> Co-authored-by: Rakan Nimer <[email protected]> Co-authored-by: Tomer Cohen <[email protected]> Co-authored-by: Alexandr Tovmach <[email protected]> Co-authored-by: Kyle Bebak <[email protected]> Co-authored-by: André Lins <[email protected]> Co-authored-by: Kim Persson <[email protected]> Co-authored-by: Justin Grant <[email protected]> Co-authored-by: Robert van Steen <[email protected]> Co-authored-by: Ashrith Reddy <[email protected]> Co-authored-by: Jacob M-G Evans <[email protected]> Co-authored-by: Ian Schmitz <[email protected]> Co-authored-by: Damian Senn <[email protected]> Co-authored-by: Róbert FUSZENECKER <[email protected]> Co-authored-by: May <[email protected]> Co-authored-by: Orta <[email protected]> Co-authored-by: Tomáš Hübelbauer <[email protected]> Co-authored-by: Jesse Jackson <[email protected]> Co-authored-by: Jake Boone <[email protected]> Co-authored-by: Endi <[email protected]> Co-authored-by: Brody McKee <[email protected]> Co-authored-by: Hugo David-Boyet <[email protected]> Co-authored-by: Sean Lafferty <[email protected]> Co-authored-by: Ali Waseem <[email protected]> Co-authored-by: reactjser <[email protected]> Co-authored-by: Daniel Lo Nigro <[email protected]> Co-authored-by: Chun <[email protected]> Co-authored-by: Xuhao <[email protected]> Co-authored-by: Sean Baines <[email protected]> Co-authored-by: Abdul Wahab ⚡️ <[email protected]> Co-authored-by: Guillaume Hertault <[email protected]> Co-authored-by: Wataru Ashihara <[email protected]> Co-authored-by: darthmaim <[email protected]> Co-authored-by: Joshua Robinson <[email protected]> Co-authored-by: Andreas Cederström <[email protected]> Co-authored-by: Fabiano Brito <[email protected]> Co-authored-by: Kanitkorn Sujautra <[email protected]> Co-authored-by: Havit Rovik <[email protected]> Co-authored-by: Tharun Rajendran <[email protected]> Co-authored-by: Dylan Staley <[email protected]> Co-authored-by: Donavon West <[email protected]> Co-authored-by: James George <[email protected]> Co-authored-by: RJ <[email protected]> Co-authored-by: Renato Augusto Gama dos Santos <[email protected]> Co-authored-by: Mateusz Burzyński <[email protected]> Co-authored-by: Alex Guerra <[email protected]> Co-authored-by: Klas Björkqvist <[email protected]> Co-authored-by: Max Davidson <[email protected]> Co-authored-by: Ben Blank <[email protected]> Co-authored-by: Mike Caulley <[email protected]> Co-authored-by: Trontor <[email protected]> Co-authored-by: Sean Zhu <[email protected]> Co-authored-by: Simon Donaldson <[email protected]> Co-authored-by: Wojciech Zieliński <[email protected]> Co-authored-by: Vadzim <[email protected]> Co-authored-by: Jerome De Leon <[email protected]> Co-authored-by: Peet Goddard <[email protected]> Co-authored-by: Brian Muenzenmeyer <[email protected]> Co-authored-by: Sony AK <[email protected]> Co-authored-by: Kai Hao <[email protected]> Co-authored-by: Tom Valorsa <[email protected]> Co-authored-by: Evan Grim <[email protected]> Co-authored-by: Retsam <[email protected]> Co-authored-by: Vincent Semrau <[email protected]> Co-authored-by: Henry Q. Dineen <[email protected]> Co-authored-by: Rasmus Nørskov <[email protected]> Co-authored-by: Kevin Old <[email protected]> Co-authored-by: Boyuan Xu <[email protected]> Co-authored-by: Alex James Vukovity <[email protected]> Co-authored-by: Marius Craciunoiu <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]> Co-authored-by: Joshua Pollak <[email protected]> Co-authored-by: Hu Chen <[email protected]> Co-authored-by: Cassidy Williams <[email protected]> Co-authored-by: Christopher Button <[email protected]> Co-authored-by: Matthew Curtis <[email protected]> Co-authored-by: Andrew Luca <[email protected]> Co-authored-by: 吕立青 <[email protected]> Co-authored-by: Simen Bekkhus <[email protected]> Co-authored-by: Martin Litvaj <[email protected]> Co-authored-by: Kevin Pham <[email protected]> Co-authored-by: Łukasz Fiszer <[email protected]> Co-authored-by: David Powell <[email protected]> Co-authored-by: Grady Kuhnline <[email protected]> Co-authored-by: Alex Brazier <[email protected]> Co-authored-by: Rohit Singhal <[email protected]> Co-authored-by: Eric Clemmons <[email protected]> Co-authored-by: Kelly <[email protected]> Co-authored-by: Eugene Sviridov <[email protected]> Co-authored-by: Renato Böhler <[email protected]> Co-authored-by: Eugene Chybisov <[email protected]>
adammockor
added a commit
that referenced
this pull request
Mar 22, 2020
* Publish - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] * Update runtime chunk name separator in docs (#7705) * Remove 'shortcut' link type before 'icon' (#7707) * Guard polyfills against window possibly being undefined (#7205) * Enable .eslintignore with extend flag (#7562) * Add "entrypoints" key to asset manifest (#7721) * Update adding flow documentation (#7731) * set output.globalObject to 'this' (#7742) Closes #7741 * Update logic and log errors for EXTEND_ESLINT (#7530) * update list of supported jest config overrides (#7601) * Upgrade Webpack version (#7740) * Close br tags in template README files (#7668) * Fix variable name casing in fileTransform (#7752) * Documentation typo fix (#7757) * Fix linting error when using rest props (#7754) * Add TSC_COMPILE_ON_ERROR setting (#6931) * Remove switch case (#7729) * docs: note that v2 to v3 migration may require deletion of node_modules (#7302) * Stop hiding the column number of ESLint errors (#6980) * Support setting baseUrl to root directory (#7755) * Use installing package manager in README (#7687) * Support production profiling with React Developer Tools (#7737) * Added the alias for profiling and output change to keep the classNames and functionNames for human readbility * defined isEnvProductionProfile with other isEnv checks * moved the keep_classnames and keep_fnames to terserOptions scope * resolve merge conflict for yarn.lock.cache * revert yarn.lock.cache to master yarn.lock.cache - git checkout origin/master -- packages/create-react-app/yarn.lock.cached * Comment and Boolean Check - I clarified the comment and specified the use case - Changed the environment check to check for the specific true rather than the assumed primitive value as before. * Replaced env with flag - Per suggestion --profile flag used instead of env variable PROFILE_APP * documentation in available scripts section with suggested information * resolved a local git issue. Fixed documentation error. * moved documentation to suggested file - Added a brief summary of profiling in available scripts section. The summary references the production-build document. Which is the file I moved the new documentation into under a new Header for production support. * Update production-build.md Co-authored-by: Ian Sutherland <[email protected]> * Prepare 3.2.0 release * Publish - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] * Temporarily disable Windows in CI (#7773) * Add babel runtime version to transform-runtime plugin to reduce… (#7726) * Add Babel sourcemap to resolve VSCode debugging issues (#7022) * Fix process type in TypeScript template (#7796) * Account for browserslist environment variables (#7764) * Clarify dynamic import stage in docs (#7813) * Update adding-typescript.md (#7815) * Document how to use the .env file to enforce HTTPS (#7821) * Fix absolute paths issue in Jest (#7822) * Document correct default behavior for HOST var (#7823) * Fix grammar error in troubleshooting.md (#7824) * Upgrade to docusaurus 2 (#7785) * chore: upgrade to docusaurus 2 * address review * Update doc publishing instructions * Revert logo in templates (#7830) * feat: add additional Jest keys to whitelist (#7832) * Link to React documentation for code splitting (#7686) The official documentation offers a simpler way of achieving route based code splitting. * Add a note about .eslingignore files being respected (#7809) * added check for typescript template and unsupported node version (#7839) * added check for typescript template and unsupported node version * addressed code review feedback regarding syntax and spelling mistakes * Update getting-started.md (#7841) Update the initial project structure generated by create-react-app. * Link to ASP.NET Core docs (#7840) * Update readme gif links (#7849) * Update adding-bootstrap.md (#7853) typo fix * Move unused eslint webpack import into @remove-on-eject block (#7856) * 📖 DOC: Improvement (#7819) * Upgrade terser & enable parallel minification in wsl (#7857) * Add a GitHub Action that runs the build script (#7861) * Edit InterpolateHtmlPlugin hook (#6448) (#6449) * Fix notations of loopback addresses (#7474) * Add Service-Worker header to checkValidServiceWorker (#6753) * Add header to checkValidServiceWorker (ts) * Add header to checkValidServiceWorker * Add additional information for postcss errors (#6282) (#6352) * Add additional information for postcss errors * Add additional information for postcss errors (simplify) * Remove chunkname from postCSS compile error * Remove line number from postCSS compile error * Fix eslint complaints in build.js (#7870) * Add Alex to lint documentation (#7852) * Add Alex to lint documentation * Attempt to trigger GitHub Action * Configure Alex and update docs * More docs updates * Bump docusaurus 🦖 (#7874) * Dark scheme overlay (#7052) * Bump react (#7875) * Bump styling related loaders (#7876) * Remove alex precommit check (#7878) * Add template support (#7716) * Add template support * Update templates version check * Update TypeScript template README * Prepare 3.3.0 beta * If template name already starts with cra-template leave it alone (#7880) * Update prerelease publishing instructions * Upgrade packages and tweak config to adapt to new config format (#7814) Rebased again now with smaller changes in this one which will make it easier to revert in case of eventual regressions. * refactor: remove double coerce (#7882) * Add yarn.lock to .gitignore (#7789) * chore: Fix broken link for CRA deployment (#7897) * chore: Fix broken link for e2e README (#7896) * Add @testing-library to the default templates (#7881) * Add numeric separator support (#7817) * Update open (#7910) * Mark TypeScript as an optional peer dependency (#7860) * Add restoreMocks to supported jest config keys (#7921) * fix seperators typo (#7932) Its the little things that makes the big difference! 😁 Thanks * No spinning React logo if `prefers-reduced-motion` (#7931) * Made PRs welcome badge point to contributors guide (#7792) * Make JavaScript and TypeScript templates consistent (#7944) * Fix CI (#7951) * Add optional chaining and nullish coalescing operators support (#7438) * Add tests for optional chaining and null coalescing (#7952) * Upgrade jest-watch-typeahead (#7956) * Fix light background in docusaurus night mode (#7936) * Fix light background in docusaurus night mode Closes #7930 * Rename lightBackground to gettingStartedSection * Add placeholders where old template READMEs used to be (#7972) * Temporarily disable GitHub Actions (#7978) * Prepare 3.3.0 beta * Bump dependencies (#7986) * Support scoped templates (#7991) * Add contributors section to readme (#7995) * added e2e test for checking typescript template with unsupported node (#7844) * Unpin dependencies in react-app-polyfill (#7999) * Add scripts support to templates (#7989) * Override no-unused-expressions with the typescript-eslint version (#8003) Fixes issues with optional chaining * Prefix apple-touch-icon links with PUBLIC_URL. (#8005) * Bump webpack-dev-server (#7988) * Bump dependencies (#8024) * Re-enable GitHub Actions (#8029) * Update CHANGELOG * Update CODEOWNERS * Remove no-unexpected-multiline rule (#8039) * Add TypeScript peer dependency to react-scripts (#8038) * Update template docs (#8050) * Update template docs * Update custom-templates.md * Update custom-templates.md Co-authored-by: Ian Sutherland <[email protected]> * Prepare 3.3.0 release * Update CHANGELOG * Publish - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] * webpackHotDev now uses wss when https is used (#8079) * Add custom-templates to docs sidebar (#8077) * Fix typo in CHANGELOG.md (#8080) * Remove error for @typescript-eslint/no-namespace (#7803) Declare namespaces are supported by babel now, and babel will throw with a nice error message for non-declare namespaces, so this rule is unnecessary. Closes #7651. * Fix CI build (#8122) * Fix CSS font-face minification (#8106) * Add slashes to WebSocket protocol URL (#8116) * Fix typo in comment: `?.` is right, not `.?` (#8124) This is just a comment fix. Actual optional chaining operator syntax is `?.`, not `.?`. * chore: update docusaurus & tweak site (#8111) * [Security] Update terser webpack plugin (#8102) * security: update terser webpack plugin * Add current version and bin location to --info output (#8168) Make the --info subcommand outuput the current version information and the location of the file being run. Our issue template tells users to provide the output of --info, so having the current version is incredibly helpful, especially since it doesn't necessarily match the globally installed version that envinfo outputs. Knowing the location helps us determine whether the running bin is globally installed or in the local node_modules. * Bump pkgUp (#8163) * Bump chalk (#8164) * Add link to Netlify in README * Bump internal dependencies (#8176) * Bump dependencies in react-dev-utils * Bump dependencies in react-app-polyfill * Bump dependencies in create-react-app * Bump dependencies in react-error-overlay * Bump dependencies in react-scripts * Bump react * Add package-runner note to readme (#8132) * Add package-runner note to readme * Add link to `yarn create` * Update PWA docs links to point to template package (#8147) * Minor refactors in create-react-app (#8178) - Remove templates version minimum stopgap. - Replace indexOf with more idiomatic alternatives. - Inline errorLogFilePatterns. - Alphabetize validFiles. - Simplify log file removal code. - Move unconditional console.log() call outside of isSafe. - Differentiate conflicting directories from files. - Document yarn version special case. - Inline printValidationResults. - Standardize checkAppName output on failure. - Add link for checkThatNpmCanReadCwd. Functionally the code should be exactly the same. * fix: proactively append to .gitignore during init (#8028) * Bump babel-plugin-tester and fix breaking changes (#8171) * Little typo (#8212) * Replace favicon in templates (#8194) The old favicon was the same as the official react documentation, which is a minor annoyance during development when trying to find the tab you want. The new favicon is just the old with inverted colors. Closes #7957 * Support shorthand scoped templates (#8298) * Allow additional package keys and add blacklist (#8082) (#8219) * Minor grammatical edit (#8293) * Update Dependencies (#8324) * Remove React.FC from Typescript template (#8177) This removes `React.FC` from the base template for a Typescript project. Long explanation for a small change: `React.FC` is unnecessary: it provides next to no benefits and has a few downsides. (See below.) I see a lot of beginners to TS+React using it, however, and I think that it's usage in this template is a contributing factor to that, as the prominence of this template makes it a de facto source of "best practice". ### Downsides to React.FC/React.FunctionComponent ##### Provides an implicit definition of `children` Defining a component with `React.FC` causes it to implicitly take `children` (of type `ReactNode`). It means that all components accept children, even if they're not supposed to, allowing code like: ```ts const App: React.FC = () => { /*... */ }; const Example = () => { <App><div>Unwanted children</div></App> } ``` This isn't a run-time error, but it is a mistake and one that would be caught by Typescript if not for `React.FC`. ##### Doesn't support generics. I can define a generic component like: ```ts type GenericComponentProps<T> = { prop: T callback: (t: T) => void } const GenericComponent = <T>(props: GenericComponentProps<T>) => {/*...*/} ``` But it's not possible when using `React.FC` - there's no way to preserve the unresolved generic `T` in the type returned by `React.FC`. ```ts const GenericComponent: React.FC</* ??? */> = <T>(props: GenericComponentProps<T>) => {/*...*/} ``` ##### Makes "component as namespace pattern" more awkward. It's a somewhat popular pattern to use a component as a namespace for related components (usually children): ```jsx <Select> <Select.Item /> </Select> ``` This is possible, but awkward, with `React.FC`: ```tsx const Select: React.FC<SelectProps> & { Item: React.FC<ItemProps> } = (props) => {/* ... */ } Select.Item = (props) => { /*...*/ } ``` but "just works" without `React.FC`: ```tsx const Select = (props: SelectProps) => {/* ... */} Select.Item = (props) => { /*...*/ } ``` ##### Doesn't work correctly with defaultProps This is a fairly moot point as in both cases it's probably better to use ES6 default arguments, but... ```tsx type ComponentProps = { name: string; } const Component = ({ name }: ComponentProps) => (<div> {name.toUpperCase()} /* Safe since name is required */ </div>); Component.defaultProps = { name: "John" }; const Example = () => (<Component />) /* Safe to omit since name has a default value */ ``` This compiles correctly. Any approach with `React.FC` will be slightly wrong: either `React.FC<{name: string}>` will make the prop required by consumers, when it should be optional, or `React.FC<{name?: string}>` will cause `name.toUpperCase()` to be a type error. There's no way to replicate the "internally required, externally optional" behavior which is desired. ##### It's as long, or longer than the alternative: (especially longer if you use `FunctionalComponent`): Not a huge point, but it isn't even shorter to use `React.FC` ```ts const C1: React.FC<CProps> = (props) => { } const C2 = (props: CProps) => {}; ``` ### Benefits of React.FC ##### Provides an explicit return type The only benefit I really see to `React.FC` (unless you think that implicit `children` is a good thing) is that it specifies the return type, which catches mistakes like: ```ts const Component = () => { return undefined; // components aren't allowed to return undefined, just `null` } ``` In practice, I think this is fine, as it'll be caught as soon as you try to use it: ```ts const Example = () => <Component />; // Error here, due to Component returning the wrong thing ``` But even with explicit type annotations, `React.FC` still isn't saving very much boilerplate: ```ts const Component1 = (props: ComponentProps): ReactNode => { /*...*/ } const Component2: FC<ComponentProps> = (props) => { /*...*/ } ``` * Downgrade open from 7.0.0 to 6.4.0 (#8364) * Remove outdated babel plugins (#8353) Updates dependencies and removes babel plugins that are now covered by `@babel/preset-env`. Co-authored-by: hdineen <[email protected]> * Add titleProp to SVGR ReactComponent type definition (#8099) * Sync dependencies babel config (#8120) * Update custom template docs with instructions for testing custom template locally (#8092) Co-authored-by: Ian Schmitz <[email protected]> * Update setting-up-your-editor.md (#8247) `Auto Fix is enabled by default. Use the single string form.` warning is shown in `.vscode/settings.json` due to changes in vscode-eslint. As autoFix is set to default, object format in `eslint.validate` is deprecated. * Remove outdated docs regarding vscode eslint extension and type… (#8307) Co-authored-by: Ian Schmitz <[email protected]> * Fix sass importLoaders (#8281) * Add "Disallow:" to robots.txt (#8255) * Add helpful message to the footer (#6548) * Update docs according to lint-staged v10 (#8394) * docs: Add troubleshooting documentation on ENOSPC (#8380) Co-authored-by: Ian Schmitz <[email protected]> * Prepare 3.3.1 release * Publish - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] * Make the PWA link point to the right place (#8379) * Update commit message to use imperative mood (#8377) Why: * As per best practice: https://git.kernel.org/pub/scm/git/git.git/tree/Documentation/SubmittingPatches#n135 See also: https://chris.beams.io/posts/git-commit/#imperative * Wider Chromium support for openBrowser (#8367) * Expands scope of openBrowser tab control Adjust openChrome.applescript to allow manipulation of other Chromium-based browsers (defaulting to Chrome). Requires list of compatible browsers to try in openBrowser.js * Fix typo * Remove Safari * fix(test): force install npm in e2e-behaviour (#8402) This will fix e2e-behaviour on macos Related: https://github.com/npm/cli/issues/611#issuecomment-575287540 * setupTestFrameworkScriptFile is deprecated (#8390) * setupTestFrameworkScriptFile is deprecated __Note:_ `_setupTestFrameworkScriptFile_` _is deprecated in favor of_ `_setupFilesAfterEnv_`_.__ ref: https://jestjs.io/docs/en/configuration#setupfilesafterenv-array * Update docusaurus/docs/running-tests.md Co-Authored-By: Simen Bekkhus <[email protected]> Co-authored-by: Simen Bekkhus <[email protected]> * Fix robots.txt for TS (#8403) * Update public folder usage docs to clarify globals (#8299) Added the relevant topic linked directly, instead of saying it's just in the next section. Adjusted the text so it sounds more like a recommendation rather than a requirement. The topic linked is basically explainer to how you'd reference it using the global window object and ways to avoid linter errors. Thus I used 'reference' to give users a hint of what it the linked page would be for. * Run git init before template dependencies are installed (#8282) * Support JetBrains Rider IDE as an editor (#7948) Rider is JetBrains .NET IDE, which supports the React plugin identically to other JetBrains IDEs such as Idea and WebStorm. * Enable custom sockjs pathname for hot reloading server. (#7750) * Enable custom sockjs pathname for hot reloading server. * Update docusaurus/docs/advanced-configuration.md Co-Authored-By: Brody McKee <[email protected]> * let WDS_SOCKET_PATH be undefined * adding env variables for sockHost and sockPort options Co-authored-by: Brody McKee <[email protected]> * Add option to provide custom ssl certificates during development (#5845) * Add option to provide custom SSL certificates when using HTTPS * Update documentation with custom HTTPS certs * Improve certificate validation and move to its own file * Update https in development docs Co-Authored-By: Brody McKee <[email protected]> * Add custom cert example to docs * Rename https file and update error message * Include original error message when custom ssl cert is invalid * Add chalk to react-scripts dependencies * Bump docs version to say that the new config will be available in 3.2.0 * Remove chalk dependency * Update custom ssl version to 3.4.0 in docs * Remove version from custom ssl certificate docs Co-authored-by: Brody McKee <[email protected]> * Handle service worker error in Firefox (#8272) * Handle service worker error in Firefox See https://bugzilla.mozilla.org/show_bug.cgi?id=1429714 for more details. * Update serviceWorker.js * feat(react-scripts): allow PUBLIC_URL in develoment mode (#7259) Co-authored-by: Eric Clemmons <[email protected]> Co-authored-by: Alex Guerra <[email protected]> Co-authored-by: Kelly <[email protected]> Co-authored-by: Eric Clemmons <[email protected]> Co-authored-by: Alex Guerra <[email protected]> Co-authored-by: Kelly <[email protected]> * Change arrow functions to function declarations (#8412) - The JavaScript template uses a function declaration to define the component, the TypeScript template and a page of the documentation used arrow functions. Changed it to use function declarations for consistency and readability. * Fix navbar line break in header (#8437) * Fixes unchecked access to 'deploy' script on build (#8292) * Downgrade chalk for ie 11 support (#8439) * Downgrade chalk for ie 11 support * Update lockfile * fix(react-scripts): do not redirect served path if request may proxy (#8442) Moved redirect middleware and noopSW middleware in WDS after hook So proxy, and before proxy will take precedence before redirect Closes #8417 * fix(typescriptFormatter): use chalk@2 constructor (#8450) Related #8164 Related #8439 * update open to v7.0.2 (#8459) * Correct webpack name casing (#8475) webpack should always be written in lower-case, according to webpack's branding guidelines https://webpack.js.org/branding * Downgrade style-loader to v0.23.1 due to CSS modules hot reload… (#8378) * Prepare 3.4.0 release * Publish - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] * fix missing packages in react-scripts * Bump pnp-webpack-plugin (#8509) * Closes webpack dev server and exits process on "end" stdin (#7203) Co-authored-by: Ian Schmitz <[email protected]> * Widen eslint-config-react-app peer dependency versions (#7790) Co-authored-by: Ian Schmitz <[email protected]> * Fix optional chaining and nullish coalescing support (#8526) * Update template example in docs (#8561) * Whitelist main in template.json (#8539) * Use native ESLint behaviour when extending (#8276) * Fix proxying API request docs (#8515) The http-proxy-middleware package has made a major version upgraded and introduced a breaking change. This fixes the "Configuring the Proxy Manually" documentation to match the latest version. * Bump dependencies (#8620) * Add React.StrictMode to default templates (#8558) Co-authored-by: Dan Abramov <[email protected]> * Update to Babel 7.9 (#8681) * Prepare 3.4.1 release * Publish - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] * Squashed commit of the following: commit 6d7c56e41a0909fb6213e1f4ccb67ff1020ed531 Author: Adam Močkoř <[email protected]> Date: Thu Mar 19 21:31:31 2020 +0100 Release/3.5.2 (#215) * update version * update changelog commit ec31f7866519f597bed91520537df8097ec7fd40 Author: Adam Močkoř <[email protected]> Date: Thu Mar 19 21:22:17 2020 +0100 Fix/typescript support (#214) * fix extensions in paths (and cleanup) * fix paths to allow ts and tsx extensions * get rid of webpack multicompiler mulicompiler was not compatible with TS error handling in CRA commit d0bef656c85e97158735267dc9c711f5ed3bac15 Author: Adam Močkoř <[email protected]> Date: Wed Mar 11 18:04:26 2020 +0100 Release/3.5.1 (#213) * update changelog * update version commit 73e2144285ccb543066d1ed46e154c270c94eebc Author: Milan Lajtoš <[email protected]> Date: Wed Mar 11 17:29:35 2020 +0100 Add postcss-inline-svg (#212) Lighter 2.x had `postcss-inline-svg`, but in 3.0 it was missing. It broke DDS. It provides `svg-load` function that inlines SVG into data-uri. commit 7870f5cb45ad54e2042a494881f0b7dc055db971 Merge: 0e9a282a cb4f9ac6 Author: jurajk <[email protected]> Date: Wed Mar 4 11:20:13 2020 +0100 Merge pull request #211 from lightingbeetle/release/3.5.3 Release/3.5.3 commit cb4f9ac6404a88d01c9a59ae3c0b5986d2819810 Author: jurajk <[email protected]> Date: Wed Mar 4 11:17:00 2020 +0100 bump version commit 6abe577fec679cfd52b2cb27f0213748c9b551dd Author: jurajk <[email protected]> Date: Wed Mar 4 11:16:45 2020 +0100 write changelog commit 0e9a282a3000139e5be5a62e7d6f72e0f344279a Merge: bd632aea bc5e23d5 Author: jurajk <[email protected]> Date: Wed Mar 4 10:47:28 2020 +0100 Merge pull request #210 from lightingbeetle/fix/mdx-language prevent error when no mdx language is defined commit bd632aea2c208ee8793ba073aa59b9c959ff5a57 Merge: 1f19f898 d177dde0 Author: jurajk <[email protected]> Date: Wed Mar 4 10:47:17 2020 +0100 Merge pull request #209 from lightingbeetle/fix/preview-html Fix/preview html commit bc5e23d5626f098279f567a71e3b018f6a0ea351 Author: jurajk <[email protected]> Date: Wed Mar 4 10:39:20 2020 +0100 use optional chaining to assign language commit d177dde0966525d469d1272bc09c467614f8d0c2 Author: jurajk <[email protected]> Date: Tue Mar 3 16:54:03 2020 +0100 add test commit 2050bf85593c468e4c11a4a37e9ddc9753627d95 Author: jurajk <[email protected]> Date: Tue Mar 3 16:53:39 2020 +0100 prevent html code example from crashing when children is array commit 0c9bb29bcc681a643e4181a53d21b3d734ffd7fe Merge: 1f19f898 15758b3e Author: jurajk <[email protected]> Date: Tue Mar 3 16:45:57 2020 +0100 Merge branch 'fix/mdx-language' into fix/preview-html commit 15758b3e7f88de9952446837872621470c68dfeb Author: jurajk <[email protected]> Date: Tue Mar 3 10:55:53 2020 +0100 prevent error when no mdx language is defined commit 1f19f89834990368bdb85fb0d2dbb5f9589e0cc8 Merge: d373778a bfb53ec6 Author: jurajk <[email protected]> Date: Tue Mar 3 10:46:37 2020 +0100 Merge pull request #208 from lightingbeetle/release/3.5.2 Release/3.5.2 commit bfb53ec6caf7dd9c5e10b7d832344f06a321bb10 Author: jurajk <[email protected]> Date: Tue Mar 3 10:42:53 2020 +0100 bump versions commit d712b74eff6e63c76be27755a43c11e478f0efce Author: jurajk <[email protected]> Date: Tue Mar 3 10:42:37 2020 +0100 write changelog commit d373778a75aef4ddfece3f908536e971a7016f1b Merge: 690e6863 5b62bf8d Author: jurajk <[email protected]> Date: Tue Mar 3 10:14:55 2020 +0100 Merge pull request #207 from lightingbeetle/release/3.5.1 Release/3.5.1 commit 5b62bf8d4a92c69b55cdf0479bc3e1b8a64f426a Author: jurajk <[email protected]> Date: Tue Mar 3 10:11:28 2020 +0100 fix typo commit 7ebb8a24199d90122d61bd9f482d52b0365b26b1 Author: jurajk <[email protected]> Date: Tue Mar 3 10:08:54 2020 +0100 write changelog commit 1b621024d13f6ad8622e604eae4d35a229f1977e Author: jurajk <[email protected]> Date: Tue Mar 3 10:08:46 2020 +0100 bump versions commit 690e6863b69b2650858b395de5cd3f1644acb7ce Author: jurajk <[email protected]> Date: Tue Mar 3 09:50:52 2020 +0100 Fix/syntax highlighting (#206) * fix theme * pass language from MDX to CodeBlock * update mdx-js * update styleguide react-scripts * add package-lock * fix overflowing container * update theme colors * prevent theme from falling to first html element in preview commit d0704de66fd9af0c955545d79acca73e369a3102 Author: Adam Močkoř <[email protected]> Date: Wed Feb 19 18:42:33 2020 +0100 Release/3.5.0 (#205) * update changelog * update versions commit 102411c2866d6c400dbc60a776779e33c6235da4 Author: Adam Močkoř <[email protected]> Date: Wed Feb 19 18:30:28 2020 +0100 Feat/cra update (#204) * Publish - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] * Update runtime chunk name separator in docs (#7705) * Remove 'shortcut' link type before 'icon' (#7707) * Guard polyfills against window possibly being undefined (#7205) * Enable .eslintignore with extend flag (#7562) * Add "entrypoints" key to asset manifest (#7721) * Update adding flow documentation (#7731) * set output.globalObject to 'this' (#7742) Closes #7741 * Update logic and log errors for EXTEND_ESLINT (#7530) * update list of supported jest config overrides (#7601) * Upgrade Webpack version (#7740) * Close br tags in template README files (#7668) * Fix variable name casing in fileTransform (#7752) * Documentation typo fix (#7757) * Fix linting error when using rest props (#7754) * Add TSC_COMPILE_ON_ERROR setting (#6931) * Remove switch case (#7729) * docs: note that v2 to v3 migration may require deletion of node_modules (#7302) * Stop hiding the column number of ESLint errors (#6980) * Support setting baseUrl to root directory (#7755) * Use installing package manager in README (#7687) * Support production profiling with React Developer Tools (#7737) * Added the alias for profiling and output change to keep the classNames and functionNames for human readbility * defined isEnvProductionProfile with other isEnv checks * moved the keep_classnames and keep_fnames to terserOptions scope * resolve merge conflict for yarn.lock.cache * revert yarn.lock.cache to master yarn.lock.cache - git checkout origin/master -- packages/create-react-app/yarn.lock.cached * Comment and Boolean Check - I clarified the comment and specified the use case - Changed the environment check to check for the specific true rather than the assumed primitive value as before. * Replaced env with flag - Per suggestion --profile flag used instead of env variable PROFILE_APP * documentation in available scripts section with suggested information * resolved a local git issue. Fixed documentation error. * moved documentation to suggested file - Added a brief summary of profiling in available scripts section. The summary references the production-build document. Which is the file I moved the new documentation into under a new Header for production support. * Update production-build.md Co-authored-by: Ian Sutherland <[email protected]> * Prepare 3.2.0 release * Publish - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] * Temporarily disable Windows in CI (#7773) * Add babel runtime version to transform-runtime plugin to reduce… (#7726) * Add Babel sourcemap to resolve VSCode debugging issues (#7022) * Fix process type in TypeScript template (#7796) * Account for browserslist environment variables (#7764) * Clarify dynamic import stage in docs (#7813) * Update adding-typescript.md (#7815) * Document how to use the .env file to enforce HTTPS (#7821) * Fix absolute paths issue in Jest (#7822) * Document correct default behavior for HOST var (#7823) * Fix grammar error in troubleshooting.md (#7824) * Upgrade to docusaurus 2 (#7785) * chore: upgrade to docusaurus 2 * address review * Update doc publishing instructions * Revert logo in templates (#7830) * feat: add additional Jest keys to whitelist (#7832) * Link to React documentation for code splitting (#7686) The official documentation offers a simpler way of achieving route based code splitting. * Add a note about .eslingignore files being respected (#7809) * added check for typescript template and unsupported node version (#7839) * added check for typescript template and unsupported node version * addressed code review feedback regarding syntax and spelling mistakes * Update getting-started.md (#7841) Update the initial project structure generated by create-react-app. * Link to ASP.NET Core docs (#7840) * Update readme gif links (#7849) * Update adding-bootstrap.md (#7853) typo fix * Move unused eslint webpack import into @remove-on-eject block (#7856) * 📖 DOC: Improvement (#7819) * Upgrade terser & enable parallel minification in wsl (#7857) * Add a GitHub Action that runs the build script (#7861) * Edit InterpolateHtmlPlugin hook (#6448) (#6449) * Fix notations of loopback addresses (#7474) * Add Service-Worker header to checkValidServiceWorker (#6753) * Add header to checkValidServiceWorker (ts) * Add header to checkValidServiceWorker * Add additional information for postcss errors (#6282) (#6352) * Add additional information for postcss errors * Add additional information for postcss errors (simplify) * Remove chunkname from postCSS compile error * Remove line number from postCSS compile error * Fix eslint complaints in build.js (#7870) * Add Alex to lint documentation (#7852) * Add Alex to lint documentation * Attempt to trigger GitHub Action * Configure Alex and update docs * More docs updates * Bump docusaurus 🦖 (#7874) * Dark scheme overlay (#7052) * Bump react (#7875) * Bump styling related loaders (#7876) * Remove alex precommit check (#7878) * Add template support (#7716) * Add template support * Update templates version check * Update TypeScript template README * Prepare 3.3.0 beta * If template name already starts with cra-template leave it alone (#7880) * Update prerelease publishing instructions * Upgrade packages and tweak config to adapt to new config format (#7814) Rebased again now with smaller changes in this one which will make it easier to revert in case of eventual regressions. * refactor: remove double coerce (#7882) * Add yarn.lock to .gitignore (#7789) * chore: Fix broken link for CRA deployment (#7897) * chore: Fix broken link for e2e README (#7896) * Add @testing-library to the default templates (#7881) * Add numeric separator support (#7817) * Update open (#7910) * Mark TypeScript as an optional peer dependency (#7860) * Add restoreMocks to supported jest config keys (#7921) * fix seperators typo (#7932) Its the little things that makes the big difference! 😁 Thanks * No spinning React logo if `prefers-reduced-motion` (#7931) * Made PRs welcome badge point to contributors guide (#7792) * Make JavaScript and TypeScript templates consistent (#7944) * Fix CI (#7951) * Add optional chaining and nullish coalescing operators support (#7438) * Add tests for optional chaining and null coalescing (#7952) * Upgrade jest-watch-typeahead (#7956) * Fix light background in docusaurus night mode (#7936) * Fix light background in docusaurus night mode Closes #7930 * Rename lightBackground to gettingStartedSection * Add placeholders where old template READMEs used to be (#7972) * Temporarily disable GitHub Actions (#7978) * Prepare 3.3.0 beta * Bump dependencies (#7986) * Support scoped templates (#7991) * Add contributors section to readme (#7995) * added e2e test for checking typescript template with unsupported node (#7844) * Unpin dependencies in react-app-polyfill (#7999) * Add scripts support to templates (#7989) * Override no-unused-expressions with the typescript-eslint version (#8003) Fixes issues with optional chaining * Prefix apple-touch-icon links with PUBLIC_URL. (#8005) * Bump webpack-dev-server (#7988) * Bump dependencies (#8024) * Re-enable GitHub Actions (#8029) * Update CHANGELOG * Update CODEOWNERS * Remove no-unexpected-multiline rule (#8039) * Add TypeScript peer dependency to react-scripts (#8038) * Update template docs (#8050) * Update template docs * Update custom-templates.md * Update custom-templates.md Co-authored-by: Ian Sutherland <[email protected]> * Prepare 3.3.0 release * Update CHANGELOG * Publish - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] * webpackHotDev now uses wss when https is used (#8079) * Add custom-templates to docs sidebar (#8077) * Fix typo in CHANGELOG.md (#8080) * Remove error for @typescript-eslint/no-namespace (#7803) Declare namespaces are supported by babel now, and babel will throw with a nice error message for non-declare namespaces, so this rule is unnecessary. Closes #7651. * Fix CI build (#8122) * Fix CSS font-face minification (#8106) * Add slashes to WebSocket protocol URL (#8116) * Fix typo in comment: `?.` is right, not `.?` (#8124) This is just a comment fix. Actual optional chaining operator syntax is `?.`, not `.?`. * chore: update docusaurus & tweak site (#8111) * [Security] Update terser webpack plugin (#8102) * security: update terser webpack plugin * Add current version and bin location to --info output (#8168) Make the --info subcommand outuput the current version information and the location of the file being run. Our issue template tells users to provide the output of --info, so having the current version is incredibly helpful, especially since it doesn't necessarily match the globally installed version that envinfo outputs. Knowing the location helps us determine whether the running bin is globally installed or in the local node_modules. * Bump pkgUp (#8163) * Bump chalk (#8164) * Add link to Netlify in README * Bump internal dependencies (#8176) * Bump dependencies in react-dev-utils * Bump dependencies in react-app-polyfill * Bump dependencies in create-react-app * Bump dependencies in react-error-overlay * Bump dependencies in react-scripts * Bump react * Add package-runner note to readme (#8132) * Add package-runner note to readme * Add link to `yarn create` * Update PWA docs links to point to template package (#8147) * Minor refactors in create-react-app (#8178) - Remove templates version minimum stopgap. - Replace indexOf with more idiomatic alternatives. - Inline errorLogFilePatterns. - Alphabetize validFiles. - Simplify log file removal code. - Move unconditional console.log() call outside of isSafe. - Differentiate conflicting directories from files. - Document yarn version special case. - Inline printValidationResults. - Standardize checkAppName output on failure. - Add link for checkThatNpmCanReadCwd. Functionally the code should be exactly the same. * fix: proactively append to .gitignore during init (#8028) * Bump babel-plugin-tester and fix breaking changes (#8171) * Little typo (#8212) * Replace favicon in templates (#8194) The old favicon was the same as the official react documentation, which is a minor annoyance during development when trying to find the tab you want. The new favicon is just the old with inverted colors. Closes #7957 * Support shorthand scoped templates (#8298) * Allow additional package keys and add blacklist (#8082) (#8219) * Minor grammatical edit (#8293) * Update Dependencies (#8324) * Remove React.FC from Typescript template (#8177) This removes `React.FC` from the base template for a Typescript project. Long explanation for a small change: `React.FC` is unnecessary: it provides next to no benefits and has a few downsides. (See below.) I see a lot of beginners to TS+React using it, however, and I think that it's usage in this template is a contributing factor to that, as the prominence of this template makes it a de facto source of "best practice". ### Downsides to React.FC/React.FunctionComponent ##### Provides an implicit definition of `children` Defining a component with `React.FC` causes it to implicitly take `children` (of type `ReactNode`). It means that all components accept children, even if they're not supposed to, allowing code like: ```ts const App: React.FC = () => { /*... */ }; const Example = () => { <App><div>Unwanted children</div></App> } ``` This isn't a run-time error, but it is a mistake and one that would be caught by Typescript if not for `React.FC`. ##### Doesn't support generics. I can define a generic component like: ```ts type GenericComponentProps<T> = { prop: T callback: (t: T) => void } const GenericComponent = <T>(props: GenericComponentProps<T>) => {/*...*/} ``` But it's not possible when using `React.FC` - there's no way to preserve the unresolved generic `T` in the type returned by `React.FC`. ```ts const GenericComponent: React.FC</* ??? */> = <T>(props: GenericComponentProps<T>) => {/*...*/} ``` ##### Makes "component as namespace pattern" more awkward. It's a somewhat popular pattern to use a component as a namespace for related components (usually children): ```jsx <Select> <Select.Item /> </Select> ``` This is possible, but awkward, with `React.FC`: ```tsx const Select: React.FC<SelectProps> & { Item: React.FC<ItemProps> } = (props) => {/* ... */ } Select.Item = (props) => { /*...*/ } ``` but "just works" without `React.FC`: ```tsx const Select = (props: SelectProps) => {/* ... */} Select.Item = (props) => { /*...*/ } ``` ##### Doesn't work correctly with defaultProps This is a fairly moot point as in both cases it's probably better to use ES6 default arguments, but... ```tsx type ComponentProps = { name: string; } const Component = ({ name }: ComponentProps) => (<div> {name.toUpperCase()} /* Safe since name is required */ </div>); Component.defaultProps = { name: "John" }; const Example = () => (<Component />) /* Safe to omit since name has a default value */ ``` This compiles correctly. Any approach with `React.FC` will be slightly wrong: either `React.FC<{name: string}>` will make the prop required by consumers, when it should be optional, or `React.FC<{name?: string}>` will cause `name.toUpperCase()` to be a type error. There's no way to replicate the "internally required, externally optional" behavior which is desired. ##### It's as long, or longer than the alternative: (especially longer if you use `FunctionalComponent`): Not a huge point, but it isn't even shorter to use `React.FC` ```ts const C1: React.FC<CProps> = (props) => { } const C2 = (props: CProps) => {}; ``` ### Benefits of React.FC ##### Provides an explicit return type The only benefit I really see to `React.FC` (unless you think that implicit `children` is a good thing) is that it specifies the return type, which catches mistakes like: ```ts const Component = () => { return undefined; // components aren't allowed to return undefined, just `null` } ``` In practice, I think this is fine, as it'll be caught as soon as you try to use it: ```ts const Example = () => <Component />; // Error here, due to Component returning the wrong thing ``` But even with explicit type annotations, `React.FC` still isn't saving very much boilerplate: ```ts const Component1 = (props: ComponentProps): ReactNode => { /*...*/ } const Component2: FC<ComponentProps> = (props) => { /*...*/ } ``` * Downgrade open from 7.0.0 to 6.4.0 (#8364) * Remove outdated babel plugins (#8353) Updates dependencies and removes babel plugins that are now covered by `@babel/preset-env`. Co-authored-by: hdineen <[email protected]> * Add titleProp to SVGR ReactComponent type definition (#8099) * Sync dependencies babel config (#8120) * Update custom template docs with instructions for testing custom template locally (#8092) Co-authored-by: Ian Schmitz <[email protected]> * Update setting-up-your-editor.md (#8247) `Auto Fix is enabled by default. Use the single string form.` warning is shown in `.vscode/settings.json` due to changes in vscode-eslint. As autoFix is set to default, object format in `eslint.validate` is deprecated. * Remove outdated docs regarding vscode eslint extension and type… (#8307) Co-authored-by: Ian Schmitz <[email protected]> * Fix sass importLoaders (#8281) * Add "Disallow:" to robots.txt (#8255) * Add helpful message to the footer (#6548) * Update docs according to lint-staged v10 (#8394) * docs: Add troubleshooting documentation on ENOSPC (#8380) Co-authored-by: Ian Schmitz <[email protected]> * Prepare 3.3.1 release * Publish - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] * Make the PWA link point to the right place (#8379) * Update commit message to use imperative mood (#8377) Why: * As per best practice: https://git.kernel.org/pub/scm/git/git.git/tree/Documentation/SubmittingPatches#n135 See also: https://chris.beams.io/posts/git-commit/#imperative * Wider Chromium support for openBrowser (#8367) * Expands scope of openBrowser tab control Adjust openChrome.applescript to allow manipulation of other Chromium-based browsers (defaulting to Chrome). Requires list of compatible browsers to try in openBrowser.js * Fix typo * Remove Safari * fix(test): force install npm in e2e-behaviour (#8402) This will fix e2e-behaviour on macos Related: https://github.com/npm/cli/issues/611#issuecomment-575287540 * setupTestFrameworkScriptFile is deprecated (#8390) * setupTestFrameworkScriptFile is deprecated __Note:_ `_setupTestFrameworkScriptFile_` _is deprecated in favor of_ `_setupFilesAfterEnv_`_.__ ref: https://jestjs.io/docs/en/configuration#setupfilesafterenv-array * Update docusaurus/docs/running-tests.md Co-Authored-By: Simen Bekkhus <[email protected]> Co-authored-by: Simen Bekkhus <[email protected]> * Fix robots.txt for TS (#8403) * Update public folder usage docs to clarify globals (#8299) Added the relevant topic linked directly, instead of saying it's just in the next section. Adjusted the text so it sounds more like a recommendation rather than a requirement. The topic linked is basically explainer to how you'd reference it using the global window object and ways to avoid linter errors. Thus I used 'reference' to give users a hint of what it the linked page would be for. * Run git init before template dependencies are installed (#8282) * Support JetBrains Rider IDE as an editor (#7948) Rider is JetBrains .NET IDE, which supports the React plugin identically to other JetBrains IDEs such as Idea and WebStorm. * Enable custom sockjs pathname for hot reloading server. (#7750) * Enable custom sockjs pathname for hot reloading server. * Update docusaurus/docs/advanced-configuration.md Co-Authored-By: Brody McKee <[email protected]> * let WDS_SOCKET_PATH be undefined * adding env variables for sockHost and sockPort options Co-authored-by: Brody McKee <[email protected]> * Add option to provide custom ssl certificates during development (#5845) * Add option to provide custom SSL certificates when using HTTPS * Update documentation with custom HTTPS certs * Improve certificate validation and move to its own file * Update https in development docs Co-Authored-By: Brody McKee <[email protected]> * Add custom cert example to docs * Rename https file and update error message * Include original error message when custom ssl cert is invalid * Add chalk to react-scripts dependencies * Bump docs version to say that the new config will be available in 3.2.0 * Remove chalk dependency * Update custom ssl version to 3.4.0 in docs * Remove version from custom ssl certificate docs Co-authored-by: Brody McKee <[email protected]> * Handle service worker error in Firefox (#8272) * Handle service worker error in Firefox See https://bugzilla.mozilla.org/show_bug.cgi?id=1429714 for more details. * Update serviceWorker.js * feat(react-scripts): allow PUBLIC_URL in develoment mode (#7259) Co-authored-by: Eric Clemmons <[email protected]> Co-authored-by: Alex Guerra <[email protected]> Co-authored-by: Kelly <[email protected]> Co-authored-by: Eric Clemmons <[email protected]> Co-authored-by: Alex Guerra <[email protected]> Co-authored-by: Kelly <[email protected]> * Change arrow functions to function declarations (#8412) - The JavaScript template uses a function declaration to define the component, the TypeScript template and a page of the documentation used arrow functions. Changed it to use function declarations for consistency and readability. * Fix navbar line break in header (#8437) * Fixes unchecked access to 'deploy' script on build (#8292) * Downgrade chalk for ie 11 support (#8439) * Downgrade chalk for ie 11 support * Update lockfile * fix(react-scripts): do not redirect served path if request may proxy (#8442) Moved redirect middleware and noopSW middleware in WDS after hook So proxy, and before proxy will take precedence before redirect Closes #8417 * fix(typescriptFormatter): use chalk@2 constructor (#8450) Related #8164 Related #8439 * update open to v7.0.2 (#8459) * Correct webpack name casing (#8475) webpack should always be written in lower-case, according to webpack's branding guidelines https://webpack.js.org/branding * Downgrade style-loader to v0.23.1 due to CSS modules hot reload… (#8378) * Prepare 3.4.0 release * Publish - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] * fix missing packages in react-scripts Co-authored-by: Ian Sutherland <[email protected]> Co-authored-by: Samuel Meuli <[email protected]> Co-authored-by: Lewis Llobera <[email protected]> Co-authored-by: Jake Moxey <[email protected]> Co-authored-by: Iguchi Tomokatsu <[email protected]> Co-authored-by: Federico Zivolo <[email protected]> Co-authored-by: Kent C. Dodds <[email protected]> Co-authored-by: Laurin Quast <[email protected]> Co-authored-by: neilbryson <[email protected]> Co-authored-by: Reece Dunham <[email protected]> Co-authored-by: Rakan Nimer <[email protected]> Co-authored-by: Tomer Cohen <[email protected]> Co-authored-by: Alexandr Tovmach <[email protected]> Co-authored-by: Kyle Bebak <[email protected]> Co-authored-by: André Lins <[email protected]> Co-authored-by: Kim Persson <[email protected]> Co-authored-by: Justin Grant <[email protected]> Co-authored-by: Robert van Steen <[email protected]> Co-authored-by: Ashrith Reddy <[email protected]> Co-authored-by: Jacob M-G Evans <[email protected]> Co-authored-by: Ian Schmitz <[email protected]> Co-authored-by: Damian Senn <[email protected]> Co-authored-by: Róbert FUSZENECKER <[email protected]> Co-authored-by: May <[email protected]> Co-authored-by: Orta <[email protected]> Co-authored-by: Tomáš Hübelbauer <[email protected]> Co-authored-by: Jesse Jackson <[email protected]> Co-authored-by: Jake Boone <[email protected]> Co-authored-by: Endi <[email protected]> Co-authored-by: Brody McKee <[email protected]> Co-authored-by: Hugo David-Boyet <[email protected]> Co-authored-by: Sean Lafferty <[email protected]> Co-authored-by: Ali Waseem <[email protected]> Co-authored-by: reactjser <[email protected]> Co-authored-by: Daniel Lo Nigro <[email protected]> Co-authored-by: Chun <[email protected]> Co-authored-by: Xuhao <[email protected]> Co-authored-by: Sean Baines <[email protected]> Co-authored-by: Abdul Wahab ⚡️ <[email protected]> Co-authored-by: Guillaume Hertault <[email protected]> Co-authored-by: Wataru Ashihara <[email protected]> Co-authored-by: darthmaim <[email protected]> Co-authored-by: Joshua Robinson <[email protected]> Co-authored-by: Andreas Cederström <[email protected]> Co-authored-by: Fabiano Brito <[email protected]> Co-authored-by: Kanitkorn Sujautra <[email protected]> Co-authored-by: Havit Rovik <[email protected]> Co-authored-by: Tharun Rajendran <[email protected]> Co-authored-by: Dylan Staley <[email protected]> Co-authored-by: Donavon West <[email protected]> Co-authored-by: James George <[email protected]> Co-authored-by: RJ <[email protected]> Co-authored-by: Renato Augusto Gama dos Santos <[email protected]> Co-authored-by: Mateusz Burzyński <[email protected]> Co-authored-by: Alex Guerra <[email protected]> Co-authored-by: Klas Björkqvist <[email protected]> Co-authored-by: Max Davidson <[email protected]> Co-authored-by: Ben Blank <[email protected]> Co-authored-by: Mike Caulley <[email protected]> Co-authored-by: Trontor <[email protected]> Co-authored-by: Sean Zhu <[email protected]> Co-authored-by: Simon Donaldson <[email protected]> Co-authored-by: Wojciech Zieliński <[email protected]> Co-authored-by: Vadzim <[email protected]> Co-authored-by: Jerome De Leon <[email protected]> Co-authored-by: Peet Goddard <[email protected]> Co-authored-by: Brian Muenzenmeyer <[email protected]> Co-authored-by: Sony AK <[email protected]> Co-authored-by: Kai Hao <[email protected]> Co-authored-by: Tom Valorsa <[email protected]> Co-authored-by: Evan Grim <[email protected]> Co-authored-by: Retsam <[email protected]> Co-authored-by: Vincent Semrau <[email protected]> Co-authored-by: Henry Q. Dineen <[email protected]> Co-authored-by: Rasmus Nørskov <[email protected]> Co-authored-by: Kevin Old <[email protected]> Co-authored-by: Boyuan Xu <[email protected]> Co-authored-by: Alex James Vukovity <[email protected]> Co-authored-by: Marius Craciunoiu <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]> Co-authored-by: Joshua Pollak <[email protected]> Co-authored-by: Hu Chen <[email protected]> Co-authored-by: Cassidy Williams <[email protected]> Co-authored-by: Christopher Button <[email protected]> Co-authored-by: Matthew Curtis <[email protected]> Co-authored-by: Andrew Luca <[email protected]> Co-authored-by: 吕立青 <[email protected]> Co-authored-by: Simen Bekkhus <[email protected]> Co-authored-by: Martin Litvaj <[email protected]> Co-authored-by: Kevin Pham <[email protected]> Co-authored-by: Łukasz Fiszer <[email protected]> Co-authored-by: David Powell <[email protected]> Co-authored-by: Grady Kuhnline <[email protected]> Co-authored-by: Alex Brazier <[email protected]> Co-authored-by: Rohit Singhal <[email protected]> Co-authored-by: Eric Clemmons <[email protected]> Co-authored-by: Kelly <[email protected]> Co-authored-by: Eugene Sviridov <[email protected]> Co-authored-by: Renato Böhler <[email protected]> Co-authored-by: Eugene Chybisov <[email protected]> * update archaic @babel/preset-env are we even using this? no reference found in code... * add changeset * update changeset * update styleguide package.json Co-authored-by: Adam Mockor <[email protected]> Co-authored-by: Ian Sutherland <[email protected]> Co-authored-by: Samuel Meuli <[email protected]> Co-authored-by: Lewis Llobera <[email protected]> Co-authored-by: Jake Moxey <[email protected]> Co-authored-by: Iguchi Tomokatsu <[email protected]> Co-authored-by: Samuel Meuli <[email protected]> Co-authored-by: Federico Zivolo <[email protected]> Co-authored-by: Kent C. Dodds <[email protected]> Co-authored-by: Laurin Quast <[email protected]> Co-authored-by: neilbryson <[email protected]> Co-authored-by: Reece Dunham <[email protected]> Co-authored-by: Rakan Nimer <[email protected]> Co-authored-by: Tomer Cohen <[email protected]> Co-authored-by: Alexandr Tovmach <[email protected]> Co-authored-by: Kyle Bebak <[email protected]> Co-authored-by: André Lins <[email protected]> Co-authored-by: Kim Persson <[email protected]> Co-authored-by: Justin Grant <[email protected]> Co-authored-by: Robert van Steen <[email protected]> Co-authored-by: Ashrith Reddy <[email protected]> Co-authored-by: Jacob M-G Evans <[email protected]> Co-authored-by: Ian Schmitz <[email protected]> Co-authored-by: Damian Senn <[email protected]> Co-authored-by: Robert FUSZENECKER <[email protected]> Co-authored-by: Jonathan Felchlin <[email protected]> Co-authored-by: May <[email protected]> Co-authored-by: Orta <[email protected]> Co-authored-by: Tomáš Hübelbauer <[email protected]> Co-authored-by: Jesse Jackson <[email protected]> Co-authored-by: Jake Boone <[email protected]> Co-authored-by: Endi <[email protected]> Co-authored-by: Brody McKee <[email protected]> Co-authored-by: Hugo David-Boyet <[email protected]> Co-authored-by: Sean Lafferty <[email protected]> Co-authored-by: Ali Waseem <[email protected]> Co-authored-by: reactjser <[email protected]> Co-authored-by: Daniel Lo Nigro <[email protected]> Co-authored-by: Chun <[email protected]> Co-authored-by: Xuhao <[email protected]> Co-authored-by: Sean Baines <[email protected]> Co-authored-by: Abdul Wahab ⚡️ <[email protected]> Co-authored-by: Guillaume Hertault <[email protected]> Co-authored-by: Wataru Ashihara <[email protected]> Co-authored-by: darthmaim <[email protected]> Co-authored-by: Joshua Robinson <[email protected]> Co-authored-by: Andreas Cederström <[email protected]> Co-authored-by: Fabiano Brito <[email protected]> Co-authored-by: Kanitkorn Sujautra <[email protected]> Co-authored-by: Havit Rovik <[email protected]> Co-authored-by: Kent C. Dodds <[email protected]> Co-authored-by: Tharun Rajendran <[email protected]> Co-authored-by: Dylan Staley <[email protected]> Co-authored-by: Donavon West <[email protected]> Co-authored-by: James George <[email protected]> Co-authored-by: RJ Morgan <[email protected]> Co-authored-by: Renato Augusto Gama dos Santos <[email protected]> Co-authored-by: Mateusz Burzyński <[email protected]> Co-authored-by: Alex Guerra <[email protected]> Co-authored-by: Klas Björkqvist <[email protected]> Co-authored-by: Ali Waseem <[email protected]> Co-authored-by: Max Davidson <[email protected]> Co-authored-by: Ben Blank <[email protected]> Co-authored-by: Mike Caulley <[email protected]> Co-authored-by: Trontor <[email protected]> Co-authored-by: Sean Zhu <[email protected]> Co-authored-by: Simon Donaldson <[email protected]> Co-authored-by: Wojciech Zieliński <[email protected]> Co-authored-by: Vadzim <[email protected]> Co-authored-by: Jerome De Leon <[email protected]> Co-authored-by: Peet Goddard <[email protected]> Co-authored-by: Brian Muenzenmeyer <[email protected]> Co-authored-by: Sony AK <[email protected]> Co-authored-by: Kai Hao <[email protected]> Co-authored-by: Tom Valorsa <[email protected]> Co-authored-by: Evan Grim <[email protected]> Co-authored-by: Retsam <[email protected]> Co-authored-by: Vincent Semrau <[email protected]> Co-authored-by: hdineen <[email protected]> Co-authored-by: Rasmus Nørskov <[email protected]> Co-authored-by: Kevin Old <[email protected]> Co-authored-by: Boyuan Xu <[email protected]> Co-authored-by: Alex James Vukovity <[email protected]> Co-authored-by: Marius Craciunoiu <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]> Co-authored-by: Joshua Pollak <[email protected]> Co-authored-by: Hu Chen <[email protected]> Co-authored-by: Cassidy Williams <[email protected]> Co-authored-by: Christopher Button <[email protected]> Co-authored-by: Matthew Curtis <[email protected]> Co-authored-by: Andrew Luca <[email protected]> Co-authored-by: 吕立青 <[email protected]> Co-authored-by: Simen Bekkhus <[email protected]> Co-authored-by: Martin Litvaj <[email protected]> Co-authored-by: Kevin Pham <[email protected]> Co-authored-by: Łukasz Fiszer <[email protected]> Co-authored-by: David Powell <[email protected]> Co-authored-by: Grady Kuhnline <[email protected]> Co-authored-by: Alex Brazier <[email protected]> Co-authored-by: Rohit Singhal <[email protected]> Co-authored-by: Eric Clemmons <[email protected]> Co-authored-by: Kelly <[email protected]> Co-authored-by: Eugene Sviridov <[email protected]> Co-authored-by: Renato Böhler <[email protected]> Co-authored-by: Vincent Semrau <[email protected]> Co-authored-by: Eugene Chybisov <[email protected]> Co-authored-by: Maël Nison <[email protected]> Co-authored-by: Kelsey Leftwich <[email protected]> Co-authored-by: …
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
taktom.
povodcom html code example erroru ked ma viac children bol tento fix #117 ktory opravoval styled components. po tejto zmene som nezaznamenal ze by nieco prestalo ist.
napisal som test.
rucne som preklikal vsetky previews v lighter-styleguide a lighter-app a pozeral ci funguju. funguju. dokonca aj
codeprop, ktory ideme deprecatnut :)