Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add numeric separator support #7817

Merged
merged 9 commits into from
Oct 30, 2019
Merged

Add numeric separator support #7817

merged 9 commits into from
Oct 30, 2019

Conversation

tharun208
Copy link
Contributor

@tharun208 tharun208 commented Oct 13, 2019 •
edited by ianschmitz
Loading

Closes #7329.

This PR has added the support for numeric supporters using babel plugin.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@tharun208 tharun208 changed the title This fixes the issue #7329 This fixes the issue #7329 ( Added numeric support ) Oct 13, 2019
@tharun208 tharun208 mentioned this pull request Oct 16, 2019
Closed
ianschmitz
ianschmitz suggested changes Oct 16, 2019
View reviewed changes
packages/babel-preset-react-app/create.js Outdated Show resolved Hide resolved
packages/babel-preset-react-app/package.json Outdated Show resolved Hide resolved
packages/babel-preset-react-app/package.json Outdated Show resolved Hide resolved
@ianschmitz ianschmitz changed the title This fixes the issue #7329 ( Added numeric support ) Add numeric separator support Oct 16, 2019
@tharun208
Copy link
Contributor Author

Hi @ianschmitz, thanks for reviewing and I fixed the changes, can you check?

@ianschmitz ianschmitz added this to the 3.3 milestone Oct 17, 2019
@tharun208
Copy link
Contributor Author

Hi @ianschmitz, Is there any bug in your CI/CD script, it is running perfectly for some jobs and rest, it is suggesting me to add @babel/plugin-syntax-jsx.That's why, I added the above in the package.json.

@ianschmitz
Copy link
Contributor

I'll take a look after the next run

@tharun208
Copy link
Contributor Author

tharun208 commented Oct 17, 2019 •
edited
Loading

@ianschmitz, Is it good to go? or we can inspect the ci/cd script by giving a test run.

@ianschmitz
Copy link
Contributor

@tharun208 i didn't see any failures in CI. Did i miss something?

@ianschmitz ianschmitz self-assigned this Oct 18, 2019
@tharun208
Copy link
Contributor Author

No @ianschmitz, it is good to go then

@tharun208
Copy link
Contributor Author

Hi @ianschmitz, Do I need to do anything ? or is it good to get merged?

@ianschmitz ianschmitz merged commit b4fe788 into facebook:master Oct 30, 2019
@ianschmitz
Copy link
Contributor

Nope. All good. Thanks @tharun208!

@lock lock bot locked and limited conversation to collaborators Nov 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ianschmitz ianschmitz ianschmitz approved these changes

@iansu iansu iansu approved these changes

@mrmckeb mrmckeb Awaiting requested review from mrmckeb

@petetnt petetnt Awaiting requested review from petetnt

Assignees

@ianschmitz ianschmitz

Labels
CLA Signed tag: new feature
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.

TypeScript: Support numeric separators
4 participants
@tharun208 @facebook-github-bot @ianschmitz @iansu