Remove switch case

[andrelmlins]

In the file react-scripts replaces the switch case with a simple if else. Since there was only one case, it would be nice to replace it with an if else.

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[mrmckeb]

Hi @andrelmlins, thanks for this clean-up. I don't know if there was a reason this was written like this originally, maybe there's a plan to extend the behaviour.

@ianschmitz or @iansu - any ideas?

[iansu]

I'm conflicted on this one because I strongly dislike switch statements but I think it was written that way to make it clear exactly which commands that block of code applies to. Something like this might be best: if (['build', 'eject', 'start', 'test'].includes(script)

[andrelmlins]

Do I make this change?

[iansu]

@andrelmlins Yes, please make this change.

[andrelmlins]

Done

[mrmckeb]

Restarting the CI.

[mrmckeb]

Looks great, and I see you've made @iansu's suggested change. Thanks for the contribution!