Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix broken link for CRA deployment #7897

Merged
merged 1 commit into from
Oct 29, 2019

Conversation

haruelrovix
Copy link
Contributor

Problem

From the build,

Find out more about deployment here:

  https://bit.ly/CRA-deploy

Done in 64.14s.

The link https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/template/README.md#deployment doesn't work anymore.

Proposed solution

Change it to https://create-react-app.dev/docs/deployment.

@facebook-github-bot
Copy link

Hi haruelrovix! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@andriijas andriijas added this to the 3.3 milestone Oct 29, 2019
@andriijas andriijas merged commit 165765d into facebook:master Oct 29, 2019
@haruelrovix haruelrovix deleted the patch-2 branch October 30, 2019 02:56
@lock lock bot locked and limited conversation to collaborators Nov 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants