Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add titleProp to SVGR ReactComponent type definition #8099

Merged
merged 1 commit into from
Jan 30, 2020
Merged

Add titleProp to SVGR ReactComponent type definition #8099

merged 1 commit into from
Jan 30, 2020

Conversation

rhnorskov
Copy link
Contributor

After #7118 was merged, the react-app.d.ts wasn't updated to reflect the new property added, this PR adds that property

@facebook-github-bot
Copy link

Hi rhnorskov! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@andriijas andriijas added this to the 3.3.1 milestone Dec 11, 2019
@ianschmitz ianschmitz merged commit ddcb7d5 into facebook:master Jan 30, 2020
@ianschmitz
Copy link
Contributor

Thanks!

@lock lock bot locked and limited conversation to collaborators Feb 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants