Upgrade to docusaurus 2 #7785
Upgrade to docusaurus 2 #7785
Conversation
There was a problem hiding this comment.
Wow this is awesome. It's nice that there were so few Docusaurus changes to be made. I'm not sure if the CRA maintainers would want to separate out the Markdown changes vs the Docusaurus changes. Might be cleaner, but this looks fine to me.
Approved from the Docusaurus side!
cc @amyrlam here's our long overdue PR 😅
|
@yangshun this looks great! Are there any known limitations or bugs other than the two that you mentioned? Do you think this is ready to replace our current docs? |
|
We're working on the missing docs features (in fact we have them built in facebook/docusaurus#1817 and facebook/docusaurus#1818)! We'll release a new version very soon and help you guys upgrade then. Other than that, maybe the CSS will not render well in IE11 due to usage of CSS variables (but we intend to fix it in future). But that's about it! |
|
@iansu for your review. There's feature parity with V1 now. Thank you! |
|
Looks great! Thanks! |
|
@endiliey Will do! Thanks again. |
Motivation
Hello there, as discussed in #6793 we would like to dogfood docusaurus v2 for CRA. The development experience for v2 is much better because client side rendering is also enabled. The website is also seems to be very performant (its a single page app now but also staticly rendered for SEO)
It's better to test it from netlify preview https://deploy-preview-7785--create-react-app.netlify.com/
Probably what's missing is the "Edit" button on each docs page and a collapsible sidebar. That will come in .alpha.26 instead
Preview
cc @yangshun