Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove error for @typescript-eslint/no-namespace #7803

Merged
merged 2 commits into from
Dec 6, 2019
Merged

Remove error for @typescript-eslint/no-namespace #7803

merged 2 commits into from
Dec 6, 2019

Conversation

szhu
Copy link
Contributor

@szhu szhu commented Oct 10, 2019

Fixes #7651

Haven't tested it yet, if someone can do that then that would be great!

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@stale
Copy link

stale bot commented Nov 9, 2019

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Nov 9, 2019
@szhu szhu marked this pull request as ready for review November 10, 2019 21:14
@stale stale bot removed the stale label Nov 10, 2019
@mrmckeb
Copy link
Contributor

mrmckeb commented Nov 11, 2019

@heyimalex can you please take a look at this one? Looks good to me, based on the conversation you had in the related issue.

@mrmckeb mrmckeb added this to the 3.4 milestone Nov 11, 2019
@heyimalex
Copy link
Contributor

Double checked that the typescript test works with declare, fails without declare, which is what you would expect. This is good to go.

@szhu
Copy link
Contributor Author

szhu commented Nov 12, 2019

Great, thank you! I don't see a merge button -- let me know if anything else is needed on my end to merge this.

@szhu
Copy link
Contributor Author

szhu commented Dec 6, 2019

Hey @heyimalex, just wanted to check in again to see if there is any action waiting on me before this is merged.

@heyimalex heyimalex merged commit b19bffe into facebook:master Dec 6, 2019
@szhu szhu deleted the patch-1 branch December 6, 2019 22:06
@lock lock bot locked and limited conversation to collaborators Dec 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create-react-app enforces @typescript-eslint/no-namespace, a style rule
4 participants