Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue of broken links to translated docs #2 #22270

Merged
merged 1 commit into from
Jul 3, 2020
Merged

Fix issue of broken links to translated docs #2 #22270

merged 1 commit into from
Jul 3, 2020

Conversation

pjhwa
Copy link
Contributor

@pjhwa pjhwa commented Jul 2, 2020

Closes #22266

This PR contains the following translated docs which has the broken links of static/_redirects.

  • content/ko/docs/concepts/cluster-administration/cluster-administration-overview.md
  • content/ko/docs/concepts/extend-kubernetes/api-extension/custom-resources.md
  • content/ko/docs/concepts/extend-kubernetes/compute-storage-net/device-plugins.md
  • content/ko/docs/concepts/extend-kubernetes/extend-cluster.md
  • content/ko/docs/concepts/policy/limit-range.md
  • content/ko/docs/concepts/policy/resource-quotas.md
  • content/ko/docs/concepts/scheduling-eviction/taint-and-toleration.md
  • content/ko/docs/concepts/storage/storage-classes.md
  • content/ko/docs/contribute/style/write-new-topic.md
  • content/ko/docs/reference/using-api/api-overview.md
  • content/ko/docs/reference/using-api/client-libraries.md
  • content/ko/docs/setup/best-practices/cluster-large.md
  • content/ko/docs/setup/learning-environment/minikube.md
  • content/ko/docs/setup/production-environment/tools/kops.md
  • content/ko/docs/tasks/access-application-cluster/web-ui-dashboard.md
  • content/ko/docs/tutorials/hello-minikube.md

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 2, 2020
@k8s-ci-robot k8s-ci-robot added language/ko Issues or PRs related to Korean language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 2, 2020
@pjhwa
Copy link
Contributor Author

pjhwa commented Jul 2, 2020 •
edited
Loading

간단한 스크립트를 하나 만들었습니다.
참고하세요~

https://github.com/pjhwa/k8s-ko-docs-scripts/blob/master/findbrokenlinks.sh

  • 한글로 번역된 문서 중 이미 번역된 문서 대신 영문 문서를 가리키고 있는 부분을 찾아줍니다.
  • 한글로 번역된 문서 중 website/static/_redirects 에 포함된 URL(이미 한글 번역이 되어있는 문서로의)이 있는 부분을 찾아줍니다.

@netlify
Copy link

netlify bot commented Jul 2, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 5fed746

https://deploy-preview-22270--kubernetes-io-master-staging.netlify.app

@gochist
Copy link
Member

gochist commented Jul 3, 2020

/assign @yoonian

@yoonian
Copy link
Contributor

yoonian commented Jul 3, 2020 •
edited
Loading

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 3, 2020
@tengqm
Copy link
Contributor

tengqm commented Jul 3, 2020

sigh ... this is dirty ...
we are suffering from the same problem in zh localization

@pjhwa
Copy link
Contributor Author

pjhwa commented Jul 3, 2020

sigh ... this is dirty ...
we are suffering from the same problem in zh localization

@tengqm I think you can try to use my script for that problem.
https://github.com/pjhwa/k8s-ko-docs-scripts/blob/master/findbrokenlinks.sh
It's very simple, so you can understand how to use it. (just change ko to zh in the script)

@gochist
Copy link
Member

gochist commented Jul 3, 2020

@pjhwa It looks like duplicated effort with #21996

@tengqm
Copy link
Contributor

tengqm commented Jul 3, 2020

@pjhwa I'm not referring to the tricks of finding and fixing the links. I'm referring to the fact that the links in the English site is not friendly to localizations. See #19526

@pjhwa
Copy link
Contributor Author

pjhwa commented Jul 3, 2020

I'm not referring to the tricks of finding and fixing the links. I'm referring to the fact that the links in the English site is not friendly to localizations. See #19526

Yes, I didn't know that the effort already is on going.
Right. English site is not friendly to localizations.

@gochist
Copy link
Member

gochist commented Jul 3, 2020

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 3, 2020
@gochist
Copy link
Member

gochist commented Jul 3, 2020

@pjhwa @yoonian I'm sorry that I checked the base branch late. Merging directly into the master branch should be avoided if possible. This is because there is a high possibility of conflict in the process of merging the team milestone branch into the master.

@pjhwa Would you please rebase this onto dev-1.18-ko.7?

@gochist gochist mentioned this pull request Jul 3, 2020
Merged
@pjhwa pjhwa changed the base branch from master to dev-1.18-ko.7 July 3, 2020 09:49
@pjhwa
Copy link
Contributor Author

pjhwa commented Jul 3, 2020 •
edited
Loading

@gochist 현재 작업 브랜치로 변경하였습니다. (링크 수정은 bug fix로 생각해서 master를 타겟으로 했었습니다. 앞으로는 주의하겠습니다.)

@gochist
Copy link
Member

gochist commented Jul 3, 2020 •
edited
Loading

@gochist 현재 작업 브랜치로 변경하였습니다. (링크 수정은 bug fix로 생각해서 master를 타겟으로 했었습니다. 앞으로는 주의하겠습니다.)

리뷰어나 승인자 간 기준이 명확하지 않아 불편을 드린 것 같습니다. master에 직접 변경을 허용하는 경우는 버그 수정 건 중, 라이브에 즉시 적용되어야하는 시급한 건, 또는 팀 마일스톤 브랜치에 익숙하지 않은 업스트림 컨트리뷰터의 작은 변경 건을 예외적으로 승인하곤 했습니다. 논의를 거쳐 명문화할 수 있도록 하겠습니다.

@gochist
Copy link
Member

gochist commented Jul 3, 2020

/hold cancel
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 3, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gochist

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2020
@k8s-ci-robot k8s-ci-robot merged commit 8ba2941 into kubernetes:dev-1.18-ko.7 Jul 3, 2020
@gochist
Copy link
Member

gochist commented Jul 6, 2020

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 6, 2020
gochist added a commit that referenced this pull request Jul 10, 2020
@gochist @pjhwa
@woopyoung @coolguyhong @yoonian @seokho-son @jmyung @ianychoi
Seventh Korean l10n work for release 1.18
d48f79a 
- Translate reference/command-line-tools-reference/feature-gates.md int… (#22240)
- Fix issue of broken links to translated docs (#22105)
- Fix issue of document link in some ko documents (#22379)
- Translate tasks/administer-cluster/access-cluster-services.md into Ko… (#21776)
- Fix issue with 'Linux' and 'Windows' notation in Korean docs (#22362)
- Fix issue of broken links to translated docs #2 (#22270)
- Fix issue with k8s.io/ko/docs/concepts/overview/kubernetes-api.md (#22261)
- Fix issue with k8s.io/ko/docs/concepts/overview/working-with-objects/ (#22263)
- Fix incorrect notation of 'directory' into Korean (#22155)
- Fix issue with k8s.io/ko/docs/concepts/overview/components.md (#22232)
- Update outdated files in dev-1.18-ko.7 (#22128)
- Modify spacing term ReplicaSet in Korean (#22148)

Co-authored-by: Jerry Park <[email protected]>
Co-authored-by: woopyoung <[email protected]>
Co-authored-by: coolguyhong <[email protected]>
Co-authored-by: PyungHo Yoon <[email protected]>
Co-authored-by: Seokho Son <[email protected]>
Co-authored-by: jmyung <[email protected]>
Co-authored-by: Ian Y. Choi <[email protected]>
@gochist gochist mentioned this pull request Jul 10, 2020
Merged
gochist added a commit that referenced this pull request Jul 10, 2020
@gochist @pjhwa
@woopyoung @coolguyhong @yoonian @seokho-son @jmyung @ianychoi
Seventh Korean l10n work for release 1.18
f604a4b 
- Translate reference/command-line-tools-reference/feature-gates.md int… (#22240)
- Fix issue of broken links to translated docs (#22105)
- Fix issue of document link in some ko documents (#22379)
- Translate tasks/administer-cluster/access-cluster-services.md into Ko… (#21776)
- Fix issue with 'Linux' and 'Windows' notation in Korean docs (#22362)
- Fix issue of broken links to translated docs #2 (#22270)
- Fix issue with k8s.io/ko/docs/concepts/overview/kubernetes-api.md (#22261)
- Fix issue with k8s.io/ko/docs/concepts/overview/working-with-objects/ (#22263)
- Fix incorrect notation of 'directory' into Korean (#22155)
- Fix issue with k8s.io/ko/docs/concepts/overview/components.md (#22232)
- Update outdated files in dev-1.18-ko.7 (#22128)
- Modify spacing term ReplicaSet in Korean (#22148)
- Translate tasks/administer-cluster/extended-resource-node.md into Korean (#21849)
- Translate tasks/administer-cluster/access-cluster-api.md into Korean (#21730)

Co-authored-by: Jerry Park <[email protected]>
Co-authored-by: woopyoung <[email protected]>
Co-authored-by: coolguyhong <[email protected]>
Co-authored-by: PyungHo Yoon <[email protected]>
Co-authored-by: Seokho Son <[email protected]>
Co-authored-by: jmyung <[email protected]>
Co-authored-by: Ian Y. Choi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianychoi ianychoi Awaiting requested review from ianychoi

@ysyukr ysyukr Awaiting requested review from ysyukr

Assignees

@gochist gochist

@yoonian yoonian

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue of broken links to translated docs #2
5 participants
@pjhwa @gochist @yoonian @tengqm @k8s-ci-robot