Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate tasks/administer-cluster/access-cluster-services.md into Ko… #21776

Merged
merged 1 commit into from
Jul 7, 2020

Conversation

pjhwa
Copy link
Contributor

@pjhwa pjhwa commented Jun 15, 2020

Closes #21775

This PR has a link to translated document via PR #21729 which is not merged yet.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 15, 2020
@k8s-ci-robot k8s-ci-robot added language/ko Issues or PRs related to Korean language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jun 15, 2020
@netlify
Copy link

netlify bot commented Jun 15, 2020

Deploy preview for k8s-dev-ko ready!

Built with commit 2b628c8

https://deploy-preview-21776--k8s-dev-ko.netlify.app

@pjhwa
Copy link
Contributor Author

pjhwa commented Jun 15, 2020

Preview page: https://deploy-preview-21776--k8s-dev-ko.netlify.app/ko/docs/tasks/administer-cluster/access-cluster-services/

@seokho-son
Copy link
Member

/assign @ianychoi

@gochist gochist force-pushed the dev-1.18-ko.6 branch 2 times, most recently from e7cc346 to 34be3c1 Compare June 26, 2020 13:43
@pjhwa pjhwa changed the base branch from dev-1.18-ko.6 to dev-1.18-ko.7 June 28, 2020 22:03
@pjhwa
Copy link
Contributor Author

pjhwa commented Jul 1, 2020

/ping @ianychoi

Are you available to review this PR?


클러스터 외부에서 노드, 파드 및 서비스에 연결하기 위한 몇 가지 옵션이 있다.

- 퍼블릭 IP를 통해 서비스에 접근한다.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"퍼블릭 IP" needs to be discussed in future

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"private/public" 에 대한 번역은 "프라이빗/퍼블릭", "개인/공용(공개)" 와 같이 논의가 필요할 것 같습니다.

- 클러스터 환경에 따라, 서비스가 회사 네트워크에 노출되거나,
인터넷에 노출될 수 있다. 노출되는 서비스가 안전한지 생각한다.
자체 인증을 수행하는가?
- 서비스 뒤에 파드를 배치한다. 디버깅과 같은 목적으로 레플리카 세트에서 특정 파드에 접근하려면,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

원문에는 "ReplicaSet or replicaset"이 아니라 "a set of replicas"라 되어있어서, "세트"라 표현했습니다. 아니면 "집합"으로 하는게 나으려나요?

To access one specific pod from a set of replicas, such as for debugging,

`http://localhost:8080/api/v1/namespaces/kube-system/services/elasticsearch-logging/proxy/`.

{{< note >}}
자격 증명을 전달하거나 kubectl proxy를 사용하는 방법은 [쿠버네티스 API를 사용하여 클러스터에 접근하기](/ko/docs/tasks/administer-cluster/access-cluster-api/)를 참고한다.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has a dependency on #21730 - unless this merges, "/ko" cannot be used. @seokho-son thoughts?

Copy link
Contributor

@ianychoi ianychoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My overall impression on this PR is:

  • well aligned with glossary and best practices of K8s Korean L10n team translation experiences: great!
  • translated terms are not reader-friendly: seems that rough draft translation was done with machine translation. That is okay but please it would be great if you spend more time on this perspective.

Please reflect the changes including my detail comments.

By the way, when I read "Are you available to review this PR?" sentence, honestly, I am not 100% happy. Not only you are volunteering to contribute (as a reviewer I really appreciate it), reviewers would like to help as much as possible but please do not use some English nuances which may potentially contain harmful feeling. Hopefully I over-interpreted the sentence or the sentence has not fully reflected from your translation from Korean to English to ask reviewers. I have just searched on Internet and copying this URL for all.. https://medium.com/better-programming/pull-request-etiquettes-for-reviewer-and-author-f4e80360f92c .

@pjhwa
Copy link
Contributor Author

pjhwa commented Jul 2, 2020

@ianychoi Thank you for your review. I updated this PR as your comments.

By the way, when I read "Are you available to review this PR?" sentence, honestly, I am not 100% happy. Not only you are volunteering to contribute (as a reviewer I really appreciate it), reviewers would like to help as much as possible but please do not use some English nuances which may potentially contain harmful feeling. Hopefully I over-interpreted the sentence or the sentence has not fully reflected from your translation from Korean to English to ask reviewers. I have just searched on Internet and copying this URL for all.. https://medium.com/better-programming/pull-request-etiquettes-for-reviewer-and-author-f4e80360f92c .

I'm still a newbie to open source contribution. So there may be some mistakes. (It seems that the nuances were conveyed due to my lack of English.) Thank you for your comment about my mistake. I'll be more careful about it in the future.

@ianychoi
Copy link
Contributor

ianychoi commented Jul 7, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ianychoi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2020
@k8s-ci-robot k8s-ci-robot merged commit b221a47 into kubernetes:dev-1.18-ko.7 Jul 7, 2020
gochist added a commit that referenced this pull request Jul 10, 2020
- Translate reference/command-line-tools-reference/feature-gates.md int… (#22240)
- Fix issue of broken links to translated docs (#22105)
- Fix issue of document link in some ko documents (#22379)
- Translate tasks/administer-cluster/access-cluster-services.md into Ko… (#21776)
- Fix issue with 'Linux' and 'Windows' notation in Korean docs (#22362)
- Fix issue of broken links to translated docs #2 (#22270)
- Fix issue with k8s.io/ko/docs/concepts/overview/kubernetes-api.md (#22261)
- Fix issue with k8s.io/ko/docs/concepts/overview/working-with-objects/ (#22263)
- Fix incorrect notation of 'directory' into Korean (#22155)
- Fix issue with k8s.io/ko/docs/concepts/overview/components.md (#22232)
- Update outdated files in dev-1.18-ko.7 (#22128)
- Modify spacing term ReplicaSet in Korean (#22148)

Co-authored-by: Jerry Park <[email protected]>
Co-authored-by: woopyoung <[email protected]>
Co-authored-by: coolguyhong <[email protected]>
Co-authored-by: PyungHo Yoon <[email protected]>
Co-authored-by: Seokho Son <[email protected]>
Co-authored-by: jmyung <[email protected]>
Co-authored-by: Ian Y. Choi <[email protected]>
gochist added a commit that referenced this pull request Jul 10, 2020
- Translate reference/command-line-tools-reference/feature-gates.md int… (#22240)
- Fix issue of broken links to translated docs (#22105)
- Fix issue of document link in some ko documents (#22379)
- Translate tasks/administer-cluster/access-cluster-services.md into Ko… (#21776)
- Fix issue with 'Linux' and 'Windows' notation in Korean docs (#22362)
- Fix issue of broken links to translated docs #2 (#22270)
- Fix issue with k8s.io/ko/docs/concepts/overview/kubernetes-api.md (#22261)
- Fix issue with k8s.io/ko/docs/concepts/overview/working-with-objects/ (#22263)
- Fix incorrect notation of 'directory' into Korean (#22155)
- Fix issue with k8s.io/ko/docs/concepts/overview/components.md (#22232)
- Update outdated files in dev-1.18-ko.7 (#22128)
- Modify spacing term ReplicaSet in Korean (#22148)
- Translate tasks/administer-cluster/extended-resource-node.md into Korean (#21849)
- Translate tasks/administer-cluster/access-cluster-api.md into Korean (#21730)

Co-authored-by: Jerry Park <[email protected]>
Co-authored-by: woopyoung <[email protected]>
Co-authored-by: coolguyhong <[email protected]>
Co-authored-by: PyungHo Yoon <[email protected]>
Co-authored-by: Seokho Son <[email protected]>
Co-authored-by: jmyung <[email protected]>
Co-authored-by: Ian Y. Choi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants