Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with k8s.io/ko/docs/concepts/overview/components.md #22232

Merged
merged 1 commit into from
Jul 1, 2020
Merged

Fix issue with k8s.io/ko/docs/concepts/overview/components.md #22232

merged 1 commit into from
Jul 1, 2020

Conversation

woopyoung
Copy link
Contributor

Fix #22230

@k8s-ci-robot
Copy link
Contributor

Welcome @woopyoung!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 1, 2020
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jul 1, 2020
@netlify
Copy link

netlify bot commented Jul 1, 2020

Deploy preview for k8s-dev-ko ready!

Built with commit 31da383

https://deploy-preview-22232--k8s-dev-ko.netlify.app

@gochist
Copy link
Member

gochist commented Jul 1, 2020

@woopyoung 감사합니다!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gochist

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2020
@gochist
Copy link
Member

gochist commented Jul 1, 2020

@woopyoung PR을 처리하기 위해서 CLA 서명을 부탁드립니다.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 1, 2020
woopyoung
woopyoung commented Jul 1, 2020
View reviewed changes
Copy link
Contributor Author

@woopyoung woopyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Submit after changing email for CLA sign

@gochist
Copy link
Member

gochist commented Jul 1, 2020

@woopyoung 감사합니다!
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 1, 2020
@gochist
Copy link
Member

gochist commented Jul 1, 2020

/check-cla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 1, 2020
@k8s-ci-robot k8s-ci-robot merged commit 51e0b79 into kubernetes:dev-1.18-ko.7 Jul 1, 2020
@pjhwa
Copy link
Contributor

pjhwa commented Jul 1, 2020

Congratulations for your first contribution to kubernetes/website, @woopyoung !

gochist added a commit that referenced this pull request Jul 10, 2020
@gochist @pjhwa
@woopyoung @coolguyhong @yoonian @seokho-son @jmyung @ianychoi
Seventh Korean l10n work for release 1.18
d48f79a 
- Translate reference/command-line-tools-reference/feature-gates.md int… (#22240)
- Fix issue of broken links to translated docs (#22105)
- Fix issue of document link in some ko documents (#22379)
- Translate tasks/administer-cluster/access-cluster-services.md into Ko… (#21776)
- Fix issue with 'Linux' and 'Windows' notation in Korean docs (#22362)
- Fix issue of broken links to translated docs #2 (#22270)
- Fix issue with k8s.io/ko/docs/concepts/overview/kubernetes-api.md (#22261)
- Fix issue with k8s.io/ko/docs/concepts/overview/working-with-objects/ (#22263)
- Fix incorrect notation of 'directory' into Korean (#22155)
- Fix issue with k8s.io/ko/docs/concepts/overview/components.md (#22232)
- Update outdated files in dev-1.18-ko.7 (#22128)
- Modify spacing term ReplicaSet in Korean (#22148)

Co-authored-by: Jerry Park <[email protected]>
Co-authored-by: woopyoung <[email protected]>
Co-authored-by: coolguyhong <[email protected]>
Co-authored-by: PyungHo Yoon <[email protected]>
Co-authored-by: Seokho Son <[email protected]>
Co-authored-by: jmyung <[email protected]>
Co-authored-by: Ian Y. Choi <[email protected]>
@gochist gochist mentioned this pull request Jul 10, 2020
Merged
gochist added a commit that referenced this pull request Jul 10, 2020
@gochist @pjhwa
@woopyoung @coolguyhong @yoonian @seokho-son @jmyung @ianychoi
Seventh Korean l10n work for release 1.18
f604a4b 
- Translate reference/command-line-tools-reference/feature-gates.md int… (#22240)
- Fix issue of broken links to translated docs (#22105)
- Fix issue of document link in some ko documents (#22379)
- Translate tasks/administer-cluster/access-cluster-services.md into Ko… (#21776)
- Fix issue with 'Linux' and 'Windows' notation in Korean docs (#22362)
- Fix issue of broken links to translated docs #2 (#22270)
- Fix issue with k8s.io/ko/docs/concepts/overview/kubernetes-api.md (#22261)
- Fix issue with k8s.io/ko/docs/concepts/overview/working-with-objects/ (#22263)
- Fix incorrect notation of 'directory' into Korean (#22155)
- Fix issue with k8s.io/ko/docs/concepts/overview/components.md (#22232)
- Update outdated files in dev-1.18-ko.7 (#22128)
- Modify spacing term ReplicaSet in Korean (#22148)
- Translate tasks/administer-cluster/extended-resource-node.md into Korean (#21849)
- Translate tasks/administer-cluster/access-cluster-api.md into Korean (#21730)

Co-authored-by: Jerry Park <[email protected]>
Co-authored-by: woopyoung <[email protected]>
Co-authored-by: coolguyhong <[email protected]>
Co-authored-by: PyungHo Yoon <[email protected]>
Co-authored-by: Seokho Son <[email protected]>
Co-authored-by: jmyung <[email protected]>
Co-authored-by: Ian Y. Choi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianychoi ianychoi Awaiting requested review from ianychoi

@seokho-son seokho-son Awaiting requested review from seokho-son

Assignees

@gochist gochist

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@woopyoung @k8s-ci-robot @gochist @pjhwa