Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate tasks/administer-cluster/access-cluster-api.md into Korean #21730

Merged
merged 1 commit into from
Jul 10, 2020

Conversation

pjhwa
Copy link
Contributor

@pjhwa pjhwa commented Jun 14, 2020

Closes #21729

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 14, 2020
@k8s-ci-robot k8s-ci-robot added language/ko Issues or PRs related to Korean language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 14, 2020
@netlify
Copy link

netlify bot commented Jun 14, 2020

Deploy preview for k8s-dev-ko ready!

Built with commit 56f712f

https://deploy-preview-21730--k8s-dev-ko.netlify.app

@pjhwa
Copy link
Contributor Author

pjhwa commented Jun 14, 2020

@seokho-son
Copy link
Member

/assign @claudiajkang

@pjhwa pjhwa changed the base branch from dev-1.18-ko.6 to dev-1.18-ko.7 June 28, 2020 22:03
@pjhwa
Copy link
Contributor Author

pjhwa commented Jul 1, 2020

/ping @claudiajkang

Are you available to review this PR?

@seokho-son
Copy link
Member

@pjhwa 컨트리뷰션 감사합니다.. ^^ 현재 PR Assign 되어 있는 @claudiajkang 께서 아래와 같이 슬랙으로 응답 주셨습니다. 참고하시기 바랍니다.

[Info] @claudiajkang notified her schedule as follows,
이번 마일스톤 리뷰 및 승인 작업이 어려울 것 같습니다.
현재 ko.6서에 assign 받은 건은 7/2일 이후에 리뷰가능 할 것 같습니다.

@gochist
Copy link
Member

gochist commented Jul 3, 2020

/unassign @claudiajkang
/assign

@k8s-ci-robot k8s-ci-robot assigned gochist and unassigned claudiajkang Jul 3, 2020
@gochist
Copy link
Member

gochist commented Jul 6, 2020

@pjhwa 감사합니다! 리뷰가 늦어 죄송합니다.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 6, 2020
@gochist
Copy link
Member

gochist commented Jul 6, 2020

저자와 제가 소속 회사가 같아 되도록이면 다른 승인자가 승인해주시면 좋겠습니다.

/unassign
/assign @ianychoi

@k8s-ci-robot k8s-ci-robot assigned ianychoi and unassigned gochist Jul 6, 2020
@pjhwa
Copy link
Contributor Author

pjhwa commented Jul 6, 2020

@pjhwa 감사합니다! 리뷰가 늦어 죄송합니다.
/lgtm

@gochist 바쁘실텐데 리뷰 감사합니다. :-)

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2020
@gochist
Copy link
Member

gochist commented Jul 9, 2020

@ianychoi 👋 오늘이 마일스톤 종료일이네요. 검토 부탁드립니다.

@ianychoi
Copy link
Contributor

/lgtm /approve

@gochist
Copy link
Member

gochist commented Jul 10, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gochist

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2020
@k8s-ci-robot k8s-ci-robot merged commit 5c22c35 into kubernetes:dev-1.18-ko.7 Jul 10, 2020
gochist added a commit that referenced this pull request Jul 10, 2020
- Translate reference/command-line-tools-reference/feature-gates.md int… (#22240)
- Fix issue of broken links to translated docs (#22105)
- Fix issue of document link in some ko documents (#22379)
- Translate tasks/administer-cluster/access-cluster-services.md into Ko… (#21776)
- Fix issue with 'Linux' and 'Windows' notation in Korean docs (#22362)
- Fix issue of broken links to translated docs #2 (#22270)
- Fix issue with k8s.io/ko/docs/concepts/overview/kubernetes-api.md (#22261)
- Fix issue with k8s.io/ko/docs/concepts/overview/working-with-objects/ (#22263)
- Fix incorrect notation of 'directory' into Korean (#22155)
- Fix issue with k8s.io/ko/docs/concepts/overview/components.md (#22232)
- Update outdated files in dev-1.18-ko.7 (#22128)
- Modify spacing term ReplicaSet in Korean (#22148)
- Translate tasks/administer-cluster/extended-resource-node.md into Korean (#21849)
- Translate tasks/administer-cluster/access-cluster-api.md into Korean (#21730)

Co-authored-by: Jerry Park <[email protected]>
Co-authored-by: woopyoung <[email protected]>
Co-authored-by: coolguyhong <[email protected]>
Co-authored-by: PyungHo Yoon <[email protected]>
Co-authored-by: Seokho Son <[email protected]>
Co-authored-by: jmyung <[email protected]>
Co-authored-by: Ian Y. Choi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants