Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate tasks/administer-cluster/extended-resource-node.md into Korean #21849

Merged
merged 1 commit into from
Jul 10, 2020

Conversation

pjhwa
Copy link
Contributor

@pjhwa pjhwa commented Jun 17, 2020

Closes #21848

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 17, 2020
@k8s-ci-robot k8s-ci-robot added language/ko Issues or PRs related to Korean language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jun 17, 2020
@netlify
Copy link

netlify bot commented Jun 17, 2020

Deploy preview for k8s-dev-ko ready!

Built with commit 215b17e

https://deploy-preview-21849--k8s-dev-ko.netlify.app

@pjhwa
Copy link
Contributor Author

pjhwa commented Jun 17, 2020

@seokho-son
Copy link
Member

/assign @claudiajkang

@gochist gochist force-pushed the dev-1.18-ko.6 branch 2 times, most recently from e7cc346 to 34be3c1 Compare June 26, 2020 13:43
@pjhwa pjhwa changed the base branch from dev-1.18-ko.6 to dev-1.18-ko.7 June 28, 2020 22:02
@gochist
Copy link
Member

gochist commented Jul 3, 2020

/unassign @claudiajkang
/assign @jmyung

@k8s-ci-robot k8s-ci-robot assigned jmyung and unassigned claudiajkang Jul 3, 2020
Copy link
Member

@jmyung jmyung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pjhwa 수고하셨습니다.
몇 가지 의견 드립니다.

@pjhwa
Copy link
Contributor Author

pjhwa commented Jul 5, 2020

@jmyung 리뷰 감사합니다.
의견 주신 내용은 모두 반영하였습니다.

@gochist
Copy link
Member

gochist commented Jul 9, 2020

@jmyung 리뷰 완료 시 lgtm 레이블 추가 부탁드립니다.

@jmyung
Copy link
Member

jmyung commented Jul 9, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 9, 2020
@gochist
Copy link
Member

gochist commented Jul 9, 2020

저자, 리뷰어, 제가 모두 같은 회사 소속이라 되도록이면 다른 소속의 승인자께서 승인해주시면 좋겠습니다.
/assign @ianychoi

@gochist
Copy link
Member

gochist commented Jul 9, 2020

/unassign @jmyung

@ianychoi
Copy link
Contributor

아 12시간 전에 제게 할당된 것을 몰랐습니다. 확인해보니 괜찮네요. 모두 고생하셨습니다.

@ianychoi
Copy link
Contributor

/lgtm /approve

@gochist
Copy link
Member

gochist commented Jul 10, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gochist

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2020
@k8s-ci-robot k8s-ci-robot merged commit 6abb221 into kubernetes:dev-1.18-ko.7 Jul 10, 2020
gochist added a commit that referenced this pull request Jul 10, 2020
- Translate reference/command-line-tools-reference/feature-gates.md int… (#22240)
- Fix issue of broken links to translated docs (#22105)
- Fix issue of document link in some ko documents (#22379)
- Translate tasks/administer-cluster/access-cluster-services.md into Ko… (#21776)
- Fix issue with 'Linux' and 'Windows' notation in Korean docs (#22362)
- Fix issue of broken links to translated docs #2 (#22270)
- Fix issue with k8s.io/ko/docs/concepts/overview/kubernetes-api.md (#22261)
- Fix issue with k8s.io/ko/docs/concepts/overview/working-with-objects/ (#22263)
- Fix incorrect notation of 'directory' into Korean (#22155)
- Fix issue with k8s.io/ko/docs/concepts/overview/components.md (#22232)
- Update outdated files in dev-1.18-ko.7 (#22128)
- Modify spacing term ReplicaSet in Korean (#22148)
- Translate tasks/administer-cluster/extended-resource-node.md into Korean (#21849)
- Translate tasks/administer-cluster/access-cluster-api.md into Korean (#21730)

Co-authored-by: Jerry Park <[email protected]>
Co-authored-by: woopyoung <[email protected]>
Co-authored-by: coolguyhong <[email protected]>
Co-authored-by: PyungHo Yoon <[email protected]>
Co-authored-by: Seokho Son <[email protected]>
Co-authored-by: jmyung <[email protected]>
Co-authored-by: Ian Y. Choi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants