Fix issue with 'Linux' and 'Windows' notation in Korean docs #22362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
sig/docs
|
Deploy preview for k8s-dev-ko ready! Built with commit dbf48ae |
|
Deploy preview for k8s-dev-ko ready! Built with commit b0bb48b |
|
@pjhwa 감사합니다! |
k8s-ci-robot
added
the
lgtm
|
저자과 제가 같은 회사 소속이므로 되도록이면 다른 승인자께서 승인해주셨으면 합니다. |
|
감사합니다.. ^^ |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: seokho-son The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
sftim
reviewed
Jul 6, 2020
| * Windows 컨테이너를 호스팅하는 Windows 노드를 구성하려면 | ||
| [Windows Server 2019 라이선스](https://www.microsoft.com/en-us/cloud-platform/windows-server-pricing) 이상이 필요하다. | ||
| * 윈도우 컨테이너를 호스팅하는 윈도우 노드를 구성하려면 | ||
| [윈도우 서버 2019 라이선스](https://www.microsoft.com/en-us/cloud-platform/windows-server-pricing) 이상이 필요하다. |
There was a problem hiding this comment.
nit: The product name is Windows Server 2019, according to the page linked to.
There was a problem hiding this comment.
@sftim I agree. And I think it should be link to Korean page. I'll update on the next branch.
gochist
added a commit
that referenced
this pull request
Jul 10, 2020
- Translate reference/command-line-tools-reference/feature-gates.md int… (#22240) - Fix issue of broken links to translated docs (#22105) - Fix issue of document link in some ko documents (#22379) - Translate tasks/administer-cluster/access-cluster-services.md into Ko… (#21776) - Fix issue with 'Linux' and 'Windows' notation in Korean docs (#22362) - Fix issue of broken links to translated docs #2 (#22270) - Fix issue with k8s.io/ko/docs/concepts/overview/kubernetes-api.md (#22261) - Fix issue with k8s.io/ko/docs/concepts/overview/working-with-objects/ (#22263) - Fix incorrect notation of 'directory' into Korean (#22155) - Fix issue with k8s.io/ko/docs/concepts/overview/components.md (#22232) - Update outdated files in dev-1.18-ko.7 (#22128) - Modify spacing term ReplicaSet in Korean (#22148) Co-authored-by: Jerry Park <[email protected]> Co-authored-by: woopyoung <[email protected]> Co-authored-by: coolguyhong <[email protected]> Co-authored-by: PyungHo Yoon <[email protected]> Co-authored-by: Seokho Son <[email protected]> Co-authored-by: jmyung <[email protected]> Co-authored-by: Ian Y. Choi <[email protected]>
gochist
added a commit
that referenced
this pull request
Jul 10, 2020
- Translate reference/command-line-tools-reference/feature-gates.md int… (#22240) - Fix issue of broken links to translated docs (#22105) - Fix issue of document link in some ko documents (#22379) - Translate tasks/administer-cluster/access-cluster-services.md into Ko… (#21776) - Fix issue with 'Linux' and 'Windows' notation in Korean docs (#22362) - Fix issue of broken links to translated docs #2 (#22270) - Fix issue with k8s.io/ko/docs/concepts/overview/kubernetes-api.md (#22261) - Fix issue with k8s.io/ko/docs/concepts/overview/working-with-objects/ (#22263) - Fix incorrect notation of 'directory' into Korean (#22155) - Fix issue with k8s.io/ko/docs/concepts/overview/components.md (#22232) - Update outdated files in dev-1.18-ko.7 (#22128) - Modify spacing term ReplicaSet in Korean (#22148) - Translate tasks/administer-cluster/extended-resource-node.md into Korean (#21849) - Translate tasks/administer-cluster/access-cluster-api.md into Korean (#21730) Co-authored-by: Jerry Park <[email protected]> Co-authored-by: woopyoung <[email protected]> Co-authored-by: coolguyhong <[email protected]> Co-authored-by: PyungHo Yoon <[email protected]> Co-authored-by: Seokho Son <[email protected]> Co-authored-by: jmyung <[email protected]> Co-authored-by: Ian Y. Choi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22360
This PR replaces 'Linux' and 'Windows' with '리눅스' and '윈도우' in the following pages: