Skip to content

Conversation

@laoneo
Copy link
Member

@laoneo laoneo commented Jan 13, 2023

Summary of Changes

Converts the tinymce editor to service providers.

Testing Instructions

  • Make sure TinyMCE is the default editor
  • Edit an article

Also test if the other editors do still work

Actual result BEFORE applying this Pull Request

All works.

Expected result AFTER applying this Pull Request

All works.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@dgrammatiko
Copy link
Contributor

@laoneo thank you for the one! I'll test it in a bit

@laoneo
Copy link
Member Author

laoneo commented Jan 13, 2023

I'v uploaded a fix, it should work now. Strange thing was that it loaded without that change for me

@dgrammatiko
Copy link
Contributor

dgrammatiko commented Jan 13, 2023

I have tested this item ✅ successfully on 53b65ed

Tip for the next tester: delete the file administrator/cache/autoload_psr4.php prior testing


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39625.

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 15e3454

Based on the test instructions I am marking this as a successful test. Can't really comment on the code changes themselves


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39625.

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 15e3454


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39625.

@laoneo
Copy link
Member Author

laoneo commented Jan 15, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39625.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 15, 2023
@obuisard obuisard added this to the Joomla! 4.3.0 milestone Jan 15, 2023
@obuisard obuisard merged commit 91300ad into joomla:4.3-dev Jan 15, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 15, 2023
@obuisard
Copy link
Contributor

Thank you Allon @laoneo!

@laoneo laoneo deleted the provider/editor/tinymce branch January 15, 2023 17:02
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants