-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Converts tinymce to service providers #39625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converts tinymce to service providers #39625
Conversation
|
@laoneo thank you for the one! I'll test it in a bit |
Co-authored-by: Dimitris Grammatikogiannis <[email protected]>
|
I'v uploaded a fix, it should work now. Strange thing was that it loaded without that change for me |
|
I have tested this item ✅ successfully on 53b65ed This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39625. |
|
I have tested this item ✅ successfully on 15e3454 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39625. |
|
I have tested this item ✅ successfully on 15e3454 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39625. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39625. |
|
Thank you Allon @laoneo! |
Add deleted files from PRs joomla#39379 , joomla#39539 , joomla#39624 , joomla#39649 and joomla#39625 .
Summary of Changes
Converts the tinymce editor to service providers.
Testing Instructions
Also test if the other editors do still work
Actual result BEFORE applying this Pull Request
All works.
Expected result AFTER applying this Pull Request
All works.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed